|
2018-02-14 00:21:47
|
<Dispenser>
|
What's is a good name for a dump search tool?
|
|
2018-02-14 00:23:00
|
<Dispenser>
|
I was considering "savage" since initially it's going to search SVG dumps
|
|
2018-02-14 06:12:36
|
<Ivy>
|
Dispenser: Do you mean salvage?
|
|
2018-02-14 06:12:43
|
<Ivy>
|
Though "savage" is kind of cute in a separate way.
|
|
2018-02-14 06:12:59
|
<Ivy>
|
Oh, maybe "savage" because of SVG? Hmm.
|
|
2018-02-14 06:13:06
|
<Ivy>
|
I was thinking of "grep" and "stool" a bit.
|
|
2018-02-14 06:13:26
|
<Ivy>
|
Also, scavenge?
|
|
2018-02-14 06:14:28
|
<Ivy>
|
paddle?
|
|
2018-02-14 06:14:37
|
<Ivy>
|
So you could be up shit's creek, but with a paddle?
|
|
2018-02-14 06:14:37
|
<Ivy>
|
Idk.
|
|
2018-02-14 14:03:07
|
<Hauskatze>
|
do we have tech meeting today?
|
|
2018-02-14 14:06:05
|
<leszek_wmde>
|
Hauskatze: yup, 4 PM UTC
|
|
2018-02-14 14:06:22
|
<Hauskatze>
|
good good
|
|
2018-02-14 14:06:32
|
<Hauskatze>
|
I'm currently a bit stuck on a thing :)
|
|
2018-02-14 16:14:15
|
<andre__>
|
Meouw?
|
|
2018-02-14 16:14:18
|
<Hauskatze>
|
meow
|
|
2018-02-14 16:14:18
|
<Thiemo_WMDE>
|
As usual, you can ask your technical questions in English. Oder auf Deutsch, wem das lieber ist. We don't have a cat here. :-)
|
|
2018-02-14 16:14:19
|
<Hauskatze>
|
Thiemo_WMDE: {{fact}}
|
|
2018-02-14 16:14:19
|
<Hauskatze>
|
ich bin ein Haus katze
|
|
2018-02-14 16:14:19
|
<Hauskatze>
|
tech-hauskatze
|
|
2018-02-14 16:14:19
|
<Thiemo_WMDE>
|
I mean here in the WMDE office.
|
|
2018-02-14 16:14:19
|
<Hauskatze>
|
und ich habe eine Frage
|
|
2018-02-14 16:14:20
|
<Hauskatze>
|
left the topics on the mediawiki page
|
|
2018-02-14 16:14:20
|
<Thiemo_WMDE>
|
Gern.
|
|
2018-02-14 16:14:20
|
<Hauskatze>
|
that's the little bad German I know, for now; hopefully one day I'll get some lessons
|
|
2018-02-14 16:14:21
|
<Thiemo_WMDE>
|
The patch to cleanupSpam.php is brand new. Just give the people a little time (maybe 1 or 2 weeks) to find and review it.
|
|
2018-02-14 16:14:21
|
<Hauskatze>
|
Thiemo_WMDE: will do, thanks :)
|
|
2018-02-14 16:14:22
|
<Thiemo_WMDE>
|
For the other patch https://gerrit.wikimedia.org/r/409705 I can give two hints that might help:
|
|
2018-02-14 16:14:22
|
<Thiemo_WMDE>
|
1.) The patch touches about 300 lines of code. Thats quite big. It would help a lot if you could split it into maybe 3 patches. One only for adding missing copyright headers. One for fixing sniffs. One for extension registration.
|
|
2018-02-14 16:14:22
|
<Thiemo_WMDE>
|
2.) As long as a commit message says [WIP], many people will not even try to look at a patch.
|
|
2018-02-14 16:14:23
|
<Reedy>
|
Also, if it's not WMF deployed extensions etc... People are generally less likely to look at it too
|
|
2018-02-14 16:14:23
|
<Hauskatze>
|
Thiemo_WMDE: okay thanks; I'll try to do smaller changes in the future; I'm just accustomed to do everything at once
|
|
2018-02-14 16:14:23
|
<Hauskatze>
|
Reedy: yeah :(
|
|
2018-02-14 16:14:23
|
<Thiemo_WMDE>
|
I found it critical to upload patches that are small and focus one one single detail. That speeds up review sooo much.
|
|
2018-02-14 16:14:23
|
<Hauskatze>
|
according to mainframe, there's only one little thing there that needs to be fixed, one $wgHooks thingy
|
|
2018-02-14 16:14:23
|
<Thiemo_WMDE>
|
Splitting existing patches is not that hard. Gerrit supports "chains" of patches that depend on each other.
|
|
2018-02-14 16:14:30
|
<Thiemo_WMDE>
|
Yea, and thats even more of a reason to split all the non-controversial details into separate patches that can be merged right now, with no further discussion. :-)
|
|
2018-02-14 16:14:31
|
<Hauskatze>
|
but I don't understand him https://gerrit.wikimedia.org/r/#/c/409705/5/extension.json here and I don't want to ask him again; I find it embarrasing :)
|
|
2018-02-14 16:16:13
|
<Hauskatze>
|
in any case, thanks for the advice, I'll surely take that into account for further patches I upload
|
|
2018-02-14 16:16:27
|
<Hauskatze>
|
the list of extensions lacking conversion is still big :-)
|
|
2018-02-14 16:21:16
|
<Thiemo_WMDE>
|
We left a comment in the patch.
|
|
2018-02-14 16:22:09
|
<HausAFKatze>
|
thanks :)
|
|
2018-02-14 16:23:17
|
<HausAFKatze>
|
Thiemo_WMDE: so 'public static function' etc?
|
|
2018-02-14 16:23:34
|
<Thiemo_WMDE>
|
I think so.
|
|
2018-02-14 16:23:46
|
<HausAFKatze>
|
okay
|
|
2018-02-14 16:23:52
|
<Thiemo_WMDE>
|
Thats just one way to solve it. Did you understood the old code? Took me a while too.
|
|
2018-02-14 16:24:46
|
<HausAFKatze>
|
Yes, somewhat. Took me some time too.
|
|
2018-02-14 16:25:48
|
<Thiemo_WMDE>
|
That array( $example, 'ExampleClass::method' ) with $example being an instance of ExampleClass, this is a callable for a non-static, public method on an instance of that class. You replaced it with a static call. PHP does this, but complains with a warning. This is what the user tried to explain.
|
|
2018-02-14 16:27:14
|
<Pablo_WMDE>
|
http://php.net/callable#example-111 shows the different ways a callable can be expressed. For "Type 4" to work the method should be static.
|
|
2018-02-14 16:37:11
|
<Thiemo_WMDE>
|
37 minutes in. we are still here for an other 23. ;-)
|