Fork me on GitHub

Wikimedia IRC logs browser - #wikimedia-tech

Filter:
Start date
End date

Displaying 143 items:

2019-06-12 06:13:17 <[1997kB]> anyone know if there's already report for https://en.m.wikipedia.org/w/index.php?title=Special:Contributions&limit=50&contribs=user&target=1997kB&namespace=&tagfilter=&start=&end=
2019-06-12 06:13:21 <[1997kB]> ?
2019-06-12 06:22:12 <apergos> works on regular site and not on mobile, it seems?
2019-06-12 06:22:18 <apergos> https://en.wikipedia.org/w/index.php?title=Special:Contributions&limit=50&contribs=user&target=1997kB&namespace=&tagfilter=&start=&end=
2019-06-12 06:22:55 <[1997kB]> yeah only issue on mobile site
2019-06-12 06:24:21 <apergos> haven't heard of anything, but best to double check phabricator before reporting
2019-06-12 14:00:27 <wm-bot> Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @Lucas_WMDE & @tarrow - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
2019-06-12 14:50:11 <wm-bot> Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @Lucas_WMDE & @tarrow - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
2019-06-12 15:03:19 <tarrow> Hello! Lucas_WMDE and I are around for the next hour for this weeks TAIM. It's my first time so no idea if there should be an official intro?
2019-06-12 15:04:31 <andre__> o/
2019-06-12 15:04:38 <tarrow> o/
2019-06-12 15:05:02 <Lucas_WMDE> o/
2019-06-12 15:05:52 <Lucas_WMDE> Well, TAIM stands for Technical Advice IRC Meeting and is an opportunity for anyone to ask questions or seek help on technical issues related to Wikimedia, perhaps that’s worth mentioning :)
2019-06-12 15:06:42 <legoktm> o/
2019-06-12 15:07:27 <apergos> this is a question for addshore, given it's their commit; https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/363284/ in WikiRevision.php it says, for the downloadSource method, deprecated, use UploadImporter::downloadSource but I don't find UploadImporter.php anywhere. Wheeeere is it?
2019-06-12 15:07:40 <apergos> (since no one else is asking yet)
2019-06-12 15:08:43 <tarrow> ooh, I'll take a look
2019-06-12 15:08:53 <Lucas_WMDE> the only other downloadSource() I see in code search (https://codesearch.wmflabs.org/search/?q=function downloadSource) is in ImportableUploadRevisionImporter
2019-06-12 15:09:01 <apergos> yes, and that one has a note that says
2019-06-12 15:09:15 <addshore> *reads*
2019-06-12 15:09:25 <apergos> @deprecated DO NOT CALL ME.
2019-06-12 15:09:29 <Lucas_WMDE> oh, it says DO NOT CALL ME ^^
2019-06-12 15:09:42 <apergos> yeah
2019-06-12 15:09:46 <apergos> so *cough*
2019-06-12 15:10:05 <addshore> That sounds about right
2019-06-12 15:10:36 <apergos> so.... let's suppose someone were motivated to fix up this cruft. what would they call? :-D
2019-06-12 15:11:21 <addshore> Wait ImportableUploadRevisionImporter::download source is deprecated too?
2019-06-12 15:11:31 <apergos> yes
2019-06-12 15:11:31 <addshore> (I'm just on my phone currently so can't look)
2019-06-12 15:11:37 <apergos> that's exactly the thing
2019-06-12 15:11:46 <RF1dle> Hi, I've now responded on the mess of the main page to the request to feedback but when the Tech team changes their mind, Would you be able to tell us? https://www.mediawiki.org/wiki/Topic:V1hxcy1m2icxznle - You should work on communication - I'm sure I'm not the only one who thinks this
2019-06-12 15:12:00 <Lucas_WMDE> so an UploadImporter class exists in earlier patch sets of that change, e. g. https://gerrit.wikimedia.org/r/c/mediawiki/core/+/363284/5
2019-06-12 15:12:10 <Lucas_WMDE> sounds like it was renamed without fully updating the documentation
2019-06-12 15:12:36 <apergos> and that one has decprecated DO NOT CALL in it too
2019-06-12 15:12:51 <apergos> so we have no downloadSource methods to call?
2019-06-12 15:13:41 <Lucas_WMDE> so in PS12 the class was renamed from UploadImporter to ImportableUploadRevisionImporter, apparently
2019-06-12 15:13:44 <Lucas_WMDE> so that is the right class
2019-06-12 15:13:48 <Lucas_WMDE> no idea why its method is also deprecated…
2019-06-12 15:13:51 <legoktm> RF1dle: sorry, I don't unerstand your question?
2019-06-12 15:13:56 <apergos> the right class, except that, yeah the method. sigh
2019-06-12 15:13:56 <addshore> I'm opening my laptop
2019-06-12 15:14:09 <apergos> addshore: I did not mean to nerdswipe you into it. but thank you
2019-06-12 15:14:26 <RF1dle> legoktm: More of a rant at people, see the linked thread on mediawiki.org
2019-06-12 15:14:43 <Lucas_WMDE> apergos: this comment answers your question https://gerrit.wikimedia.org/r/c/mediawiki/core/+/363284/6/includes/import/WikiRevision.php#753
2019-06-12 15:15:00 <legoktm> RF1dle: okay. that's probably not a great use of this meeting then
2019-06-12 15:15:00 <Lucas_WMDE> addshore deliberately introduced and deprecated the method in the same change, apparently
2019-06-12 15:15:07 <Lucas_WMDE> “to avoid having to announce the removal on the mailing list”
2019-06-12 15:15:21 <apergos> someone just point me to the industry-approved method for downloading media in prep for importing
2019-06-12 15:15:27 <RF1dle> legoktm: More seeing if anyone had an answer to the lack of communication skills as well
2019-06-12 15:15:42 <apergos> I can skip right over the comments and all that as long as someone can tell me 'use this!'
2019-06-12 15:16:12 <addshore> Well, if there is a need for that method as is, then I guess use it
2019-06-12 15:16:58 <Lucas_WMDE> it sounds like it was intended to be completely removed in 1.35.0
2019-06-12 15:17:00 <apergos> there's no replacement that will do a get and stash the media file someplace?
2019-06-12 15:17:01 <addshore> Without being able to check in a nice IDE I would guess the only reason it still exists is due to waiting for the right number of versions to pass before removal
2019-06-12 15:17:04 <Lucas_WMDE> or 1.34.0
2019-06-12 15:17:10 <addshore> I'm not sure it has any uses, but I can check that right now
2019-06-12 15:17:14 <apergos> I wonder what importDump is supposed to call because
2019-06-12 15:17:21 <apergos> it uses it right now, well in 1.32 I guess
2019-06-12 15:17:26 <apergos> sec
2019-06-12 15:17:57 <Lucas_WMDE> addshore: no uses outside of core according to code search https://codesearch.wmflabs.org/search/?q=->downloadSource\(&files=\.php%24
2019-06-12 15:18:00 <Lucas_WMDE> grr
2019-06-12 15:18:02 <apergos> in uh 1.33.0-rc.0
2019-06-12 15:18:16 <addshore> Lucas_WMDE: what about in core? :)
2019-06-12 15:18:19 <apergos> it's used because importDump eventually winds up there
2019-06-12 15:18:27 <apergos> and that's core for sure ;-)
2019-06-12 15:18:40 <addshore> but if the method is needed as is, then I'm totally fine with it not being marked as deprecated any more
2019-06-12 15:18:42 <Lucas_WMDE> well core is under our control, right? shouldn’t matter how many uses it has there
2019-06-12 15:18:52 <Lucas_WMDE> (it has two, WikiRevision and ImportableUploadRevisionImporter)
2019-06-12 15:18:58 <apergos> again, I don't care so much about the marking as 'what are we supposed to use instead'
2019-06-12 15:19:09 <apergos> just want to dtrt
2019-06-12 15:19:40 <addshore> Lucas_WMDE: if they are the only 2 uses then the plan would have been to make it private once the stuff is removed from WikiRevision
2019-06-12 15:20:06 <addshore> apergos: importDump doesnt actually call that method directly though?
2019-06-12 15:20:14 <apergos> no, not directly
2019-06-12 15:20:20 <apergos> there's a nice rabbit hole
2019-06-12 15:20:51 <apergos> (the back story is: trying to fix crap on wikitech-static and it's 1.33.0-rc0 and calling this)
2019-06-12 15:20:55 <addshore> Well, the only place it can be called via is ImportableUploadRevisionImporter::import then?
2019-06-12 15:21:27 <apergos> ImportableUploadRevisionImporter->import yeah that's right I think
2019-06-12 15:22:12 <addshore> I'v got to dash, but will read up what happens after
2019-06-12 15:22:22 <Lucas_WMDE> apergos: where do you want to call the method (or a replacement)?
2019-06-12 15:22:32 <apergos> $source = $this->downloadSource( $importableRevision );
2019-06-12 15:22:35 <apergos> yeah there it is
2019-06-12 15:22:49 <apergos> well, i want to call a replacement right there I guess
2019-06-12 15:22:56 <apergos> if we shouldn't use that
2019-06-12 15:23:46 <Lucas_WMDE> I think the deprecation is just for it being public
2019-06-12 15:23:48 <apergos> that's in master btw so still like that
2019-06-12 15:23:53 <Lucas_WMDE> so the call inside ImportableUploadRevisionImporter would be fine
2019-06-12 15:24:14 <Lucas_WMDE> no need to replace that with anything
2019-06-12 15:24:42 <apergos> ok, so it's worth debugging the existing codepath with that in it
2019-06-12 15:24:48 <apergos> thanks, appreciate the time!
2019-06-12 15:25:11 <apergos> (updating the comments would probably be good as an aside)
2019-06-12 15:25:19 <Lucas_WMDE> yeah, definitely
2019-06-12 15:25:30 <tarrow> I think that's how I read it too but it could indeed be clearer :)
2019-06-12 15:28:33 <apergos> ty!
2019-06-12 15:33:20 <Lucas_WMDE> https://gerrit.wikimedia.org/r/516641
2019-06-12 15:33:44 <Lucas_WMDE> does anyone else have questions?
2019-06-12 15:47:24 <Lucas_WMDE> no other questions?
2019-06-12 16:00:15 <Lucas_WMDE> alright, that concludes this week’s Technical Advice IRC Meeting! thanks everyone for participating :)
2019-06-12 16:00:37 <tarrow> Thanks! :)
2019-06-12 16:00:40 <Lucas_WMDE> don’t forget you can also ask such questions at any time over on the Wikimedia Developer Support forum! https://discourse-mediawiki.wmflabs.org/
2019-06-12 16:00:43 <legoktm> Lucas_WMDE: just a late thank you for making progress on the extension.jsonification of Wikibase :)
2019-06-12 16:01:04 <Lucas_WMDE> legoktm: you’re welcome! I hope it continues soon :)
2019-06-12 16:01:53 <apergos> I was feeling guilty about using time for a question... but maybe that's a mistake :-)
2019-06-12 16:04:50 <Lucas_WMDE> well we didn’t exactly run out of time for other questions :P
2019-06-12 16:06:58 <apergos> :-)
2019-06-12 16:07:35 <tarrow> I think having some activity is better than silence by a long way
2019-06-12 16:14:52 <bawolff> Lucas_WMDE: So this channel is still marked registered users only. I wonder if that's lessening the number of new people coming to the questions meeting
2019-06-12 16:15:06 <jc86035> is anyone here?
2019-06-12 16:16:09 <bawolff> jc86035: How can we help you?
2019-06-12 16:16:40 <jc86035> I'm mainly here because a discussion was mentioned in the enwiki Discord server, I don't have much to say right now
2019-06-12 16:17:03 <apergos> a technical advice discussion?
2019-06-12 16:17:05 <Lucas_WMDE> bawolff: hm, okay
2019-06-12 16:17:29 <jc86035> it was something about the talk pages consultation
2019-06-12 16:17:45 <jc86035> their qualtrics survey has been delayed by about three weeks
2019-06-12 16:18:14 <addshore> Lucas_WMDE: apergos I'll try to remember to update the docs in the coming days, but won't get to it for a while
2019-06-12 16:18:20 <bawolff> Lucas_WMDE: We were having spam problems a while back, maybe its died down enough that we could lift the restriction. I'm not sure
2019-06-12 16:18:22 <RF1dle> Jc68035: hi! It's RhinosF1 from Discord.
2019-06-12 16:18:30 <tarrow> addshore: I think Lucas did it
2019-06-12 16:18:30 <Lucas_WMDE> addshore: I already uploaded a change to do it
2019-06-12 16:18:32 <apergos> addshore: there's a patchset already in gerrit thanks to
2019-06-12 16:18:33 <RF1dle> Jc86035: ^
2019-06-12 16:18:34 <apergos> Lucas!
2019-06-12 16:18:36 <jc86035> RF1dle: hi
2019-06-12 16:19:18 <RF1dle> Jc86035: Trizek has been asking me questions over PM. I think they're still finding out if Qualtrics is definitely off.
2019-06-12 16:19:21 <addshore> Hehe
2019-06-12 16:19:58 <jc86035> RF1dle: got it
2019-06-12 16:21:13 <Trizek> I just have the confirmation that the survey for talk pages consultation will not happen. The different pages will be updated soon.
2019-06-12 16:22:30 <Trizek> The issue is that is has been very difficult to design that survey. And since the number of replies from newcomers is more important than expected across languages, a survey was not as needed as we thought.
2019-06-12 16:22:57 <RF1dle> jc86035: ^
2019-06-12 16:23:11 <jc86035> Trizek: (Mostly) unrelated question, is there a reason the banner now links to the phase 1 report instead of the landing page?
2019-06-12 16:23:29 <jc86035> it seems to have caused a massive drop in page views to the local consultations, suggesting that no one is bothering to scroll down
2019-06-12 16:26:48 <Trizek> jc86035: To be transparent, I was against the idea of changing the link from the landing page to the report.
2019-06-12 16:27:37 <Trizek> Since it was totally inefficient as predicted, since a few hours, I've set direct links to local pages for every language. For English, it goes to the report, because it is the most central place we have (we have consultation in English for Wikipedia, Wikisource and Wikidata, so no common place to link to).
2019-06-12 16:29:28 <jc86035> [correction – it only caused a drop for enwiki, where there was a page view spike for about a week, whereas on some of the other consultations, like zhwiki, there was no spike to begin with]
2019-06-12 16:30:24 <jc86035> okay, that makes sense. although maybe an "I don't want to read all of this" button might perhaps be helpful?
2019-06-12 16:30:26 <Trizek> It caused a drop on French and German IIRC.
2019-06-12 16:30:42 <Trizek> Can you suggest it on the talk page? :)
2019-06-12 16:32:19 <jc86035> Trizek: done.
2019-06-12 16:33:23 <Trizek> Thank you.
2019-06-12 16:35:00 <jc86035> Trizek: Furthermore (sorry to bother you), is it still planned for the consultation to end on the 15th with summaries due that day? As yet there is nowhere to post discussion summaries, and some of the discussions still seem to be a little active.
2019-06-12 16:35:19 <jc86035> I'm personally a little worried about the amount of text that has to be summarized, to be honest
2019-06-12 16:36:18 <Trizek> We are worried too.
2019-06-12 16:38:57 <Trizek> Freeze the feedback is still scheduled for June 15, jc86035.
2019-06-12 16:39:26 <Trizek> In the meantime, we will have finished to think about advice or a process to proceed all the feedback.

This page is generated from SQL logs, you can also download static txt files from here