|
2018-07-18 03:54:37
|
<Krinkle>
|
testing bug
|
|
2018-07-18 12:40:27
|
<Gopa_>
|
Hello I am back again and want to start contribute to "RevisionSlider" can I get any preffered tasks to start?
|
|
2018-07-18 13:08:19
|
<legoktm>
|
Gopa_: hi! I think addshore has some
|
|
2018-07-18 13:09:28
|
<addshore>
|
Gopa_: HI!
|
|
2018-07-18 13:09:29
|
<addshore>
|
yes :)
|
|
2018-07-18 13:17:46
|
<addshore>
|
Gopa_: where are you? (:
|
|
2018-07-18 13:53:15
|
<Perhelion>
|
Hello
|
|
2018-07-18 14:00:21
|
<Perhelion>
|
I wonder strongly about https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/412822/
|
|
2018-07-18 14:01:52
|
<Perhelion>
|
the recommendation is now `require( 'mediawiki.String' ).byteLength`
|
|
2018-07-18 14:03:13
|
<Perhelion>
|
but I found no documentation about the global require() function (except for Lua and PHP)
|
|
2018-07-18 14:04:46
|
<CFisch_WMDE>
|
Hi Gopa_ ! :-)
|
|
2018-07-18 14:08:17
|
<Perhelion>
|
seems a shortcut for mw.loader.require
|
|
2018-07-18 14:31:11
|
<Nudin_WMDE>
|
<Nudin_WMDE> Technical Advice IRC meeting *Wikimania Special* starting in 30 minutes in channel #wikimedia-tech, hosts: @addshore & @CFisch_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2018-07-18 14:31:44
|
<addshore>
|
:D
|
|
2018-07-18 14:31:55
|
<Nudin_WMDE>
|
:)
|
|
2018-07-18 14:32:12
|
<CFisch_WMDE>
|
\o/
|
|
2018-07-18 14:33:04
|
<Nudin_WMDE>
|
Sadly it seems freenode has some technical issues right now :/ I hope noone is excluded from todays TAIM because of that�
|
|
2018-07-18 14:52:24
|
<addshore>
|
Silly freenode
|
|
2018-07-18 14:53:36
|
<dbs>
|
Are the people at wikimania running into a Freenode rate limit (first phab, then freenode)?
|
|
2018-07-18 14:54:09
|
<CFisch_WMDE>
|
Good question...
|
|
2018-07-18 14:55:49
|
<addshore>
|
Oooh, maybe not!
|
|
2018-07-18 14:55:59
|
<addshore>
|
Or maybe, I haven't seen anyone complain yet
|
|
2018-07-18 15:00:27
|
<CFisch_WMDE>
|
\o/
|
|
2018-07-18 15:00:39
|
<CFisch_WMDE>
|
It's time!
|
|
2018-07-18 15:01:12
|
<CFisch_WMDE>
|
Welcome to the Technical Advice IRC Meeting!
|
|
2018-07-18 15:01:41
|
<Gopa_>
|
CFisch_WMDE: Hello !
|
|
2018-07-18 15:01:57
|
<CFisch_WMDE>
|
Wikimania Special Edition!
|
|
2018-07-18 15:02:19
|
<CFisch_WMDE>
|
Live from Cape Town
|
|
2018-07-18 15:02:21
|
<CFisch_WMDE>
|
and Berlin
|
|
2018-07-18 15:02:22
|
<Gopa_>
|
addshore: Sorry for the Inconvenience and late reply, I went out for food.
|
|
2018-07-18 15:02:50
|
<CFisch_WMDE>
|
Gopa_: no problem :-)
|
|
2018-07-18 15:03:06
|
<Gopa_>
|
CFisch_WMDE: Thanks
|
|
2018-07-18 15:03:28
|
<addshore>
|
o/
|
|
2018-07-18 15:03:53
|
<Gopa_>
|
addshore: More over I am from India.
|
|
2018-07-18 15:04:49
|
<mainframe98>
|
Yay! Shall I start with a question? I've been wondering how you should hide html headers (h2 etc) intended for screenreaders. Looking at Vector, there are three ways it appears to be done
|
|
2018-07-18 15:05:18
|
<CFisch_WMDE>
|
Hi mainframe98
|
|
2018-07-18 15:05:25
|
<addshore>
|
Hi mainframe98 !
|
|
2018-07-18 15:05:35
|
<mainframe98>
|
Less mixin that turns the header in 1px; CSS with display:none; or CSS with top: -9999px;
|
|
2018-07-18 15:05:50
|
<Niridya>
|
Hello ;)
|
|
2018-07-18 15:05:51
|
<Gopa_>
|
addshore: Can I get some tasks to work on RevisionSlider that would guide me in understanding the code base much better.
|
|
2018-07-18 15:05:56
|
<addshore>
|
Hi Niridya
|
|
2018-07-18 15:06:20
|
<Niridya>
|
I got one question now : why isn't the User info template not translated on my meta page ? https://meta.wikimedia.org/wiki/User:Niridya
|
|
2018-07-18 15:06:37
|
<addshore>
|
Gopa_: so the starting place would be https://phabricator.wikimedia.org/T199877
|
|
2018-07-18 15:06:47
|
<CFisch_WMDE>
|
mainframe98: so your question is, what method to pick?
|
|
2018-07-18 15:06:55
|
<addshore>
|
And there are 3 smallish tickets located as subtickets
|
|
2018-07-18 15:07:18
|
<Gopa_>
|
addshore: Thanks ;) I will look over it.
|
|
2018-07-18 15:07:22
|
<mainframe98>
|
CFisch_WMDE: Yes, that is correct.
|
|
2018-07-18 15:07:29
|
<addshore>
|
Let us know which takes your fancy
|
|
2018-07-18 15:07:58
|
<CFisch_WMDE>
|
mainframe98: so I would assume that display none will be ignored by screenreaders
|
|
2018-07-18 15:08:21
|
<Gopa_>
|
addshore: >>Let us know which takes your fancy Me?
|
|
2018-07-18 15:08:22
|
<CFisch_WMDE>
|
so if you still want screenreaders to work
|
|
2018-07-18 15:08:28
|
<addshore>
|
Gopa_: yes!
|
|
2018-07-18 15:08:30
|
<CFisch_WMDE>
|
I would go for the 1px method
|
|
2018-07-18 15:09:52
|
<dbs>
|
Are any wikibase + RDF people here to tackle the curious case of the canonicalUriProperty setting not resulting in any changes to RDF output (at least on my instance, built using addshore's wonderful docker images)
|
|
2018-07-18 15:10:45
|
<addshore>
|
Niridya: it looks good to me when viewing it on fr, https://meta.wikimedia.org/wiki/User:Niridya?uselang=fr
|
|
2018-07-18 15:10:59
|
<CFisch_WMDE>
|
dbs: Lucas_WMDE might be your guy here :-)
|
|
2018-07-18 15:11:13
|
<addshore>
|
Hi dbs, so let me have a dig around with you
|
|
2018-07-18 15:11:15
|
<Lucas_WMDE>
|
well, I was going to mention that setting
|
|
2018-07-18 15:11:22
|
<Lucas_WMDE>
|
but it seems you already found that?
|
|
2018-07-18 15:11:23
|
<addshore>
|
aaah, Lucas_WMDE is also here!
|
|
2018-07-18 15:11:40
|
<addshore>
|
will leave it to Lucas_WMDE :)
|
|
2018-07-18 15:11:42
|
<Lucas_WMDE>
|
that wasn’t clear to me from the text on the TAIM page
|
|
2018-07-18 15:11:45
|
<dbs>
|
yes - curiously, formatterUrlProperty is working as expected in the HTML
|
|
2018-07-18 15:11:47
|
<Gopa_>
|
addshore: I am very excited to work on MediaWiki project's in between I saw this project and was quite interesting to me and working in a team, together for two months, Interacting with new developers was really amazing.
|
|
2018-07-18 15:11:57
|
<mainframe98>
|
CFisch_WMDE: Thank you. That should be easy. I'm curious though, when looking at Vector's personalMenu.Less, it does use display:none for specific screenreader headers.
|
|
2018-07-18 15:12:14
|
<Niridya>
|
addshore some parts are working (the sentences for example) but the template itseilf (the About me title for example) remain in English
|
|
2018-07-18 15:12:25
|
<dbs>
|
Lucas_WMDE: well I've updated that topic a few times today as I made progress; this is something I've been trying to get straight for 3 or 4 days now
|
|
2018-07-18 15:12:25
|
<mainframe98>
|
CFisch_WMDE: I'll just stick to the 1px method and see where I'll end up.
|
|
2018-07-18 15:12:46
|
<CFisch_WMDE>
|
mainframe98: Hmm interesting, - Volker_E__ do you have a note on that?
|
|
2018-07-18 15:12:55
|
<Lucas_WMDE>
|
mainframe98: https://developer.mozilla.org/en-US/docs/Web/CSS/display#display_none says display: none hides content from accessibility tools
|
|
2018-07-18 15:13:19
|
<addshore>
|
hmmmm Niridya I'll have a look at the template
|
|
2018-07-18 15:13:43
|
<Niridya>
|
thank you !
|
|
2018-07-18 15:14:02
|
<mainframe98>
|
Lucas_WMDE: That's exactly why I found it so strange Vector uses it in such way.
|
|
2018-07-18 15:14:39
|
<Lucas_WMDE>
|
dbs: how are you checking the RDF representation? are you looking directly at Special:EntityData?
|
|
2018-07-18 15:15:50
|
<addshore>
|
Niridya: so in Template:User_info I see {{ {{TNTN|Template:User info| uselang = {{{uselang|{{CURRENTCONTENTLANGUAGE}}}}} }}
|
|
2018-07-18 15:16:14
|
<dbs>
|
Lucas_WMDE: using curl to request text/turtle representation at entity/Q#
|
|
2018-07-18 15:16:22
|
<Niridya>
|
addshore and is it good ? (i know how work templates but not well for translations)
|
|
2018-07-18 15:16:33
|
<addshore>
|
is digging some more
|
|
2018-07-18 15:16:41
|
<dbs>
|
Lucas_WMDE: 'curl -LH "Accept: text/turtle" http://localhost:8181/entity/Q16'; specifically
|
|
2018-07-18 15:16:46
|
<Lucas_WMDE>
|
dbs: can you perhaps add something like ?breakCache=387102459870 just to make sure it’s not caching anything?
|
|
2018-07-18 15:17:19
|
<CFisch_WMDE>
|
mainframe98: So Volker_E__ says, display: none hides it from the screenreaders
|
|
2018-07-18 15:17:25
|
<CFisch_WMDE>
|
but there is a mixin
|
|
2018-07-18 15:17:29
|
<CFisch_WMDE>
|
in the mediawiki mixins
|
|
2018-07-18 15:17:40
|
<CFisch_WMDE>
|
called screenreader text
|
|
2018-07-18 15:17:55
|
<CFisch_WMDE>
|
that can be used for elements that should be visible to screenreaders only
|
|
2018-07-18 15:18:07
|
<CFisch_WMDE>
|
but hidden for everything else
|
|
2018-07-18 15:19:09
|
<dbs>
|
Lucas_WMDE: okay - tried appending the cache-busting GET param but it made no difference. good thought though!
|
|
2018-07-18 15:19:22
|
<Lucas_WMDE>
|
okay, then I’m not sure why this wouldn’t work
|
|
2018-07-18 15:19:37
|
<Lucas_WMDE>
|
unless perhaps this feature simply wasn’t available in whatever version Docker uses?
|
|
2018-07-18 15:19:52
|
<Lucas_WMDE>
|
checks
|
|
2018-07-18 15:20:19
|
<mainframe98>
|
CFisch_WMDE: Excellent. Thank you. I'll stick to mediawiki mixins
|
|
2018-07-18 15:20:50
|
<Gopa_>
|
addshore: I hope you read the above message.
|
|
2018-07-18 15:21:20
|
<Lucas_WMDE>
|
dbs: hm, that feature should be available in 1_30
|
|
2018-07-18 15:21:38
|
<addshore>
|
Gopa_: sorry, missed it but just saw it :)
|
|
2018-07-18 15:21:49
|
<dbs>
|
Lucas_WMDE: I can try rebuilding the images from scratch. This is a pretty important use case for libraries who are getting on-board with the idea of maintaining their own linked data stores so happy to work through as much as possible
|
|
2018-07-18 15:22:07
|
<addshore>
|
Gopa_: I hear that you already signed up for the season of RevisionSlider too
|
|
2018-07-18 15:22:09
|
<Gopa_>
|
addshore: No worries :)
|
|
2018-07-18 15:22:50
|
<Lucas_WMDE>
|
dbs: hm, looking at the implementation, it seems you might need to rebuild the property info after configuring that setting?
|
|
2018-07-18 15:22:54
|
<Lucas_WMDE>
|
I’ll check how that’s done
|
|
2018-07-18 15:23:07
|
<addshore>
|
Niridya: I did a test @ https://meta.wikimedia.org/wiki/User:Addshore/sandbox?uselang=de and the code in the template doesn't appear to be doing what I would expect
|
|
2018-07-18 15:23:21
|
<dbs>
|
Lucas_WMDE: cool, thanks
|
|
2018-07-18 15:23:55
|
<Lucas_WMDE>
|
dbs: I think you need this https://tools.wmflabs.org/sal/log/AV9Y7xNAF4fsM4DBdUqD
|
|
2018-07-18 15:24:03
|
<Niridya>
|
addshore and what did you expected to appear ?
|
|
2018-07-18 15:24:09
|
<Lucas_WMDE>
|
php extensions/Wikidata/extensions/Wikibase/repo/maintenance/rebuildPropertyInfo.php --rebuild-all --force
|
|
2018-07-18 15:24:17
|
<Gopa_>
|
addshore: Yes I am talking about the RevisionSlider project, I kept a message in that token.
|
|
2018-07-18 15:24:28
|
<addshore>
|
So Niridya with uselang=de in the URL i was expecting to see Template:User info/de
|
|
2018-07-18 15:24:28
|
<Lucas_WMDE>
|
hm, probably without the wikidata build in there
|
|
2018-07-18 15:24:34
|
<Lucas_WMDE>
|
i. e. php extensions/Wikibase/repo/maintenance/rebuildPropertyInfo.php --rebuild-all --force
|
|
2018-07-18 15:25:08
|
<Niridya>
|
addshore i was just reading this in the template's documentation^^
|
|
2018-07-18 15:25:17
|
<Lucas_WMDE>
|
by the way, I do have a request for technical advice of my own :)
|
|
2018-07-18 15:25:23
|
<Niridya>
|
addshore do you know from where does this bug come from ?
|
|
2018-07-18 15:25:24
|
<Lucas_WMDE>
|
I would be very happy if anyone could take a look at https://discourse-mediawiki.wmflabs.org/t/registering-an-optional-service-in-mediawikiservices/579
|
|
2018-07-18 15:25:25
|
<addshore>
|
Niridya: yes, something sounds odd
|
|
2018-07-18 15:25:30
|
<addshore>
|
Niridya: not yet
|
|
2018-07-18 15:25:36
|
<CFisch_WMDE>
|
Gopa_: So for the team project we want to start beginning of August there will be a detailed introduction at the Kick-Off
|
|
2018-07-18 15:25:59
|
<Niridya>
|
addshore okey ;) (you think you will find before the end of the IRC meeting ?)
|
|
2018-07-18 15:26:05
|
<addshore>
|
Niridya: maybe ;)
|
|
2018-07-18 15:26:09
|
<Gopa_>
|
CFisch_WMDE: yes I read about it.
|
|
2018-07-18 15:26:09
|
<Niridya>
|
;)
|
|
2018-07-18 15:26:16
|
<Niridya>
|
i let you search ;)
|
|
2018-07-18 15:26:24
|
<CFisch_WMDE>
|
Gopa_: But for now you could also look at the taskboard addshore linked earlier and see if something seems doable for you
|
|
2018-07-18 15:26:38
|
<Gopa_>
|
CFisch_WMDE: Ok sure
|
|
2018-07-18 15:26:55
|
<Gopa_>
|
CFisch_WMDE: Thanks I will start working on that.
|
|
2018-07-18 15:27:36
|
<CFisch_WMDE>
|
It's pretty good already, if it's working for you locally and then you can start playing around a bit to see how it's all connected
|
|
2018-07-18 15:28:33
|
<mainframe98_>
|
Alright, now that the internet connection has been restored, I have another question: If I wanted to access something from the database during extension registration, how should I do that?
|
|
2018-07-18 15:28:47
|
<CFisch_WMDE>
|
mainframe98_: wb
|
|
2018-07-18 15:28:48
|
<dbs>
|
Lucas_WMDE: sounded promising but didn't see any change in the results, alas!
|
|
2018-07-18 15:28:49
|
<Volker_E__>
|
CFisch_WMDE: mainframe98: That's the mentioned mixin https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.less/mediawiki.mixins.less#L192
|
|
2018-07-18 15:28:59
|
<CFisch_WMDE>
|
mainframe98_: what do you need exactly?
|
|
2018-07-18 15:29:08
|
<Gopa_>
|
CFisch_WMDE: yes I already cloned, Installed locally. Now I am doing a case study over the code base.
|
|
2018-07-18 15:29:11
|
<CFisch_WMDE>
|
and why do you need it before the extension registration
|
|
2018-07-18 15:29:37
|
<mainframe98_>
|
Currently, trying to call wfGetDB() in the extension registration fails because the chronology protection isn't set yet. I need it to retrieve settings from the database, which are needed before the service locator is reset
|
|
2018-07-18 15:30:10
|
<mainframe98_>
|
Certain config in setup.php depends on certain globals, and I need to have the configuration from the database before that point (at the extension registration)
|
|
2018-07-18 15:30:12
|
<addshore>
|
mainframe98_: where in extension registration? in a hook or?
|
|
2018-07-18 15:30:32
|
<mainframe98_>
|
addshore: in the extension registration callback hook.
|
|
2018-07-18 15:30:41
|
<addshore>
|
legoktm: ^^
|
|
2018-07-18 15:30:55
|
<dbs>
|
Lucas_WMDE: I think I'm going to try a fresh docker image to ensure there's nothing I've done previously contaminating the build
|
|
2018-07-18 15:31:53
|
<dbs>
|
Lucas_WMDE: short-term, I'm hoping to convince a research group to consider wikibase for a LOD graph store but if I can't get RDF mappings working, that won't go too far--heh
|
|
2018-07-18 15:32:10
|
<CFisch_WMDE>
|
mainframe98_: is the code available somewhere already?
|
|
2018-07-18 15:32:12
|
<mainframe98_>
|
The registry fires at Setup.php#124, which is before the global setup process at line 144 and later. If I just used the service locator, it would be too late, since that occurs at Line 614
|
|
2018-07-18 15:32:17
|
<Lucas_WMDE>
|
dbs: can you perhaps look at the property info in the database?
|
|
2018-07-18 15:32:22
|
<Lucas_WMDE>
|
to see if it was imported or not
|
|
2018-07-18 15:32:30
|
<Lucas_WMDE>
|
(the same as what you previously had hand-edited, I assume)
|
|
2018-07-18 15:33:19
|
<addshore>
|
Niridya: I tried to demonstrate the issue a bit more at https://meta.wikimedia.org/wiki/User:Addshore/sandbox
|
|
2018-07-18 15:33:28
|
<mainframe98_>
|
CFisch_WMDE: Not yet. I had planned to release it after I would get a Proof of concept, but this is blocking that. I can probably create a gist though.
|
|
2018-07-18 15:34:59
|
<addshore>
|
Niridya: I think you might actually have to mark your page as a translatable page instead of using the langswitch
|
|
2018-07-18 15:35:22
|
<dbs>
|
Lucas_WMDE: sure thing - property_info.pi_info has {"type":"external-id","formatterURL":"https:\/\/example.org\/vocab-url\/$1","canonicalURI":"https:\/\/example.org\/vocab\/$1"} for the property in question
|
|
2018-07-18 15:35:45
|
<addshore>
|
Niridya: looking at the docs of https://www.mediawiki.org/wiki/Template:CURRENTCONTENTLANGUAGE which are used in that user info template
|
|
2018-07-18 15:36:02
|
<addshore>
|
"This template returns the "content language" of the current page; more precisely it checks if the current title ends with a language code, and if it is the case it returns this language code, else {{CONTENTLANGUAGE}} (the default content language; on this wiki: "en" for English)."
|
|
2018-07-18 15:37:58
|
<Gopa_>
|
CFisch_WMDE: I hope you already read my mail about the RevisionSlider Project.
|
|
2018-07-18 15:37:59
|
<dbs>
|
Lucas_WMDE: and the property that serves as the target for canonicalUriProperty setting is just {"type":"string"} (as expected I think)
|
|
2018-07-18 15:38:58
|
<Lucas_WMDE>
|
dbs: hm, okay, that looks good at least
|
|
2018-07-18 15:39:04
|
<addshore>
|
Niridya: yup, I think thats it!
|
|
2018-07-18 15:39:10
|
<CFisch_WMDE>
|
Gopa_: Yeah I was in the process of responding already but got distracted by a lot of things today ^^'
|
|
2018-07-18 15:39:49
|
<Gopa_>
|
CFisch_WMDE: It's ok ;)
|
|
2018-07-18 15:40:43
|
<tgr>
|
Lucas_WMDE: re: optional service registration, one common method is to have a null service which implements the same interface but doesn't do anything
|
|
2018-07-18 15:41:21
|
<bawolff>
|
I have some patches i was wondering if i could get code review on ( https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CategoryTree/+/444019/ https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/444757/ )
|
|
2018-07-18 15:41:42
|
<Lucas_WMDE>
|
dbs: wait, I’m not sure if *export* of those canonical thingies *to RDF* is also in 1.30… lemme check again
|
|
2018-07-18 15:41:52
|
<addshore>
|
bawolff: =o
|
|
2018-07-18 15:41:53
|
<bawolff>
|
is not sure if that is an appropiate thing to ask for at this meeting
|
|
2018-07-18 15:43:06
|
<addshore>
|
bawolff: did you test the CategoryTree one?
|
|
2018-07-18 15:43:14
|
<CFisch_WMDE>
|
bawolff: normally I would say it's not ....but depending on the size of the patch and if your asking as a volunteer it might be a yes ^^
|
|
2018-07-18 15:43:41
|
<CFisch_WMDE>
|
bawolff: and of cause you have to ask nicely!
|
|
2018-07-18 15:44:11
|
<Lucas_WMDE>
|
dbs: nope :(
|
|
2018-07-18 15:44:23
|
<Lucas_WMDE>
|
commit ad332804b1fea069043d14d0195f6fe2ed5a6f4b is apparently only in REL1_31, not in REL1_30
|
|
2018-07-18 15:44:41
|
<addshore>
|
Lucas_WMDE: we need to backport something for Wikibase? :D
|
|
2018-07-18 15:45:02
|
<Lucas_WMDE>
|
addshore: or create a 1_31 Docker container?
|
|
2018-07-18 15:45:22
|
<bawolff>
|
addshore: umm i think i did. Its been a while since i submitted it
|
|
2018-07-18 15:45:50
|
<addshore>
|
Niridya: I'm going to get my user page translated and then I'll be able to provide you with an example to copy :)
|
|
2018-07-18 15:46:05
|
<addshore>
|
Lucas_WMDE: there is a ticket for that!
|
|
2018-07-18 15:46:17
|
<Lucas_WMDE>
|
tgr: that means a lot of callers would have to check “instance of DummyWhatever” instead of “=== null” :/
|
|
2018-07-18 15:46:23
|
<dbs>
|
Lucas_WMDE: ah that's fantastic to know, at least
|
|
2018-07-18 15:46:35
|
<addshore>
|
Lucas_WMDE: https://phabricator.wikimedia.org/T197212
|
|
2018-07-18 15:46:38
|
<bawolff>
|
CFisch_WMDE: feel free to tell me to go away :) Sometimes it can be difficult to find people for certain areas of the code base
|
|
2018-07-18 15:46:51
|
<Niridya>
|
addshore thank you a lot ! (and sorry if i didn't answered quickly)
|
|
2018-07-18 15:46:55
|
<CFisch_WMDE>
|
bawolff: No worries ;-)
|
|
2018-07-18 15:46:59
|
<tgr>
|
why do callers need to know how the service is implemented?
|
|
2018-07-18 15:46:59
|
<addshore>
|
Niridya: np :)
|
|
2018-07-18 15:47:31
|
<bawolff>
|
the categorytree one is definitely work related. I just have no idea who is maintaining category tree now a days
|
|
2018-07-18 15:47:41
|
<Lucas_WMDE>
|
they don’t need to know how it’s implemented, they need to know if it’s available or not
|
|
2018-07-18 15:47:47
|
<Lucas_WMDE>
|
and act differently if it’s not available
|
|
2018-07-18 15:47:48
|
<dbs>
|
is now subscribed to https://phabricator.wikimedia.org/T197212
|
|
2018-07-18 15:48:05
|
<Lucas_WMDE>
|
in ways that a simple dummy implementation couldn’t provide
|
|
2018-07-18 15:48:12
|
<Lucas_WMDE>
|
at least not without a lot of refactoring
|
|
2018-07-18 15:48:14
|
<CFisch_WMDE>
|
bawolff: Maybe we should invent a we review each others patches IRC session!
|
|
2018-07-18 15:48:56
|
<bawolff>
|
Yeah, i think that would be cool :)
|
|
2018-07-18 15:49:17
|
<addshore>
|
Niridya: infact, we are just going to do it on your page! :D (but the translated page stuff will only work on meta, not through the global user page magic)
|
|
2018-07-18 15:49:55
|
<Niridya>
|
Only on meta ? That's strange because LangSwitch works cross-wiki
|
|
2018-07-18 15:50:05
|
<addshore>
|
CFisch_WMDE: bawolff I think maybe that was discussed at one point, or maybe there is already such a time
|
|
2018-07-18 15:50:08
|
<tgr>
|
wasn't the code review hour canceled on the basis of merging it into this event?
|
|
2018-07-18 15:50:25
|
<addshore>
|
tgr: ^^ that might be what I was thinking of!
|
|
2018-07-18 15:50:33
|
<bawolff>
|
It was more cancelled as a failure
|
|
2018-07-18 15:50:40
|
<addshore>
|
=[
|
|
2018-07-18 15:52:18
|
<dbs>
|
Lucas_WMDE: oh wow, that commit was in 2016! Thanks for tracking that down
|
|
2018-07-18 15:52:55
|
<addshore>
|
Niridya: so shall we try to mark your page as translatable? :)
|
|
2018-07-18 15:52:57
|
<addshore>
|
or not bother
|
|
2018-07-18 15:53:11
|
<bawolff>
|
my biased opinion what happened: 1) most of the people involved did not have +2. 2) it was on an obscure irc channel and not well advertised 3) people could sign up patches beforehand...which turned into people other than the code author signing up these ten thousand line rewrite everything butrotted patches because they wanted to see cool feature X it promised
|
|
2018-07-18 15:53:55
|
<addshore>
|
7 mins left!
|
|
2018-07-18 15:53:58
|
<bawolff>
|
I dont think irc code review hour can really work for anything but small patches
|
|
2018-07-18 15:54:15
|
<Niridya>
|
addshore you can't only translate the template (if you can he will be translated on others users pages) ?
|
|
2018-07-18 15:54:21
|
<CFisch_WMDE>
|
bawolff: I agree
|
|
2018-07-18 15:54:40
|
<CFisch_WMDE>
|
that should be a basic rule for such a session
|
|
2018-07-18 15:55:01
|
<addshore>
|
well, the template is already translated, but in order to take advantage of that translated table it looks as if you have to also translate the page the template is used on
|
|
2018-07-18 15:55:17
|
<Lucas_WMDE>
|
dbs: it was only merged only a year later
|
|
2018-07-18 15:55:22
|
<CFisch_WMDE>
|
for the +2 problem one could orchestrate - like here - that you have people with these rights present, that also feel responsible
|
|
2018-07-18 15:55:22
|
<Lucas_WMDE>
|
that confused me at first as well :D
|
|
2018-07-18 15:55:25
|
<addshore>
|
CFisch_WMDE: bawolff strict patch requirements, must be mergable, no -1s, less than 100 lines? etc :)
|
|
2018-07-18 15:55:31
|
<Lucas_WMDE>
|
“surely a 2016 commit must be in 1.30?”
|
|
2018-07-18 15:55:36
|
<bawolff>
|
s/butrotted/bitrotted (thats a funny typo)
|
|
2018-07-18 15:55:45
|
<addshore>
|
5 mins left!
|
|
2018-07-18 15:55:50
|
<Niridya>
|
addshore It's quite strange, there are lots of more complicated templates where the translation work (for example Igen on Commons)
|
|
2018-07-18 15:56:00
|
<Niridya>
|
addshore but you can try if you want ;)
|
|
2018-07-18 15:56:15
|
<tgr>
|
Lucas_WMDE: the service could always have an isAvailable() or supports(...) flag. It's ugly but the nice solution would probably be to refactor the code so it does not need to know what the service does or if it does anything at all
|
|
2018-07-18 15:56:17
|
<bawolff>
|
addshore: i would add to that must have been rebased in last 2 weeks
|
|
2018-07-18 15:56:31
|
<addshore>
|
bawolff: yes :) or rebased during the week of the meeting
|
|
2018-07-18 15:56:32
|
<quiddity>
|
Niridya, have you seen this page? https://meta.wikimedia.org/wiki/Global_user_pages#Translation
|
|
2018-07-18 15:56:53
|
<bawolff>
|
everything translation related is a mess
|
|
2018-07-18 15:57:01
|
<addshore>
|
bawolff: basically CI and gerrit both have to say yes :)
|
|
2018-07-18 15:57:11
|
<addshore>
|
3 mins left!
|
|
2018-07-18 15:57:41
|
<Niridya>
|
addshore no I didn't read this page, it's interessant
|
|
2018-07-18 15:58:15
|
<tgr>
|
returning null for a service is problematic inasmuch as it forces all calling code with the service being null (so if your class stores the service in the constructor and calls it a hundred times all hundred places need a null check now)
|
|
2018-07-18 15:58:50
|
<quiddity>
|
Niridya, I think that's the only option for translation of GlobalUserPage. Because it only pulls the root page, not the subpages.
|
|
2018-07-18 15:59:20
|
<Isarra>
|
BUTTROTTED.
|
|
2018-07-18 15:59:32
|
<Niridya>
|
i will try in a short time, but can you locally translate Template:User info ?
|
|
2018-07-18 15:59:42
|
<Isarra>
|
Sorry.
|
|
2018-07-18 16:00:22
|
<Lucas_WMDE>
|
tgr: that doesn’t sound too different from 100 ->supports() calls to me…
|
|
2018-07-18 16:00:30
|
<addshore>
|
Times up!
|
|
2018-07-18 16:00:33
|
<CFisch_WMDE>
|
\o/
|
|
2018-07-18 16:00:49
|
<dbs>
|
Huge thanks Lucas_WMDE++
|
|
2018-07-18 16:00:54
|
<Lucas_WMDE>
|
and we currently do those null checks, we’re just not using the service registry yet
|
|
2018-07-18 16:00:56
|
<addshore>
|
:D Thanks Lucas_WMDE !
|
|
2018-07-18 16:00:58
|
<CFisch_WMDE>
|
Thanks for this awesome Technical Advice IRC Meeting!
|
|
2018-07-18 16:01:04
|
<Lucas_WMDE>
|
thanks everyone!
|
|
2018-07-18 16:01:05
|
<addshore>
|
Very busy one!
|
|
2018-07-18 16:01:07
|
<Lucas_WMDE>
|
thanks tgr for your comments :r
|
|
2018-07-18 16:01:09
|
<Lucas_WMDE>
|
* :)
|
|
2018-07-18 16:01:10
|
<tgr>
|
it's not. Ideally code would be written in a way where that's not needed.
|
|
2018-07-18 16:01:14
|
<CFisch_WMDE>
|
Oh yeah!
|
|
2018-07-18 16:01:19
|
<Niridya>
|
addshore you arrive at something ?
|
|
2018-07-18 16:02:34
|
<quiddity>
|
Niridya, I think using the #switch will work both at meta and at other SUL wikis. It also prevents the active translators from being distracted by less important work (ie. we don't want editors spending dozens of hours translating random userpages ;)
|
|
2018-07-18 16:02:48
|
<tgr>
|
(of course it is a lot easier to make sweeping theoretical claims like that than dealing with an actual use case...)
|
|
2018-07-18 16:03:03
|
<quiddity>
|
and if we used the <translate> system it would just appear in their usual task queue system
|
|
2018-07-18 16:03:57
|
<Nudin_WMDE>
|
ciao
|
|
2018-07-18 16:04:13
|
<quiddity>
|
(Niridya, Note: Addshore and I are disappearing to find food now. Good luck!)
|
|
2018-07-18 16:04:24
|
<Niridya>
|
quiddity that's a good idea to don't distract translators ;)
|
|
2018-07-18 16:04:30
|
<addshore>
|
\o
|
|
2018-07-18 16:04:58
|
<Niridya>
|
good luck addshore !
|
|
2018-07-18 16:05:02
|
<Lucas_WMDE>
|
tgr: do you want to summarize that for Discourse or should I do it?
|
|
2018-07-18 16:05:09
|
<Lucas_WMDE>
|
I think it would be useful to record the answer there
|
|
2018-07-18 19:24:20
|
<Zoranzoki21>
|
HI, I talk with user Seadick which opened task T199930. I saw to he earlier opened T124417. Can you check, is there problem with databases?
|
|
2018-07-18 19:24:24
|
<stashbot>
|
T124417: Connection to Wikimedia projects slow/timing out for some users - https://phabricator.wikimedia.org/T124417
|
|
2018-07-18 19:24:24
|
<stashbot>
|
T199930: I can't edit and can't view preview - https://phabricator.wikimedia.org/T199930
|
|
2018-07-18 23:24:22
|
<jonkolbert>
|
I'm getting a weird error when trying to delete something
|
|
2018-07-18 23:24:49
|
<jonkolbert>
|
eh, I reloaded it a third time and it worked
|
|
2018-07-18 23:27:03
|
<MatmaRex>
|
jonkolbert: in the future, please copy the error message when reporting it, so we can investigate :)
|
|
2018-07-18 23:27:53
|
<jonkolbert>
|
MatmaRex: Yeah, my bad. I accidentally closed out the window and tried to reproduce but it worked the last time around
|
|
2018-07-18 23:28:00
|
<jonkolbert>
|
sorry about that :P
|
|
2018-07-18 23:28:06
|
<MatmaRex>
|
:)
|