|
2018-09-05 10:40:12
|
<revi>
|
anyone knows where's the config file for wiki redirecting to incubator (i.e. ko.wikivoyage.org )?
|
|
2018-09-05 10:44:26
|
<Hauskatze>
|
revi: puppet IIRC
|
|
2018-09-05 10:44:32
|
<Hauskatze>
|
you back?
|
|
2018-09-05 10:44:37
|
<revi>
|
not really
|
|
2018-09-05 10:45:02
|
<Hauskatze>
|
mutante knows about puppet/DNS stuff
|
|
2018-09-05 10:45:21
|
<revi>
|
I was digging puppet for 20 minutes and then gave up
|
|
2018-09-05 10:46:20
|
<Hauskatze>
|
can't blame you, it's complicated
|
|
2018-09-05 10:47:21
|
<Hauskatze>
|
it might not be in puppet though
|
|
2018-09-05 10:48:06
|
<revi>
|
yeah....
|
|
2018-09-05 10:50:27
|
<Hauskatze>
|
revi: okay so I see a correlation in https://github.com/wikimedia/operations-dns/blob/master/templates/helpers/langs.tmpl
|
|
2018-09-05 10:50:54
|
<Hauskatze>
|
if the language is there, but the project does not exist, it redirects you to the relevant incubator page
|
|
2018-09-05 10:51:06
|
<Hauskatze>
|
but I guess this depends on some other config
|
|
2018-09-05 10:51:36
|
<revi>
|
yeah it must depend on some other confiug
|
|
2018-09-05 10:51:42
|
<revi>
|
which is unknown to us
|
|
2018-09-05 10:52:00
|
<revi>
|
https://phabricator.wikimedia.org/source/mediawiki-config/browse/master/wmf-config/missing.php maybe this?
|
|
2018-09-05 10:52:17
|
<revi>
|
yeah looks like it
|
|
2018-09-05 10:53:17
|
<Hauskatze>
|
yup, I saw that previously references
|
|
2018-09-05 10:53:20
|
<Hauskatze>
|
*referenced
|
|
2018-09-05 10:54:05
|
<Hauskatze>
|
WS and WV indeed show 404 because of beta.wikiversity and oldwikisource
|
|
2018-09-05 14:00:08
|
<wm-bot>
|
Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @Tim_WMDE & @amir1 - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2018-09-05 14:50:10
|
<wm-bot>
|
Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @Tim_WMDE & @amir1 - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2018-09-05 14:51:37
|
<stjn>
|
Quick question before the meeting starts, sorry if I’m interrupting it: is there anything on Phabricator about Wikimedia Maps that stopped working? (test on https://ru.wikipedia.org/wiki/Казань)
|
|
2018-09-05 14:51:58
|
<andre__>
|
stjn, steps to reproduce?
|
|
2018-09-05 14:52:19
|
<stjn>
|
Just go there, see if maplink is clickable (for me and others it’s not).
|
|
2018-09-05 14:52:27
|
<andre__>
|
https://phabricator.wikimedia.org/T203427
|
|
2018-09-05 14:53:52
|
<stjn>
|
Hm. I think that person is after the wrong solution (since after removing CSS for pointer-events the issue of not having maplinks that work persists). Thank you.
|
|
2018-09-05 14:54:09
|
<andre__>
|
I've pinged about the task in #wikimedia-discovery - it's close to "unbreak now" for me...
|
|
2018-09-05 14:54:30
|
<Hauskatze>
|
I'd say it's UBN for me but not touching
|
|
2018-09-05 14:56:41
|
<Hauskatze>
|
fwiw I see the maps fine on Edge
|
|
2018-09-05 14:56:45
|
<Hauskatze>
|
trying Chrome
|
|
2018-09-05 15:02:31
|
<tim_WMDE>
|
Hey everyone, me and amir1 are here to answer your questions at this week's technical advice IRC meeting
|
|
2018-09-05 15:03:09
|
<Amir1>
|
hello, welcome to TAIM
|
|
2018-09-05 15:05:00
|
<Eugene233>
|
Amir1: Thanks
|
|
2018-09-05 15:06:30
|
<Eugene233>
|
This is my first TAIM. I wish to ask if there is a particular way to use Special:UserLogin from an extension.
|
|
2018-09-05 15:06:57
|
<bawolff>
|
!authmanager
|
|
2018-09-05 15:07:04
|
<bawolff>
|
guess I'm in the wrong channel for that
|
|
2018-09-05 15:07:21
|
<bawolff>
|
Eugene233: Do you mean, you want to extend the Special:Userlogin form
|
|
2018-09-05 15:08:09
|
<bawolff>
|
in which case you'll want to look at https://www.mediawiki.org/wiki/Manual:SessionManager_and_AuthManager (little bit complicated)
|
|
2018-09-05 15:08:22
|
<mainframe98>
|
Hello! I have a question regarding OOUI; specifically, the ToggleSwitchWidget. Is there anyway to replace the existing (PHP generated) checkbox with the ToggleSwitchWidget in the way that the form still works?
|
|
2018-09-05 15:08:44
|
<bawolff>
|
Eugene233: Or do you mean you just want your extension to log in, in which case i'd ask what are you trying to do, as that's not something extensions usually do
|
|
2018-09-05 15:10:53
|
<Amir1>
|
mainframe98: let me check
|
|
2018-09-05 15:11:41
|
<Eugene233>
|
bawolff: Since the extension is used to edit wiki pages, it will be good to verify if the user is logged in before doing the edit. So login from the extension.
|
|
2018-09-05 15:11:55
|
<tim_WMDE>
|
mainframe98 Do you mean implementing it into a standard HTML form?
|
|
2018-09-05 15:12:06
|
<bawolff>
|
Eugene233: It sounds like you don't really want to log in, so much as check if the user is logged in?
|
|
2018-09-05 15:12:31
|
<bawolff>
|
it which case, you can often do that via $this->getUser()->isLoggedIn()
|
|
2018-09-05 15:12:48
|
<mainframe98>
|
tim_WMDE: in a MediaWiki HTMLForm. There's an existing form with a checkbox that would convey its meaning clearer with a ToggleSwitchWidget
|
|
2018-09-05 15:12:50
|
<bawolff>
|
(Assuming $this is an instance of IContextSource, which is true for special pages and many things)
|
|
2018-09-05 15:15:17
|
<Eugene233>
|
bawolff: ok
|
|
2018-09-05 15:16:01
|
<Amir1>
|
mainframe98: https://www.mediawiki.org/wiki/HTMLForm/tutorial3 Have you seen this?
|
|
2018-09-05 15:16:05
|
<bawolff>
|
Eugene233: See also https://doc.wikimedia.org/mediawiki-core/master/php/classUser.html
|
|
2018-09-05 15:16:21
|
<Amir1>
|
This basically covers everything with HTMLForm
|
|
2018-09-05 15:16:28
|
<Amir1>
|
I use that often
|
|
2018-09-05 15:17:55
|
<mainframe98>
|
Amir1: A lot. That's what I always use when developing with HTMLForm. Unfortunately, on the PHP side of things, we only get the plain checkbox in OOUI,
|
|
2018-09-05 15:18:28
|
<mainframe98>
|
HTMLForm's toggle type is just an alias for check, they result in the exact same checkbox
|
|
2018-09-05 15:21:06
|
<tim_WMDE>
|
Did you set your HTMLForm factory to use the OOUI toolkit?
|
|
2018-09-05 15:21:17
|
<tim_WMDE>
|
As described here: https://www.mediawiki.org/wiki/HTMLForm#Display_formats
|
|
2018-09-05 15:21:42
|
<mainframe98>
|
tim_WMDE: It's a custom form inheriting from OOUIHTMLForm
|
|
2018-09-05 15:22:15
|
<mainframe98>
|
Frankly, the form itself works fine, as does the widget infusion. I'm just not sure how I can replace a regular checkbox with the ToggleSwitchWidget kind
|
|
2018-09-05 15:23:46
|
<Amir1>
|
mainframe98: https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop ?
|
|
2018-09-05 15:26:08
|
<mainframe98>
|
Amir1: I've seen that one. Those are all the JavaScript widgets. I know I can just use a ResourceLoader module and add a ToggleSwitchWidget to the form, but I need the widget to replace the existing checkbox,
|
|
2018-09-05 15:26:13
|
<mainframe98>
|
but still submit the form correctly
|
|
2018-09-05 15:26:52
|
<tim_WMDE>
|
I think you need to do something like they do here: https://gerrit.wikimedia.org/g/mediawiki/extensions/AbuseFilter/+/5b401328ac64fca69c0146523cbf688e79024165/includes/Views/AbuseFilterViewExamine.php#198
|
|
2018-09-05 15:27:47
|
<tim_WMDE>
|
Create a new ToggleSwitchWidget and throw it into your HTML, though I have not done this myself and it might not be super trivial / it might break the form without further JS adaptions
|
|
2018-09-05 15:28:21
|
<Amir1>
|
mainframe98: What I did for several cases was to actually change the existing behaviour and send the new data and parse it (with b/c of course)
|
|
2018-09-05 15:28:44
|
<Amir1>
|
I think I did it with on Special page before
|
|
2018-09-05 15:28:50
|
<Amir1>
|
*one
|
|
2018-09-05 15:29:05
|
<Amir1>
|
I don't know if I can be clear in this case
|
|
2018-09-05 15:30:40
|
<mainframe98>
|
tim_WMDE: The issue with that example is that they manually build the form. If I had to do that, I'd end up re-inventing HTMLForm, with all it's disadvantages.
|
|
2018-09-05 15:30:58
|
<mainframe98>
|
* With all the disadvantages of re-inventing
|
|
2018-09-05 15:34:49
|
<mainframe98>
|
Oh, and another question before I forget to ask, [[mw:Best practices for extensions]] doesn't mention what the convention for names of sql files in extensions is.
|
|
2018-09-05 15:35:57
|
<chiborg>
|
mainframe98: The ToggleSwitchWidget only works with JavaScript, because the regular checkbox element is replaced with custom DOM nodes. I know that there is some way to infuse server-rendered forms with OOUI on the client side.
|
|
2018-09-05 15:37:02
|
<chiborg>
|
mainframe98 Do you have a code example how you're generating the form in PHP?
|
|
2018-09-05 15:38:02
|
<mainframe98>
|
chiborg: It's just a simple HTMLForm checkbox, like on the mw.org tutorials: https://www.mediawiki.org/wiki/HTMLForm/tutorial3#check
|
|
2018-09-05 15:39:22
|
<Amir1>
|
mainframe98: I haven't seen such convention for extension but I know most extensions follow this type of convention: https://github.com/wikimedia/mediawiki-extensions-ORES
|
|
2018-09-05 15:39:32
|
<Amir1>
|
https://github.com/wikimedia/mediawiki-extensions-ORES/tree/master/sql
|
|
2018-09-05 15:40:34
|
<mainframe98>
|
Amir1: That's a very useful example. I'll use that one
|
|
2018-09-05 15:40:47
|
<mainframe98>
|
Amir1: Thank you!
|
|
2018-09-05 15:40:51
|
<Amir1>
|
mainframe98: if you have any questions, let me know
|
|
2018-09-05 15:41:38
|
<tim_WMDE>
|
In addition to what Amir wrote, you can always also search other projects with some relevant keywords and see what they did. For example, in this case you may want to have a look at all extensions which use onLoadExtensionSchemaUpdates if that's what you are doing: https://codesearch.wmflabs.org/search/?q=onLoadExtensionSchemaUpdates&i=nope&files=&repos=
|
|
2018-09-05 15:41:52
|
<tim_WMDE>
|
From there you quickly see the pattern that Amir already showed you
|
|
2018-09-05 15:42:24
|
<chiborg>
|
mainframe98 I found the section "Adding JavaScript behaviors" at https://www.mediawiki.org/wiki/OOUI/PHP_examples, where there is an example of how to add client-side code. So you'd have to add the 'infusable' key to your PHP initialization code and in JavaScript call OO.ui.infuse on the element when the page has loaded.
|
|
2018-09-05 15:43:37
|
<mainframe98>
|
chiborg: I've done that. Infusion is not the issue; that works as expected, rather, I need to replace the now infused widget with the ToggleSwitchWidget, and I can't seem to get that to happen
|
|
2018-09-05 15:44:19
|
<tim_WMDE>
|
Is your code publicly hosted somewhere that we could look at?
|
|
2018-09-05 15:46:39
|
<mainframe98>
|
tim_WMDE: There's no actual code, because I'm just testing here. I can create a quick gist with my experiments so far though
|
|
2018-09-05 15:47:55
|
<tim_WMDE>
|
Ah alright
|
|
2018-09-05 15:48:21
|
<tim_WMDE>
|
But in that case I think my initial link I sent you is really the best thing you can do I am afraid
|
|
2018-09-05 15:49:14
|
<mainframe98>
|
tim_WMDE: https://gist.github.com/mainframe98/7da5a4849be7e159049e6e00025dcc45
|
|
2018-09-05 15:49:25
|
<tim_WMDE>
|
Have a look at this URL, at the top you can switch between JS, PHP and Infuse: https://doc.wikimedia.org/oojs-ui/master/demos/demos.php?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop
|
|
2018-09-05 15:49:43
|
<tim_WMDE>
|
You can see that the ToggleSwitch is not available for PHP / Infuse because its missing from the list
|
|
2018-09-05 15:50:18
|
<tim_WMDE>
|
So the only way to add it would be to create a custom solution as sort of indicated earlier
|
|
2018-09-05 15:51:03
|
<mainframe98>
|
tim_WMDE: I got that far. I'm not attempting to do anything at the PHP side of things, but I want to give users using JS the toggleSwitchWidget instead of the regular checkbox
|
|
2018-09-05 15:52:36
|
<mainframe98>
|
To recap, I have a form with a PHP generated OOUI checkbox. I can infuse that checkbox, but I'd rather show a ToggleSwitchWidget to users. I don't know how I should replace (using JS) an existing checkbox with a ToggleSwitchWidget
|
|
2018-09-05 15:52:36
|
<tim_WMDE>
|
Ah okay, apologies for the misunderstanding, I see now
|
|
2018-09-05 15:53:16
|
<mainframe98>
|
As in, when the user submits, the state (true/false) from the toggleSwitchWidget is sent as if it where the original checkbox
|
|
2018-09-05 15:55:33
|
<chiborg>
|
mainframe98 thanks for your patience, I think I get it now. My appracah would be to not use infuse in this case, but to hide the checkbox element, put a newly created ToggleSwitchWidget in its container, just like you do now. Then add an event handler to the ToggleSwitchWidget that changes the checkbox value in the background.
|
|
2018-09-05 15:55:59
|
<mainframe98>
|
chiborg: That's genius!
|
|
2018-09-05 15:56:17
|
<mainframe98>
|
I'll give that a shot. That sound like the best approach here.
|
|
2018-09-05 16:01:35
|
<chiborg>
|
mainframe98: You're not alone with the problem, there is also this issue: https://phabricator.wikimedia.org/T182466
|
|
2018-09-05 16:02:44
|
<mainframe98>
|
chiborg: Thank you for the link to that task, I'll subscribe to that.
|
|
2018-09-05 16:02:58
|
<mainframe98>
|
Thank you all for the help!
|
|
2018-09-05 16:04:23
|
<tim_WMDE>
|
Well, that concludes the Technical Advice IRC Meeting for the time being. The next one will start at 11 pm UTC. Thanks for your input chiborg
|
|
2018-09-05 17:41:17
|
<sqjxgnn>
|
WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER
|
|
2018-09-05 17:41:19
|
<sqjxgnn>
|
WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER
|
|
2018-09-05 17:41:20
|
<sqjxgnn>
|
WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER
|
|
2018-09-05 17:41:21
|
<sqjxgnn>
|
WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER
|
|
2018-09-05 17:41:59
|
<bawolff>
|
mark: --^
|
|
2018-09-05 17:42:01
|
<sqjxgnn>
|
WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER
|
|
2018-09-05 17:42:02
|
<sqjxgnn>
|
WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER
|
|
2018-09-05 17:42:03
|
<sqjxgnn>
|
WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER WAGGIE = LOSER
|
|
2018-09-05 21:11:06
|
<mateusbs17>
|
Hello everyone, I am having a hard time trying to build a PHPUnit test that requires csrf token to access the api endpoint, the extension in question is ReadingLists and I am following this document: https://www.mediawiki.org/wiki/API:Calling_internally
|
|
2018-09-05 21:11:33
|
<mateusbs17>
|
I keep getting the exception `ApiUsageException: Invalid CSRF token.`
|
|
2018-09-05 21:13:36
|
<mateusbs17>
|
Does someone know if there is a different way than the one pointed out on the Wiki page I am following?
|
|
2018-09-05 21:15:23
|
<bawolff>
|
Usuaully in unit tests, you more want to test the individual functions, not call the api internally
|
|
2018-09-05 21:15:30
|
<bawolff>
|
But those docs are the correct one
|
|
2018-09-05 21:17:12
|
<bawolff>
|
mateusbs17: I think maybe you should use $this->doApiRequestWithToken()
|
|
2018-09-05 21:17:46
|
<bawolff>
|
btw, if that turns out to be correct, please update the wiki page with any fixes it needs :)
|
|
2018-09-05 21:18:11
|
<mateusbs17>
|
Thank you bawolff, I will test it right now
|
|
2018-09-05 21:46:45
|
<mateusbs17>
|
I am now getting `ApiTestCase::setUp can be slow, tests must be "medium" or "large"`, I will try to dig more on documentation and take a deeper look into my code.
|
|
2018-09-05 22:00:06
|
<legoktm>
|
You just need an @medium tag
|
|
2018-09-05 22:00:07
|
<wm-bot>
|
Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @RoanKattouw & @Niharika - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2018-09-05 22:07:36
|
<mateusbs17>
|
Thanks legoktm it really helped me!
|
|
2018-09-05 22:15:23
|
<legoktm>
|
:))
|
|
2018-09-05 22:50:14
|
<wm-bot>
|
Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @RoanKattouw & @Niharika - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2018-09-05 23:00:38
|
<Niharika>
|
waves
|
|
2018-09-05 23:01:13
|
<Niharika>
|
Hey all. This is my first TAIM and I'm so excited to be here.
|
|
2018-09-05 23:01:28
|
<physikerwelt>
|
Hi Niharika
|
|
2018-09-05 23:01:44
|
<Niharika>
|
Hi physikerwelt. How're you doing?
|
|
2018-09-05 23:01:58
|
<physikerwelt>
|
I'm fine. My first meeting too.
|
|
2018-09-05 23:02:06
|
<physikerwelt>
|
How are you?
|
|
2018-09-05 23:02:16
|
<legoktm>
|
o/
|
|
2018-09-05 23:02:28
|
<Niharika>
|
Pretty good.
|
|
2018-09-05 23:02:38
|
<Niharika>
|
We have a legoktm!
|
|
2018-09-05 23:03:26
|
<RoanKattouw>
|
I'm only half here, I was sick most of the day
|
|
2018-09-05 23:03:53
|
<Niharika>
|
RoanKattouw: Ouch. :(
|
|
2018-09-05 23:04:15
|
<physikerwelt>
|
RoanKattouw: get well soon
|
|
2018-09-05 23:04:33
|
<RoanKattouw>
|
Working on it :) I'm in the crackers and mashed banana stage rn
|
|
2018-09-05 23:04:44
|
<James_F>
|
Breakfast of champions.
|
|
2018-09-05 23:04:57
|
<physikerwelt>
|
:-)
|
|
2018-09-05 23:07:42
|
<physikerwelt>
|
I would like to get some technical advice on debugging CI problems... not sure if this TAIM is the right format though
|
|
2018-09-05 23:08:21
|
<Niharika>
|
physikerwelt: Which ones?
|
|
2018-09-05 23:08:31
|
<Niharika>
|
We can try and help.
|
|
2018-09-05 23:08:57
|
<physikerwelt>
|
I am looking at the math extension tests https://gerrit.wikimedia.org/r/#/projects/mediawiki/extensions/Math,dashboards/default
|
|
2018-09-05 23:10:08
|
<Niharika>
|
physikerwelt: Any specific commit or all of the failing ones?
|
|
2018-09-05 23:10:16
|
<physikerwelt>
|
with the quibble jobs the config seems to absent
|
|
2018-09-05 23:10:32
|
<physikerwelt>
|
it is for all commits
|
|
2018-09-05 23:10:49
|
<Niharika>
|
18:12:24 Error: 1146 Table 'wikidb.LexemeSpecialWhatLinksHereTest-table-user_groups' doesn't exist (/tmp/quibble-mysql-wtn4myrr/socket)
|
|
2018-09-05 23:11:49
|
<Niharika>
|
Hmm, I'm not quite sure what's going on with it.
|
|
2018-09-05 23:11:59
|
<physikerwelt>
|
with try and error I was able to work around the problem
|
|
2018-09-05 23:11:59
|
<physikerwelt>
|
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/455482/
|
|
2018-09-05 23:12:37
|
<physikerwelt>
|
however, there is a really bad hack hidden
|
|
2018-09-05 23:12:37
|
<physikerwelt>
|
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/455482/17/src/MathRenderer.php
|
|
2018-09-05 23:12:51
|
<physikerwelt>
|
so I don't think this patch will ever be merged
|
|
2018-09-05 23:14:59
|
<physikerwelt>
|
on the other hand patches that are good to be reviewed like that one https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/442124/ from Jun 25 can't be reviewed since the tests are broken
|
|
2018-09-05 23:16:39
|
<physikerwelt>
|
As I understand overwriting jenkins and merging manually should be avoided
|
|
2018-09-05 23:17:18
|
<Niharika>
|
I wonder if legoktm has an idea about this. I'm looking for older commits that do this but I can't immediately find one.
|
|
2018-09-05 23:17:44
|
<paladox>
|
if the tests are still broken (and you verified your change works) then force merge it until ci is fixed.
|
|
2018-09-05 23:17:45
|
<legoktm>
|
Hi
|
|
2018-09-05 23:18:29
|
<legoktm>
|
Hmm
|
|
2018-09-05 23:18:45
|
<TimStarling>
|
the problem is that default config from extension.json is not applied to the globals?
|
|
2018-09-05 23:19:13
|
<physikerwelt>
|
TimStarling: yes
|
|
2018-09-05 23:19:40
|
<physikerwelt>
|
at least not in the quibble job
|
|
2018-09-05 23:19:53
|
<legoktm>
|
Ohai. I was going to suggest pinging Tim for help since he recently figured out how to reproduce complex CI failures :)
|
|
2018-09-05 23:20:29
|
<TimStarling>
|
by the magic of installing a fresh extension-free wiki
|
|
2018-09-05 23:20:37
|
<TimStarling>
|
and running the command as it appears in jenkins
|
|
2018-09-05 23:20:57
|
<physikerwelt>
|
that's where my second part of the question I had for the question of todays meeting comes up. How can I run the job localy. I managed to run quibble. with and without docker but I am not sure how I can see and change the config
|
|
2018-09-05 23:21:44
|
<legoktm>
|
there's no extra config besides what quibble injects
|
|
2018-09-05 23:23:44
|
<physikerwelt>
|
so all I need to do is to set ZUUL_PROJECT
|
|
2018-09-05 23:25:18
|
<physikerwelt>
|
the best guide I could find is on https://gerrit.wikimedia.org/r/#/c/integration/quibble/+/452335/2/doc/source/build-reproduction.rst
|
|
2018-09-05 23:26:43
|
<legoktm>
|
That looks right
|
|
2018-09-05 23:26:57
|
<legoktm>
|
With hashar's comments
|
|
2018-09-05 23:27:12
|
<legoktm>
|
Sorry, I need to go to class now
|
|
2018-09-05 23:27:39
|
<TimStarling>
|
I can have a go at reproducing it but it will probably take longer than this meeting
|
|
2018-09-05 23:28:02
|
<Niharika>
|
Thanks legoktm.
|
|
2018-09-05 23:28:31
|
<physikerwelt>
|
Thank you. I just wanted to be sure that I am not just missing the simple trick that everyone else is aware of
|
|
2018-09-05 23:29:36
|
<physikerwelt>
|
and why is this only a problem for math?
|
|
2018-09-05 23:31:59
|
<Niharika>
|
physikerwelt: It might not be a problem just for math.
|
|
2018-09-05 23:33:12
|
<Niharika>
|
TimStarling: What's a good way for physikerwelt to get your guidance on this? Should they file a ticket and take this discussion there?
|
|
2018-09-05 23:34:12
|
<TimStarling>
|
I'm looking at it now
|
|
2018-09-05 23:34:38
|
<TimStarling>
|
but a ticket would be good in any case
|
|
2018-09-05 23:34:48
|
<physikerwelt>
|
There is T202223 but the scope of the ticket is not clear
|
|
2018-09-05 23:34:49
|
<stashbot>
|
T202223: WikibaseLexeme LexemeSpecialWhatLinksHereTest tests fail on Math CI - https://phabricator.wikimedia.org/T202223
|
|
2018-09-05 23:37:09
|
<TimStarling>
|
what is MathDataUpdaterTest?
|
|
2018-09-05 23:38:07
|
<physikerwelt>
|
that's a test for a different hack that shows formulae in wikidata without messing up with the page cache
|
|
2018-09-05 23:38:56
|
<physikerwelt>
|
T173949
|
|
2018-09-05 23:38:57
|
<stashbot>
|
T173949: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded - https://phabricator.wikimedia.org/T173949
|
|
2018-09-05 23:39:55
|
<TimStarling>
|
you can see the exact LocalSettings.php jenkins used, as a build artifact
|
|
2018-09-05 23:40:24
|
<TimStarling>
|
it has 26 extensions installed
|
|
2018-09-05 23:40:56
|
<physikerwelt>
|
where would I get it from this change https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/458320/
|
|
2018-09-05 23:41:02
|
<physikerwelt>
|
for example
|
|
2018-09-05 23:41:25
|
<paladox>
|
i think from https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/
|
|
2018-09-05 23:41:29
|
<Reedy>
|
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/15126/console -> https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/15126
|
|
2018-09-05 23:41:37
|
<TimStarling>
|
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/15126/artifact/log/LocalSettings.php
|
|
2018-09-05 23:42:00
|
<physikerwelt>
|
thank you
|
|
2018-09-05 23:42:22
|
<TimStarling>
|
from the jenkins link in gerrit you click status, then under build artifacts, click the + button
|
|
2018-09-05 23:46:21
|
<TimStarling>
|
oh I see, in integration/config/zuul/parameter_functions.py, Math depends on Wikibase, and then Wikibase depends on a bunch of extensions
|
|
2018-09-05 23:46:48
|
<TimStarling>
|
including CirrusSearch which depends on a bunch more extensions
|
|
2018-09-05 23:47:42
|
<TimStarling>
|
so what we need is a test wiki with these 26 extensions on which to run tests
|
|
2018-09-05 23:49:42
|
<physikerwelt>
|
can that be setup with the quibble script
|
|
2018-09-05 23:54:12
|
<physikerwelt>
|
oh did you see that $wgWikimediaJenkinsCI = true;
|
|
2018-09-05 23:55:28
|
<TimStarling>
|
yes
|
|
2018-09-05 23:57:05
|
<TimStarling>
|
--with-extensions is annoying, you either get all extensions or none
|
|
2018-09-05 23:58:17
|
<TimStarling>
|
I mean maintenance/install.php --with-extensions
|
|
2018-09-05 23:59:13
|
<physikerwelt>
|
yes that makes sense to me https://phabricator.wikimedia.org/T201496#4487976
|