|
2017-10-04 09:53:11
|
<snitch>
|
[[Tech]]; EddieGP; /* HELP!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! */; https://meta.wikimedia.org/w/index.php?diff=17297483&oldid=17296632&rcid=10644334
|
|
2017-10-04 11:34:43
|
<andre__>
|
For my better technical understanding: I edit a template. I purge a wiki page which uses/embeds that template. Still that page shows the old version of the template. How long do I have to wait to pick that change up? Until the JobQueue has picked it up?
|
|
2017-10-04 11:46:32
|
<thedj>
|
andre__: do you have a jobqueue runner configured ?
|
|
2017-10-04 11:46:51
|
<andre__>
|
I actually refer to www.mediawiki.org. :P
|
|
2017-10-04 11:47:21
|
<andre__>
|
This is probably a very basic question but I've always wanted to understand this.
|
|
2017-10-04 11:47:24
|
<thedj>
|
oh that usually should be instant.
|
|
2017-10-04 11:48:32
|
<thedj>
|
if you specifically purge a page, then then noramlly, that forces the renderer, to fetch the latest version of a template.
|
|
2017-10-04 11:49:02
|
<andre__>
|
Hmm, weird. Because I edited https://www.mediawiki.org/wiki/Template:API to remove the 6th bullet point in that box. And I have purged https://www.mediawiki.org/wiki/API:Main_page but the old one is still displayed for me. And passed my browser cache, yadda yadda.
|
|
2017-10-04 11:49:33
|
<andre__>
|
same in a fresh (different) browser - "Tutorial" should not be listed anymore.
|
|
2017-10-04 11:53:15
|
<thedj>
|
oh, this is possibly because of translations...
|
|
2017-10-04 11:53:46
|
<thedj>
|
changing to elements that need to be translated require to be approved by a translation admin first.
|
|
2017-10-04 11:55:37
|
<thedj>
|
eh. oops..
|
|
2017-10-04 11:56:10
|
<thedj>
|
i think i just approved it, but i have no clue if that was correct.. The translation extension is freaking dark magic to me.
|
|
2017-10-04 11:56:24
|
<thedj>
|
Nemo_bis: help ?
|
|
2017-10-04 11:56:28
|
<Aguyintobooks>
|
join the club^
|
|
2017-10-04 11:59:09
|
<andre__>
|
thedj: Uh, now that is interesting. And funny, as I basically /removed/ a translation.
|
|
2017-10-04 11:59:20
|
<andre__>
|
But good to know. That finally explains my confusion a bit. Thanks!
|
|
2017-10-04 11:59:40
|
<andre__>
|
and yes, https://www.mediawiki.org/wiki/API:Main_page looks like expected now. Heh.
|
|
2017-10-04 12:16:12
|
<thedj>
|
hmm, shouldn't translation pages use a different content model btw....
|
|
2017-10-04 13:23:17
|
<Nemo_bis>
|
thedj: there are worse extensions to wikitext :)
|
|
2017-10-04 13:23:30
|
<Nemo_bis>
|
WFM, I don't see a link to the tutorial any longer in the navigational box at https://www.mediawiki.org/wiki/API:Main_page
|
|
2017-10-04 13:24:04
|
<Nemo_bis>
|
maybe slow purges for the long job queue? O_o
|
|
2017-10-04 13:31:59
|
<andre__>
|
DJ wrote "i think i just approved it" above. And that helped.
|
|
2017-10-04 14:32:33
|
<Nudin_WMDE>
|
Technical Advice IRC meeting starting in 30 minutes in channel #wikimedia-tech, hosts: @addshore & @Andrew-WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2017-10-04 15:00:39
|
<Nudin_WMDE>
|
Technical Advice IRC meeting starting now in channel #wikimedia-tech, hosts: @addshore & @Andrew-WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2017-10-04 15:00:46
|
<Nemo_bis>
|
ok
|
|
2017-10-04 15:00:47
|
<andre__>
|
waves
|
|
2017-10-04 15:02:33
|
<addshore>
|
\o
|
|
2017-10-04 15:02:44
|
<smartyrad>
|
Hi addshore
|
|
2017-10-04 15:02:45
|
<addshore>
|
Hi All, here starts this weeks installment!
|
|
2017-10-04 15:03:49
|
<smartyrad>
|
I have 2 questions today and both are blockers. Will need your help :)
|
|
2017-10-04 15:04:53
|
<smartyrad>
|
1) I wanted to know as to how can I edit the captcha logic for simple captcha used on the mediawiki account creation page?
|
|
2017-10-04 15:05:21
|
<smartyrad>
|
I have installed the Confirm edit extension and it works as well!
|
|
2017-10-04 15:06:23
|
<smartyrad>
|
I am using Simple Captcha for this
|
|
2017-10-04 15:07:34
|
<smartyrad>
|
According to me, these edits can be made if I change something here https://goo.gl/W4PxSS right?
|
|
2017-10-04 15:07:49
|
<addshore>
|
So, it doesnt look like you can change the logic of SimpleCaptcha specifically
|
|
2017-10-04 15:08:00
|
<addshore>
|
Ahh, yes, well you can change the code or make your own captcha class
|
|
2017-10-04 15:09:10
|
<smartyrad>
|
Addshore: As a starter, I was trying to change the code for it(later I will create my own class) but is there anything we have to doafter modifying the PHP file?
|
|
2017-10-04 15:09:30
|
<addshore>
|
smartyrad: there shouldnt be no
|
|
2017-10-04 15:09:43
|
<addshore>
|
smartyrad: I'm curious, in what way are you changing it?
|
|
2017-10-04 15:10:36
|
<smartyrad>
|
addshore: Ah , good question! I am trying to complete an issue on Phabricator located here https://phabricator.wikimedia.org/T177034
|
|
2017-10-04 15:10:42
|
<addshore>
|
*looks*
|
|
2017-10-04 15:11:18
|
<smartyrad>
|
I figured that the first thing to try out would be to modify the existing file and understand how it works
|
|
2017-10-04 15:12:54
|
<smartyrad>
|
Basically , I am still unable to figure out as to modify the existing code on the account creation page
|
|
2017-10-04 15:13:40
|
<smartyrad>
|
Even wihtout modifying the captcha , I guess I can pull that off provided I know where the Html for the SignUp page is
|
|
2017-10-04 15:15:22
|
<smartyrad>
|
addshore: FOr starters, I tried changing it by removing it altogether and seeing whether it still loads!
|
|
2017-10-04 15:16:46
|
<smartyrad>
|
But somehow , magically it still loads even after I delete that function. i tried looking for other functions that might be responsible for the captcha but this seems like the only one
|
|
2017-10-04 15:17:15
|
<smartyrad>
|
addshore: Any ideas?
|
|
2017-10-04 15:19:19
|
<addshore>
|
which function in particualr?
|
|
2017-10-04 15:19:28
|
<addshore>
|
do you have a patch somewhere i can look at?
|
|
2017-10-04 15:20:05
|
<smartyrad>
|
https://github.com/wikimedia/mediawiki-extensions-ConfirmEdit/blob/499f9a71b3e9a461b18571d7909709f5217d2dd4/SimpleCaptcha/Captcha.php#L120
|
|
2017-10-04 15:20:51
|
<smartyrad>
|
addshore: Sure, I'll add a link to pastebin in a bit
|
|
2017-10-04 15:23:29
|
<smartyrad>
|
addshore: Basically deleted the content https://pastebin.com/yRmXY1Ns (It still works)
|
|
2017-10-04 15:25:29
|
<addshore>
|
hmm, smartyrad interesting
|
|
2017-10-04 15:25:39
|
<addshore>
|
Did you try changing it instead of deleting it? what happened then?
|
|
2017-10-04 15:25:49
|
<addshore>
|
It could be there is some sort of caching, but i hihgly doubt it
|
|
2017-10-04 15:26:35
|
<smartyrad>
|
addshore: I strongly believe that this isn't the responsible function but could not find anything else
|
|
2017-10-04 15:27:06
|
<smartyrad>
|
addshore: As far as caching is concerned , I ensured that I hard reload the page in chrome
|
|
2017-10-04 15:31:25
|
<addshore>
|
Yup, after looking through the whole class it does look like that is the correct method
|
|
2017-10-04 15:34:22
|
<smartyrad>
|
addshore: Any idea what it might be? I have found the call that's responsible for displaying stuff on that page
|
|
2017-10-04 15:36:09
|
<smartyrad>
|
I'll add the link https://github.com/wikimedia/mediawiki/blob/79f24aece16d61f228db21e1b7f7b56a152cd9a1/includes/specialpage/LoginSignupSpecialPage.php#L581
|
|
2017-10-04 15:36:54
|
<smartyrad>
|
That's the exact line that loads the whole html on that page but I am not able to figure the location from where it gets all the data
|
|
2017-10-04 15:41:07
|
<addshore>
|
smartyrad: so the form comes from getAuthForm
|
|
2017-10-04 15:41:24
|
<addshore>
|
when you say "all the data" what exactly do you mean?
|
|
2017-10-04 15:42:37
|
<smartyrad>
|
addshore: By that I meant as to where is the form being defined along with the captcha?
|
|
2017-10-04 15:43:40
|
<smartyrad>
|
I mean some syntax/html should be there right? All I could see is $getform() everywhere but no origin :(
|
|
2017-10-04 15:44:30
|
<addshore>
|
$formDescriptor = static::fieldInfoToFormDescriptor( $requests, $fieldInfo, $this->authAction );
|
|
2017-10-04 15:44:57
|
<addshore>
|
or even $fieldInfo = AuthenticationRequest::mergeFieldInfo( $requests );
|
|
2017-10-04 15:45:34
|
<smartyrad>
|
addshore: Thanks ,How can I edit the form then?
|
|
2017-10-04 15:46:44
|
<smartyrad>
|
addshore: Sorry if my questions are lame but I am quite new to this as of now
|
|
2017-10-04 15:51:42
|
<addshore>
|
smartyrad: maybe CaptchaAuthenticationRequest::getFieldInfo
|
|
2017-10-04 15:52:48
|
<addshore>
|
smartyrad: https://github.com/wikimedia/mediawiki-extensions-ConfirmEdit/blob/master/includes/auth/CaptchaAuthenticationRequest.php#L52
|
|
2017-10-04 15:54:16
|
<smartyrad>
|
addshore: Thanks a ton! I'll just check it out
|
|
2017-10-04 15:54:22
|
<addshore>
|
:)
|
|
2017-10-04 15:54:30
|
<addshore>
|
Right, 5 minutes left! :D
|
|
2017-10-04 15:56:10
|
<smartyrad>
|
addshore: In that case I'll check it after this meeting
|
|
2017-10-04 15:56:23
|
<smartyrad>
|
THe second question is easy I guess
|
|
2017-10-04 15:56:41
|
<smartyrad>
|
https://www.mediawiki.org/wiki/Extension:EventLogging/Programming#How_it_works
|
|
2017-10-04 15:57:03
|
<smartyrad>
|
In that link , the first line mentions After you have created a schema, you must register it, by using the $wgEventLoggingSchemas
|
|
2017-10-04 15:57:15
|
<smartyrad>
|
WHere will I add the $wgEventLoggingSchemas ?
|
|
2017-10-04 15:57:52
|
<smartyrad>
|
addshore: Sorry for bothering you so much
|
|
2017-10-04 15:58:03
|
<addshore>
|
smartyrad: no worries, thats why im here
|
|
2017-10-04 15:58:32
|
<addshore>
|
smartyrad: you can do it in extension.json
|
|
2017-10-04 15:59:18
|
<smartyrad>
|
I tried to adding it to the extension.json of the Eventloggin module
|
|
2017-10-04 15:59:28
|
<smartyrad>
|
But it doesn't seem to work
|
|
2017-10-04 15:59:41
|
<smartyrad>
|
I have confirmed that the module is loaded and working
|
|
2017-10-04 15:59:55
|
<addshore>
|
smartyrad: for example https://github.com/wikimedia/mediawiki-extensions-NavigationTiming/blob/b3d878d680cba3e333f33c1dc4162944191b1737/extension.json#L51
|
|
2017-10-04 15:59:55
|
<smartyrad>
|
I just somehow need to get it registered
|
|
2017-10-04 16:01:49
|
<smartyrad>
|
addshore: That adds it to the extension.json of another module
|
|
2017-10-04 16:02:05
|
<smartyrad>
|
I want to use it within the COre module.
|
|
2017-10-04 16:02:29
|
<smartyrad>
|
Or more specifically, call it on the Signup page that we were just discussing about
|
|
2017-10-04 16:04:00
|
<quiddity>
|
andre__, thedj, for translations, even once approved by translation-admin, there's still the 5-30 second pause whilst fuzzybot does its thing. e.g. https://www.mediawiki.org/w/index.php?title=Template:API/en&action=history
|
|
2017-10-04 16:04:45
|
<smartyrad>
|
Would you perhaps know where to add https://www.mediawiki.org/wiki/Manual:$wgEventLoggingSchemas ? I tried adding it to localsettings.php but doesnt seem to help
|
|
2017-10-04 16:05:45
|
<smartyrad>
|
localsetting.php of mediawiki core
|
|
2017-10-04 16:06:07
|
<addshore>
|
smartyrad: aaaah
|
|
2017-10-04 16:07:54
|
<smartyrad>
|
addshore: Dont wish to keep you waiting if you're busy now since the meeting has technically ended :)
|
|
2017-10-04 16:08:21
|
<addshore>
|
smartyrad: hmm, for eventlogging in core I'm actually not sure
|
|
2017-10-04 16:08:57
|
<addshore>
|
I have to dash now unfortunately :/
|
|
2017-10-04 16:09:02
|
<addshore>
|
That wraps up this hour!
|
|
2017-10-04 16:09:20
|
<smartyrad>
|
addshore: Sure thing, no problem . Thanks a ton for your help!
|