2019-10-16 09:19:08
|
<ST47>
|
tools.wmflabs.org seems to be timing out at the moment
|
2019-10-16 13:01:16
|
<Daimona>
|
Hello, could someone please help me with user rights on the beta cluster?
|
2019-10-16 13:01:26
|
<hauskater>
|
Daimona: sure
|
2019-10-16 13:01:32
|
<Daimona>
|
Thanks :)
|
2019-10-16 13:01:36
|
<hauskater>
|
cinquemille
|
2019-10-16 13:01:38
|
<hauskater>
|
:P
|
2019-10-16 13:02:02
|
<Daimona>
|
DannyS712 asked me to be added to global developers but I have no idea how to do that 0:)
|
2019-10-16 13:02:25
|
<hauskater>
|
You file a task on Phab for #wikitech.wikimedia.org
|
2019-10-16 13:02:36
|
<hauskater>
|
but afaik there's no 'global devs'
|
2019-10-16 13:02:52
|
<hauskater>
|
it's been a while that I don't look at the list over there though
|
2019-10-16 13:03:21
|
<Daimona>
|
There's one: https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:GlobalGroupPermissions/developer
|
2019-10-16 13:03:32
|
<Daimona>
|
Though I don't know anything else
|
2019-10-16 13:04:31
|
<hauskater>
|
I see
|
2019-10-16 13:05:27
|
<hauskater>
|
I don't think there would be any issues adding you there. Please file a task and if no one objects we can add you :)
|
2019-10-16 13:06:00
|
<hauskater>
|
did I say wikitech project? Scratch that, beta cluster infraestructure
|
2019-10-16 13:06:28
|
<hauskater>
|
post-lunch coffee not yet flowing properly :)
|
2019-10-16 13:06:43
|
<Daimona>
|
Danny wants to be added, not me :)
|
2019-10-16 13:06:49
|
<Daimona>
|
I don't even know what that group is for
|
2019-10-16 13:06:58
|
<Daimona>
|
As I said, I'm completely ignorant about that :D
|
2019-10-16 13:07:12
|
<Daimona>
|
Will open a task anyway, thanks :)
|
2019-10-16 13:07:17
|
<hauskater>
|
Ah, well, the process is the same for anyone
|
2019-10-16 13:35:25
|
<hauskater>
|
Daimona: fwiw to grant global privs you can use https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:GlobalUserRights
|
2019-10-16 14:00:24
|
<wm-bot>
|
Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
2019-10-16 14:50:22
|
<wm-bot>
|
Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
2019-10-16 14:54:24
|
<James_F>
|
I’ll be happy to help answer questions for the Advice meeting if there aren’t any hosts (per the bot).
|
2019-10-16 14:54:47
|
<Lucas_WMDE_>
|
we have a WMDE host in the spreadsheet, but no WMF host yet (at least as of ~20 mins ago)
|
2019-10-16 14:54:57
|
<Lucas_WMDE_>
|
guess the wiki page wasn’t updated yet
|
2019-10-16 14:55:36
|
<James_F>
|
Right.
|
2019-10-16 14:56:00
|
<James_F>
|
I’m stuck on a train right now waiting for it to move, so I’m all ears.
|
2019-10-16 14:56:47
|
<hauskater>
|
James_F: well, since you volunteered, I was wondering if we shall implement Umherirrender's comments at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/329810/
|
2019-10-16 14:56:53
|
<hauskater>
|
see last comment
|
2019-10-16 14:57:00
|
<hauskater>
|
or if it is okay to merge as-is
|
2019-10-16 14:57:37
|
<James_F>
|
Hmm. Might be simpler to use the built-in function.
|
2019-10-16 14:57:48
|
<James_F>
|
When it changes later you get it for free.
|
2019-10-16 14:58:07
|
<hauskater>
|
also, having https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CentralAuth/+/475930/ would be a dream to come true
|
2019-10-16 14:58:21
|
<hauskater>
|
but I think it kinda requires a more paused review
|
2019-10-16 14:58:26
|
<hauskater>
|
idk
|
2019-10-16 14:58:52
|
<James_F>
|
That’ll need DBA assistance to make the production schema changes first.
|
2019-10-16 14:59:09
|
<James_F>
|
With back-compat/forwards-compat code.
|
2019-10-16 14:59:37
|
<James_F>
|
But it makes sense as a feature.
|
2019-10-16 15:00:16
|
<hauskater>
|
Given that we already have temporary local user rights, it'd be awesome to have the global counterpart
|
2019-10-16 15:00:21
|
<James_F>
|
Yeah.
|
2019-10-16 15:00:36
|
<hauskater>
|
I guess Melos is waiting to have that patch reviewed before asking DBAs for help?
|
2019-10-16 15:01:04
|
<James_F>
|
Possibly. Will look later.
|
2019-10-16 15:01:41
|
<tgr>
|
I can also answer questions for the first half
|
2019-10-16 15:01:56
|
<James_F>
|
Thanks, tgr
|
2019-10-16 15:02:56
|
<hauskater>
|
If you can take that look later James_F that'd be awesome. I think tgr does too some CentralAuth stuff iirc
|
2019-10-16 15:03:12
|
<hauskater>
|
I'll ask Manuel A. too
|
2019-10-16 15:05:06
|
<James_F>
|
tgr knows far more about CentralAuth code than I do. :-) But I can do a quick review.
|
2019-10-16 15:05:47
|
<tgr>
|
the expiry patch makes sense, I can't commit to review it anytime soon though
|
2019-10-16 15:05:47
|
<hauskater>
|
Thanks both, I appreciate your time
|
2019-10-16 15:05:54
|
<Reedy>
|
Easiest way is just to split that schema change into a different patch. Get it reviewed, merged
|
2019-10-16 15:06:04
|
<James_F>
|
Yeah.
|
2019-10-16 15:06:06
|
<tgr>
|
feel free to poke me in a month if it hasn't moved by then
|
2019-10-16 15:06:06
|
<Reedy>
|
Then merge the code using it when WMF schema changes are all done
|
2019-10-16 15:06:17
|
<James_F>
|
But we should check that the schema change is right first. :-)
|
2019-10-16 15:06:22
|
<tgr>
|
the other patch needs to be rewritten as James says
|
2019-10-16 15:07:53
|
<hauskater>
|
I was also doing Reedy's proposed task to update some extensions to use manifest_version 2 and I'm stuck at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AntiSpoof/+/539727/
|
2019-10-16 15:08:31
|
<hauskater>
|
the script also converted the unicode stuff into words and I'm not sure if we should keep the original u+numbers stuff or it's okay as it's now
|
2019-10-16 15:08:48
|
<tgr>
|
the other timestampts in the centralauth DB use varchar, not varbinary
|
2019-10-16 15:09:33
|
<tgr>
|
I think MediaWiki is inconsistent in general, but maybe you'd want to be consistent within a single extension at least
|
2019-10-16 15:09:52
|
<hauskater>
|
I agree
|
2019-10-16 15:16:28
|
<Reedy>
|
should be trivial enough things to fix
|
2019-10-16 15:16:30
|
<Reedy>
|
and to split
|
2019-10-16 15:16:40
|
<Reedy>
|
DBA review should be easy enough too
|
2019-10-16 15:21:20
|
<Reedy>
|
hauskater: For the AntiSpoof, I'd just revert the unicode changes
|
2019-10-16 15:22:57
|
<James_F>
|
Hmm. I think we can expect code editors to be Unicode-safe nowadays.
|
2019-10-16 15:23:17
|
<hauskater>
|
Reedy: okay, I'm waiting for jenkins for the phan change
|
2019-10-16 15:23:33
|
<Reedy>
|
James_F: That feels like a "famous last words"
|
2019-10-16 15:23:37
|
<Reedy>
|
I'd hope you're right though
|
2019-10-16 15:23:55
|
<James_F>
|
Reedy: Ha.
|
2019-10-16 15:24:15
|
<hauskater>
|
So I'll just use the \u1234 format?
|
2019-10-16 15:24:42
|
<hauskater>
|
yay, v+2
|
2019-10-16 15:24:50
|
<James_F>
|
Sure.
|
2019-10-16 15:26:30
|
<tgr>
|
yeah, use the \u format
|
2019-10-16 15:26:45
|
<hauskater>
|
Amending
|
2019-10-16 15:26:52
|
<tgr>
|
there is no difference but less of a pain in the ass to find out which character it is
|
2019-10-16 15:26:58
|
<Reedy>
|
heh
|
2019-10-16 15:27:22
|
<James_F>
|
hauskater: Seen my query on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Memento/+/543151 ?
|
2019-10-16 15:27:27
|
<tgr>
|
I wouldn't blame the script, they have the same PHP representation
|
2019-10-16 15:27:33
|
<James_F>
|
tgr: Less?
|
2019-10-16 15:27:45
|
<James_F>
|
Surely, more?
|
2019-10-16 15:27:59
|
<hauskater>
|
James_F: yeah, but I don't know the answer. I see there's another .sh file there and that was the only one which was publicly executable.
|
2019-10-16 15:28:11
|
<James_F>
|
hauskater: Eh. Let's merge for now.
|
2019-10-16 15:28:34
|
<tgr>
|
I guess you get a vague idea at least (except for the ones which are just tofu) but U numbers are easier to goole for
|
2019-10-16 15:28:43
|
<hauskater>
|
If you hear a blast and server kittens meow, then we'll know it's time to revert
|
2019-10-16 15:29:29
|
<James_F>
|
Those are all non-BMP. None should be tofu on a modern machine.
|
2019-10-16 15:36:21
|
<hauskater>
|
Back to unicode, and added some "description" as well for some config values
|
2019-10-16 15:41:30
|
<James_F>
|
Cool.
|
2019-10-16 15:41:48
|
<hauskater>
|
and is passing zuul
|
2019-10-16 15:41:55
|
<hauskater>
|
I'm so proud of myself :P
|
2019-10-16 15:57:17
|
<hauskater>
|
James_F: so "public": "true", ?
|
2019-10-16 15:57:34
|
<hauskater>
|
because afaik if nothing is stated it's taken as private by default
|
2019-10-16 15:59:22
|
<James_F>
|
hauskater: Yeah, we're defaulting to private.
|
2019-10-16 15:59:29
|
<James_F>
|
Not that that means much.
|
2019-10-16 15:59:47
|
<hauskater>
|
Okay, I'll add the public value
|
2019-10-16 15:59:49
|
<James_F>
|
But in the magical future there'll be Special:SiteConfiguration or whatever which will list things like this.
|
2019-10-16 15:59:51
|
<James_F>
|
Thanks.
|
2019-10-16 16:00:07
|
<hauskater>
|
As long as it doesn't break AntiSpoof :D
|
2019-10-16 16:02:30
|
<McJill>
|
Sounds neat
|
2019-10-16 16:02:47
|
<hauskater>
|
done James_F - rebased and waiting for jenkins as well, again :)
|
2019-10-16 16:02:52
|
<Lucas_WMDE>
|
I’ve been meaning to write a Phab task for that, actually (unless it already exists?)
|
2019-10-16 16:05:02
|
<hauskater>
|
T155155 I think
|
2019-10-16 16:05:03
|
<stashbot>
|
T155155: Implement a way to view (extension) configuration options and its value on-wiki - https://phabricator.wikimedia.org/T155155
|
2019-10-16 16:05:06
|
<hauskater>
|
but that's the general view
|
2019-10-16 16:08:00
|
<Lucas_WMDE>
|
I guess
|
2019-10-16 16:08:11
|
<Lucas_WMDE>
|
I was thinking more in an API direction, but that task seems general enough to cover that too
|
2019-10-16 16:11:18
|
<hauskater>
|
as for aftv5 James_F I've tried to update the whole lot of NPM dev deps but if I upgrade eslint then a whole lot of things start to break
|
2019-10-16 16:11:26
|
<hauskater>
|
like that house fire pic from yesterday
|
2019-10-16 16:14:51
|
<hauskater>
|
Argh. The phan issue I fixed was already fixed in another commit so in the rebase the changed file rightly do not appear, but I now have to ammend the commit message again
|
2019-10-16 16:34:52
|
<James_F>
|
hauskater: :-)
|
2019-10-16 16:44:01
|
<hauskater>
|
Thanks James_F - one thing less to worry about :)
|
2019-10-16 16:44:20
|
<hauskater>
|
I'll keep an eye on logstash-beta now that it's being merged to spot any issues
|
2019-10-16 16:45:26
|
<James_F>
|
Cool
|
2019-10-16 17:07:43
|
<hauskater>
|
ehm James_F beta-scap-eqiad is ~20 hours inactive at this moment
|
2019-10-16 17:07:53
|
<hauskater>
|
last run was a day ago or so
|
2019-10-16 17:07:59
|
<hauskater>
|
I'll ask releng
|