|
2019-11-20 13:36:27
|
<Sohom_Datta>
|
Is the lock icon loaded in resource loader if I do $out->enableOOUI() ?
|
|
2019-11-20 13:36:44
|
<Sohom_Datta>
|
It isn't working for me...
|
|
2019-11-20 13:41:53
|
<lens0021_>
|
do you mean in JS or PHP?
|
|
2019-11-20 13:44:25
|
<lens0021_>
|
sorry, forget my last word.
|
|
2019-11-20 13:44:37
|
<lens0021_>
|
$out->enableOOUI() loads 'oojs-ui-core.styles', 'oojs-ui.styles.indicators', 'mediawiki.widgets.styles' and 'oojs-ui-core.icons'
|
|
2019-11-20 13:52:55
|
<Sohom_Datta>
|
Okay... how do I know which icons are in which bundle ?
|
|
2019-11-20 13:53:25
|
<lens0021_>
|
Could you try `$out->addModuleStyles( [ 'oojs-ui.styles.icons-moderation' ] );`? but I not sure...
|
|
2019-11-20 13:54:04
|
<Sohom_Datta>
|
Ah... thanks
|
|
2019-11-20 13:54:15
|
<Sohom_Datta>
|
That worked.. :)
|
|
2019-11-20 13:55:28
|
<lens0021_>
|
I has searched in codes and found https://github.com/wikimedia/oojs-ui/blob/c9d3a6d/demos/pages/icons.js#L78
|
|
2019-11-20 13:55:30
|
<lens0021_>
|
and https://github.com/wikimedia/mediawiki/blob/c656980/resources/Resources.php#L2978-L2981
|
|
2019-11-20 13:55:58
|
<lens0021_>
|
:)
|
|
2019-11-20 15:00:20
|
<wm-bot>
|
Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2019-11-20 15:50:18
|
<wm-bot>
|
Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2019-11-20 15:52:34
|
<mainframe98>
|
Hi, I've got a quick question before the Technical Advice IRC meeting starts: I uploaded new patch sets to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/549127 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/544296, yet Jenkins does not seem to activate and none of the changes show up on
|
|
2019-11-20 15:52:35
|
<mainframe98>
|
https://integration.wikimedia.org/zuul/. Is something broken? For the CirrusSearch change, Cindy-the-browser-test-bot did run however.
|
|
2019-11-20 15:54:09
|
<dcausse>
|
mainframe98: lemme check, (and thanks for working on this by the way! :)
|
|
2019-11-20 16:04:54
|
<lens0021_>
|
aren’t there any hosts? I have a question
|
|
2019-11-20 16:05:07
|
<MMK21Games>
|
it should have started
|
|
2019-11-20 16:05:17
|
<MMK21Games>
|
its 5
|
|
2019-11-20 16:05:24
|
<MMK21Games>
|
i mean 4
|
|
2019-11-20 16:05:27
|
<MMK21Games>
|
UTC
|
|
2019-11-20 16:05:58
|
<MMK21Games>
|
Pining @wm-bot
|
|
2019-11-20 16:06:07
|
<AntiComposite>
|
wm-bot doesn't announce the beginning
|
|
2019-11-20 16:06:24
|
<mainframe98>
|
Nobody is listed on https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting
|
|
2019-11-20 16:06:25
|
<AntiComposite>
|
I don't know if we have any hosts today, but if you have a question, feel free to ask
|
|
2019-11-20 16:08:43
|
<lens0021_>
|
ok, thanks. I hope to know how manage Phan to include vendor dependencies in a correct way.
|
|
2019-11-20 16:09:17
|
<lens0021_>
|
I am working on a task: https://phabricator.wikimedia.org/T237609
|
|
2019-11-20 16:12:53
|
<lens0021_>
|
when I executed Phan on my system, it seems to be only analyse `${MW_INSTALL_PATH}/vendor` even though my patch require vendor of the extension.
|
|
2019-11-20 16:17:58
|
<lens0021_>
|
is Phabricator the better place to ask my question?
|
|
2019-11-20 16:27:37
|
<MMK21Games>
|
had to restart my computer
|
|
2019-11-20 17:00:48
|
<lens0021_>
|
I have another question, it is simpler.
|
|
2019-11-20 17:01:15
|
<lens0021_>
|
is `recheck` only permitted for users who have a right?
|
|
2019-11-20 17:01:27
|
<lens0021_>
|
(in gerrit)
|
|
2019-11-20 17:04:30
|
<Lucas_WMDE>
|
I think it’s allowed for the same people whose changes also get checked automatically on upload?
|
|
2019-11-20 17:04:33
|
<Lucas_WMDE>
|
i. e. whitelisted ones
|
|
2019-11-20 17:04:51
|
<Lucas_WMDE>
|
https://www.mediawiki.org/wiki/Continuous_integration/Whitelist
|
|
2019-11-20 17:05:58
|
<lens0021_>
|
oh, I see, thank you!
|
|
2019-11-20 17:06:27
|
<hauskater>
|
Yup, the bot will only listen to whitelisted users
|