[07:25:22] 3Services, operations, MediaWiki-Core-Team: Set warning thresholds for average cluster utilization - https://phabricator.wikimedia.org/T76306#939262 (10Joe) I think having warnings/alarms for capacity planning completely wrong on multiple levels. Monitoring alerts are for immediate intervention - monitoring the... [07:26:00] 3Services, ops-core, MediaWiki-Core-Team: Set warning thresholds for average cluster utilization - https://phabricator.wikimedia.org/T76306#939263 (10Joe) p:5Triage>3Low [09:53:03] 3operations, MediaWiki-Core-Team: Come up with key performance indicators (KPIs) - https://phabricator.wikimedia.org/T784#939414 (10fgiunchedi) p:5Triage>3High [14:55:15] <_joe_> manybubbles: habemus java [14:55:24] ? [14:55:42] ah! [14:55:42] <_joe_> java 8 [14:55:45] I saw [14:55:47] <_joe_> I packaged it [14:55:50] cool [14:55:59] <_joe_> I never looked inside the java package [14:56:04] Probably wise [14:56:16] jdk 8, right? [14:56:19] <_joe_> it's awful. Almost as bad as my old oracle java packages :) [14:56:22] <_joe_> yep [14:56:46] <_joe_> manybubbles: not in apt for now, I'd install it on einsteinium alone for now [14:57:30] sorry! - well, yeah - dump it on einsteinium as an option. I believe he's still on tp2.X so can't use it yet but it'll be great to have [14:57:48] I can try to install it locally and run the titan 0.9 (tinkerpop 3) test cases [15:01:14] <_joe_> mh that makes sense [15:01:17] <_joe_> so lemme upload it [15:50:07] 3MediaWiki-Core-Team: Investigate OrientDB for WDQ - https://phabricator.wikimedia.org/T75813#939922 (10Joe) As stated in T84902, capella.codfw.wmnet and haedus.codfw.wmnet are available as test hosts on which you have full sudo rights. [15:51:20] 3wikidata-query-service, MediaWiki-Core-Team: Investigate OrientDB for WDQ - https://phabricator.wikimedia.org/T75813#939933 (10Joe) [16:38:58] <_joe_> manybubbles: java8 is on apt.wikimedia.org [16:39:08] <_joe_> so if you want to try it, be my guest [16:39:11] _joe_: thanks! I'll give tp a shot [16:43:29] its testing.... [16:46:45] 3MediaWiki-Page-protection, MediaWiki-Core-Team: Protected pages from creation don't show the "change protection" link and the current protection level - https://phabricator.wikimedia.org/T85108#940025 (10Melos) [16:55:38] <_joe_> manybubbles: I remember you saying that arangodb had some issues. but I can't remember which [17:19:04] manybubbles: I saw this before: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Less_user_friendly_search_of_late [17:19:08] Thought you might want to know. [17:19:10] legoktm: ping [17:27:09] 3MediaWiki-Page-protection, MediaWiki-Core-Team: Protected pages from creation don't show the "change protection" link and the current protection level - https://phabricator.wikimedia.org/T85108#940132 (10Aklapper) Did this work before? If yes, any idea when this broke? [17:52:25] hoo: pong [17:53:17] legoktm: Your patch that moved move logic out of title caused me quite a headache [17:53:34] :/ [17:53:52] did it break something? [17:53:59] yep [17:54:06] see the bug that just ran through this channel [17:54:12] the root cause is a bit nasty [17:54:40] the protection one? [17:54:48] oh, because I changed that function and made it public? :/ [17:55:03] Yep, that broke [17:55:15] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Investigate Titan for WDQ - https://phabricator.wikimedia.org/T1095#940159 (10JanZerebecki) [17:55:53] 3MediaWiki-Page-protection, MediaWiki-Core-Team: Protected pages from creation don't show the "change protection" link and the current protection level - https://phabricator.wikimedia.org/T85108#940162 (10Aklapper) @Melos: Why was "MediaWiki-CoreTeam" added here as a project? [17:56:06] legoktm: I think my patch is almost there :) [17:56:15] 3MediaWiki-Core-Team, Wikidata, wikidata-query-service: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#798960 (10JanZerebecki) [18:00:57] <_joe|meeting> manybubbles: are we not doing the meeting today? [18:01:45] * _joe|meeting was hoping in a "yes" :P [18:06:29] legoktm: https://gerrit.wikimedia.org/r/181423 [18:06:42] I threw out other garbage while on it [18:08:07] I think there were other things that called Title::getTitleProtection() with the b/c code [18:08:19] wouldn't it be easier to just fix the protection form? [18:08:20] and you removed that? [18:08:30] yeah, I centralized the b/c into one function [18:08:51] oh for ... sake [18:09:11] Can we have a non-deprecated version, then? [18:09:41] wouldn't it be easier to just fix the protection form? < You mean adopting it to deprecated input? [18:10:50] um, I'm confused [18:10:55] yeah, I centralized the b/c into one function << Doesn't seem to be the case [18:11:08] 'sysop' and 'autoconfirmed' are deprecated [18:11:10] $ grep -r "'editprotected'" includes/ | wc -l [18:11:10] 13 [18:11:13] that change broke on-wiki stuff too [18:11:15] https://en.wikipedia.org/w/index.php?title=Module:Effective_protection_level&diff=639072983&oldid=625761441 [18:11:15] on both master and wmf4 [18:11:40] jackmcbarn: Why don't you create bugs for stuff like that? [18:11:51] hoo: until now, i assumed it was my fault [18:12:04] (i.e. that it was supposed to do that, and just had never been tested with SALT) [18:13:10] um [18:13:14] hmm [18:13:25] level should be 'editprotected' and 'editsemiprotected' [18:13:45] edit-protection doesn't use those levels though [18:14:01] it doesn't??? [18:14:06] no [18:14:13] at least not on enwiki [18:15:02] in Title::checkPageRestrictions() [18:15:07] // Backwards compatibility, rewrite sysop -> editprotected [18:15:07] if ( $right == 'sysop' ) { [18:15:07] $right = 'editprotected'; [18:15:07] } [18:15:39] yes, but that's analogous to doing it in the page-move logic [18:16:31] i.e. {{PROTECTIONLEVEL:edit|Main Page}} returns "sysop" not "editprotected" [18:16:54] * required. Note that restriction levels are normally user rights, but 'sysop' [18:16:54] * and 'autoconfirmed' are also allowed for backwards compatibility. These should [18:16:54] * be mapped to 'editprotected' and 'editsemiprotected' respectively. [18:17:56] legoktm: what the hell [18:18:08] it saved autoconfirmed in the DB for the protect I just did on master [18:18:37] and then it's mapping it to 'editsemiprotected' before checking your permissions probably. [18:18:56] i think the database gets whatever's in wgRestrictionLevels [18:19:02] and that's also what PROTECTIONLEVEL spits out [18:19:20] so if autoconfirmed and sysop really are deprecated, we should fix https://noc.wikimedia.org/conf/highlight.php?file=InitialiseSettings.php to not use them [18:25:43] legoktm: Ok, threw it all over now [18:26:46] oh [18:27:04] now I know why the protection stuff was using the bc stuff [18:27:06] oh that sucks so hard [18:27:46] Allow only users with "editsemiprotected" permission [18:27:54] that's how the form looks if not using the b/c stuff [18:27:56] can work around taht [18:28:51] yes, that's a simple message change i think [18:32:15] bd808: How do you avoid sync-dir outputting a log message to #wikimedia-operations? Or at least suppress the "Synchronized some/path/" bit? [18:32:38] uhh... let me look [18:34:02] anomie: DOLOGMSGNOLOG=1 sync-file... [18:34:23] yeah that. DOLOGMSGNOLOG in env set to something [18:34:30] legoktm, bd808: Thanks! [18:35:22] https://github.com/wikimedia/mediawiki-tools-scap/blob/master/scap/cli.py#L77-L80 [18:36:08] There should probably be a cli flag for that too. I think g.reg filed a feature request for that at some point [18:36:39] Yeah, I checked --help and didn't see anything [18:36:54] $DOLOGMSGNOLOG [18:37:01] anomie: ^ [18:40:23] 3MediaWiki-Core-Team, wikidata-query-service: Deploy a Wikidata complex query service into production - https://phabricator.wikimedia.org/T85159#940222 (10RobLa-WMF) 3NEW [18:48:35] 3MediaWiki-Core-Team, wikidata-query-service: Deploy a Wikidata complex query service into production - https://phabricator.wikimedia.org/T85159#940247 (10RobLa-WMF) [19:00:20] legoktm: *sigh* [19:00:23] more and more things to change [19:00:28] but I'm starting to see light [19:04:27] :/ [19:04:29] :D [19:05:17] legoktm: I need to write some tests, but my composer merge plugin is working -- https://github.com/bd808/wip-composer-merge-plugin [19:05:33] ooh :D [19:05:47] when I get tests for it I'll transfer to wikimedia and publish it [19:06:22] then we can make core's composer.json automagically grab things from extensions and allow a "local" file too [19:06:44] * bd808 read way too much composer source code over the weekend [19:07:52] Why would you need to prevent sync logging? :/ [19:08:02] Krenair: security patches [19:13:36] legoktm: have fun reviewing: https://gerrit.wikimedia.org/r/181423 [19:13:47] I didn't test my changes to MovePage [19:13:51] btw [19:14:08] yippe :< [19:14:40] bd808, oh, okay [19:14:57] +» /** [19:14:57] 64 +» * @param WikiPage [19:14:58] 65 +» */ [19:14:58] 66 +» private $mArticle; [19:15:02] niceeeeee [19:15:16] though, I'm pretty sure that's actually an Article object. [19:15:26] csteipp, speaking of security... is there a reason that T76686 is still private, despite being fixed on wednesday? [19:16:16] Krenair: I haven't kept up with email. If the patch went out, Markus is supposed to make it public. I'm not sure if he's waiting on something or not. [19:16:25] I think it was still private due to https://phabricator.wikimedia.org/T84952 [19:16:25] legoktm: Oh, very possible [19:16:33] the patch went out on wednesday [19:17:01] it should be fine to make it public now imo [19:17:31] legoktm: Uh, why? [19:17:46] 63 68 » function __construct( Article $article ) { [19:17:46] 64 69 » » // Set instance variables. [19:17:46] 65 70 » » $this->mArticle = $article; [19:18:01] but why should it be public? [19:18:40] It probably shouldn't. [19:19:15] Ok, fixed that comment now [19:19:19] away for food [19:26:38] 3MediaWiki-JobQueue, ops-core, MediaWiki-Core-Team: Establish monitoring thresholds for job queue - https://phabricator.wikimedia.org/T79687#940286 (10RobLa-WMF) a:5RobLa-WMF>3None [20:03:06] 3MediaWiki-Page-protection, MediaWiki-Core-Team: Protected pages from creation don't show the "change protection" link and the current protection level - https://phabricator.wikimedia.org/T85108#940376 (10Legoktm) @hoo tracked this down to a regression in my MovePage patch. [20:05:29] hoo: I'm going to fix up your patch so it'll pass tests [20:07:13] legoktm: Oh, didn't realize they were failing... go ahead [20:10:42] 3Services, MediaWiki-Core-Team: RFC: Optionally support passing in urls / paths as arrays of path segments in VirtualRESTService - https://phabricator.wikimedia.org/T85163#940380 (10GWicke) 3NEW [20:23:12] legoktm: Looks fine, but I saw something which I would like to change [20:24:24] ok, go ahead :) [20:28:23] 3Services, MediaWiki-Core-Team: RFC: Optionally support passing in urls / paths as arrays of path segments in VirtualRESTService - https://phabricator.wikimedia.org/T85163#940389 (10GWicke) [20:28:47] 3Services, MediaWiki-Core-Team: RFC: Optionally support passing in urls / paths as arrays of path segments in VirtualRESTService - https://phabricator.wikimedia.org/T85163#940380 (10GWicke) [20:29:31] 3Services, MediaWiki-Core-Team: RFC: Optionally support passing in urls / paths as arrays of path segments in VirtualRESTService - https://phabricator.wikimedia.org/T85163#940380 (10GWicke) [20:42:26] legoktm: arghghg, there's more -.- [20:43:06] :< [20:43:29] Title is terrible :P [20:43:49] not even in title [20:43:54] :< [20:49:27] legoktm: According to what I can see from i18n messages, we got them all, now [20:52:51] SMalyshev: titan tests don't pass on my system any way - too many open files! [20:54:13] manybubbles: hmm... never run the tests actually. but I guess you can bump it. maybe it's this one: http://s3.thinkaurelius.com/docs/titan/0.5.2/reindex.html#_cassandra_reindex_mappers_fail_with_too_many_open_files [20:55:24] SMalyshev: meh - I'll try again tomorrow - need to start your stuff again. I'll try and make something I can send as an issue if I can reproduce it [21:10:08] https://integration.wikimedia.org/ci/job/mediawiki-core-npm/3354/console meh [21:21:59] 3Mobile-Web, Services, MediaWiki-API, MediaWiki-Core-Team: Expose page properties as an API - https://phabricator.wikimedia.org/T78737#940536 (10Anomie) [21:39:44] ^d: did you know Taylor has a christmas album??? :D [21:40:12] http://musicbrainz.org/release-group/b6ba14c4-b8c4-3eb9-a562-dfb2f02181e8 [21:41:04] <^d> I think we need to find you an intervention program or something :p [21:48:34] anomie: heheh :) [21:50:13] 3MediaWiki-extensions-Renameuser, Wikimedia-General-or-Unknown, MediaWiki-Core-Team: Local rename of Nonoh@ruwiki failed midway through - https://phabricator.wikimedia.org/T85041#940593 (10Legoktm) Deleted the row manually, and filed T85042 for adding more debugging info. [21:50:20] 3MediaWiki-extensions-Renameuser, Wikimedia-General-or-Unknown, MediaWiki-Core-Team: Local rename of Nonoh@ruwiki failed midway through - https://phabricator.wikimedia.org/T85041#940595 (10Legoktm) 5Open>3Resolved a:3Legoktm [21:53:25] manybubbles: getting access error trying to see https://phabricator.wikimedia.org/T84793 [21:53:28] says Members of the project "WMF-NDA" can take this action. [21:53:38] who I should talk to to give me the permissions? [21:54:08] uh, lets see, NDA is actually an ldap group.... [21:54:13] <^d> No, not that. [21:54:18] ^d: your online! [21:54:21] <^d> nda in phab isn't ldap. [21:54:23] <^d> i shouldn't be :p [21:54:24] ah [21:54:44] because non-ldap users have nda? [21:54:57] <^d> because phab ldap doesn't pull ldap grou [21:55:00] <^d> ps [21:55:39] <^d> SMalyshev: I have the rights to give it to you, not sure if I have permission. Find out and I'm more than happy to give it to you. [21:56:18] so, how I find that out? [21:56:56] <^d> Let's ask andre. [21:57:36] * ^d is asking in another channel [21:59:02] <^d> SMalyshev: "ask ops" [22:00:53] ^d: you mean #wikimedia-operations? [22:01:06] <^d> I think we need to file something in Phab, sec. [22:01:31] <_joe|off_> SMalyshev: you whould be in WMF-NDA btw [22:01:56] _joe|meeting_: I have no idea, how could I check? [22:02:33] <_joe|meeting_> SMalyshev: ask some ops in the right timezone, or open a ticket in "operations" and in "phabricator" [22:02:41] <^d> SMalyshev: https://phabricator.wikimedia.org/T85170 [22:02:49] <_joe|meeting_> SMalyshev: if chasemp is around, he is the person to ask to [22:03:02] ^d: ok, thanks [22:04:58] <^d> yw [22:07:56] <^d> manybubbles: Oh btw totally unrelated, both of my Elastic improvements to Phab landed this afternoon. [22:09:52] 3Scrum-of-Scrums, Security-Reviews, LabsDB-Auditor, MediaWiki-Core-Team: Manually verify whitelisted.yaml / graylisted.yaml to ensure completeness - https://phabricator.wikimedia.org/T78730#940623 (10Anomie) [22:11:07] csteipp, did you see https://phabricator.wikimedia.org/T787 ? [22:12:18] manybubbles, there is a 'nda' group in ldap. phabricator's WMF-NDA group is not linked to it. [22:14:26] 3Librarization, MediaWiki-Core-Team: Create a wiki page documenting a good composer.json file - https://phabricator.wikimedia.org/T76502#940628 (10bd808) 5Open>3Resolved lgtm [22:15:47] <^d> bd808: Next step from ^ would be "what does an ideal library look like?" [22:15:53] 3MediaWiki-Core-Team, Wikidata, wikidata-query-service: Evaluate Titan as graph storage/query engine for Wikidata Query service - https://phabricator.wikimedia.org/T76373#940634 (10Smalyshev) [22:15:56] <^d> We have skeleton extensions, a skeleton library would be nice. [22:16:24] ^d: yeah that would be nice to add somewhere [22:16:52] ^d: are you "not really here"? /me doesn't see you in team meeting [22:17:20] * ^d shouldn't be here [22:17:23] <^d> i'm on vacation! [22:17:35] :) that's what I thought [22:17:52] wassat? [22:18:35] Reedy: It's like when your internet crashes and you have to deal with the real world I think [22:18:40] 3Language-Engineering, MediaWiki-API, MediaWiki-Core-Team: API: Allow for documenting individual values of 'prop' parameters - https://phabricator.wikimedia.org/T77930#940648 (10Anomie) 5Open>3Resolved [22:19:01] <^d> mostly like a normal day only without a terminal or editor open [22:19:21] <^d> and i decline meetings [22:23:45] 3Librarization, MediaWiki-Core-Team: Update [[mw:Composer]] to include information about usage with libraries - https://phabricator.wikimedia.org/T85172#940652 (10Legoktm) 3NEW [22:27:08] 3MediaWiki-extensions-Renameuser, SUL-Finalization, MediaWiki-Core-Team: Renameuser has no debug logging - https://phabricator.wikimedia.org/T85042#940662 (10Legoktm) a:3Legoktm [22:27:18] 3MediaWiki-extensions-CentralAuth, SUL-Finalization, MediaWiki-Core-Team: Re-enable $wgCentralAuthAutoMigrate = true - https://phabricator.wikimedia.org/T78727#940665 (10Legoktm) a:3Legoktm [22:27:39] 3MediaWiki-Core-Team, Librarization, MediaWiki-General-or-Unknown: [Regression] MediaWiki should detect absent or outdated vendor - https://phabricator.wikimedia.org/T74777#940667 (10bd808) [22:28:12] 3wikidata-query-service, MediaWiki-Core-Team: Investigate Titan supernode issues - https://phabricator.wikimedia.org/T85173#940670 (10Manybubbles) 3NEW a:3Manybubbles [22:28:45] 3MediaWiki-Core-Team: Validate Java 8 package - https://phabricator.wikimedia.org/T85174#940678 (10Manybubbles) 3NEW [22:29:03] 3wikidata-query-service, MediaWiki-Core-Team: Validate Java 8 package - https://phabricator.wikimedia.org/T85174#940678 (10Manybubbles) a:3Manybubbles [22:40:04] 3Wikimedia-Blog, MediaWiki-Core-Team: Finish up blog post for Cirrus - https://phabricator.wikimedia.org/T85176#940725 (10Manybubbles) 3NEW a:3Manybubbles [22:41:14] <^d> I'm out for reals now. Later folks. [22:41:19] <^d> Don't burn the place down while I'm gone [22:41:25] o/ [22:46:14] 3MediaWiki-Core-Team: Cut Elasticsearch 1.4 Compatible Release of Wikimedia-Extra plugin - https://phabricator.wikimedia.org/T76873#940751 (10bd808) 5Open>3Resolved [22:46:21] 3MediaWiki-Search, MediaWiki-Core-Team: Finding js and css pages in autocomplete causes it to fail. - https://phabricator.wikimedia.org/T78721#940752 (10bd808) 5Open>3Resolved [22:46:27] 3CirrusSearch, MediaWiki-Core-Team: Release wikimedia-extra to pick up "Degrade large phrase queries" - https://phabricator.wikimedia.org/T76875#940753 (10bd808) 5Open>3Resolved [22:46:36] 3MediaWiki-Core-Team, Librarization, MediaWiki-General-or-Unknown: Create a general UDP transport class instead of abusing wfErrorLog - https://phabricator.wikimedia.org/T74572#940754 (10bd808) 5Open>3Resolved [22:46:42] 3CirrusSearch, MediaWiki-Core-Team: Add support for taking multiple locks in pool counter. - https://phabricator.wikimedia.org/T77923#940756 (10bd808) 5Open>3Resolved [22:46:43] 3CirrusSearch, MediaWiki-Core-Team: Add per user concurrent search request limiting - https://phabricator.wikimedia.org/T76497#940757 (10bd808) [22:46:49] 3MediaWiki-Core-Team: Retest geo indexes in Orient - https://phabricator.wikimedia.org/T84975#940758 (10bd808) 5Open>3Resolved [22:46:56] 3MediaWiki-Core-Team: Fix jobrunner coordinator OOMs - https://phabricator.wikimedia.org/T1140#940759 (10bd808) 5Open>3Resolved [22:47:03] 3MediaWiki-Core-Team, wikidata-query-service: Deploy a Wikidata complex query service into production - https://phabricator.wikimedia.org/T85159#940761 (10bd808) [22:47:06] 3wikidata-query-service, MediaWiki-Core-Team: Investigate OrientDB for WDQ - https://phabricator.wikimedia.org/T75813#940760 (10bd808) 5Open>3Resolved [23:15:45] 3MediaWiki-Core-Team, Librarization, MediaWiki-General-or-Unknown: [Regression] MediaWiki should detect absent or outdated vendor - https://phabricator.wikimedia.org/T74777#940815 (10bd808) What we have implemented so far for this: - Special handling for when \Psr\Log\LoggerInterface is missing as this breaks t... [23:28:18] 3MediaWiki-Installer, MediaWiki-Core-Team, Librarization: composer.json should be useable by WMF, core and extensions - https://phabricator.wikimedia.org/T67188#940850 (10bd808) [23:29:29] 3MediaWiki-Core-Team, Librarization: File upstream bug with composer about the autoloader being slow - https://phabricator.wikimedia.org/T85182#940855 (10Legoktm) 3NEW [23:31:04] 3MediaWiki-Core-Team, Librarization: xhprof for MW - https://phabricator.wikimedia.org/T759#940883 (10bd808) a:3bd808 [23:32:26] 3MediaWiki-General-or-Unknown, MediaWiki-Core-Team, Librarization: Create a general UDP transport class instead of abusing wfErrorLog - https://phabricator.wikimedia.org/T74572#940887 (10bd808) [23:33:20] 3MediaWiki-Core-Team, MediaWiki-Maintenance-scripts, Librarization: Create maintenance script to validate composer.lock against composer.json - https://phabricator.wikimedia.org/T77388#940891 (10bd808) [23:36:47] 3MediaWiki-Core-Team, Librarization: Get PSR-3 patches merged and in use on WMF cluster - https://phabricator.wikimedia.org/T844#940907 (10bd808) [23:38:53] 3MediaWiki-Core-Team, Librarization: Create RFC for library extraction (PHP & javascript) practices - https://phabricator.wikimedia.org/T1017#17654 (10bd808)