[00:03:13] AaronSchulz: So doing a select that joins against revision and page... $dbr->select( array( 'change_tag', 'revision', 'page', ), [00:03:17] Bad idea? [00:14:35] need more info ;) [00:46:23] 3MediaWiki-Core-Team, MediaWiki-extensions-ContentTranslation, ContentTranslation-Deployments: Content Translation Beta Feature security review - https://phabricator.wikimedia.org/T85686#967636 (10csteipp) Although the API will throttle and enforce blocks when a user actually publishes a translation, I'm a littl... [00:46:51] bd808: i made arc-lamp more 'library-like': [00:47:21] does it now meet the threshold for composer use, or does it still make sense to think of it as a file you copy/paste into your codebase? (i have no strong feelings either way, so be honest) [00:49:07] We can give it a composer manifest for sure. I was going to play with it in mw-v tomorrow and see how far I can take it to being "automated" [01:02:28] coooool [01:02:32] thanks! [01:17:41] ori: https://gerrit.wikimedia.org/r/#/c/184004/1 [01:58:09] AaronSchulz / AaronS: i got as far as ParserFunctions, will do the rest later [09:39:58] 3MediaWiki-Core-Team, ContentTranslation-Deployments, MediaWiki-extensions-ContentTranslation: Content Translation Beta Feature security review - https://phabricator.wikimedia.org/T85686#968117 (10santhosh) @csteipp, - Drafts are private to the creator. User A cannot access draft by User B even if the user ge... [11:40:20] 3Librarization, MediaWiki-Core-Team: Make MWException handle non-MW exceptions better - https://phabricator.wikimedia.org/T76652#968224 (10Nemo_bis) 5Open>3stalled https://gerrit.wikimedia.org/r/#/q/topic:kill-mwexception,n,z Marking stalled; per Krinkle's comment. [11:42:39] 3Librarization, MediaWiki-Core-Team: Make MWException handle non-MW exceptions better - https://phabricator.wikimedia.org/T76652#968227 (10Nikerabbit) I wrote some complaints about the process in https://gerrit.wikimedia.org/r/184048. Having as much as possible of the process in public is important, as are small... [13:37:21] Why are we throwing out MWException everywhere? Did I miss something? [14:05:02] I was wondering the same thing [15:20:18] hoo, Krenair, https://phabricator.wikimedia.org/T76652 ? [17:11:23] 3MediaWiki-Core-Team: Central Code Repository - https://phabricator.wikimedia.org/T1238#968509 (10Ricordisamoa) Duplicate of/related to {T66475}? [17:31:05] legoktm: ping [17:51:29] legoktm: https://gerrit.wikimedia.org/r/184135 [17:51:34] I rather urgently needed reviews on that [17:52:05] Some people which are now trying to unify their accounts get pawned by that... :/ [17:54:44] hoo|away: looks sane at least [18:10:06] Reedy: Deploy today? [18:10:15] If it's breaking shit, then yeah [18:10:23] I've jsut removed a user from the list of people affected, because they couldn't come into their account [18:10:55] :( [18:11:00] Want to do it, or shall I? [18:11:26] I can do it, but +1 would be nice [18:11:55] I thought I did [18:12:03] [17:54:41] (CR) Reedy: [C: 1] Bug54847.php: Replace removed CentralAuthUser::getPasswordHash [mediawiki-config] - https://gerrit.wikimedia.org/r/184135 (owner: Hoo man) [18:20:24] Reedy: It would be nice if we were to log fatals again [18:20:56] Jan 10 10:01:59 mw1217: #012Fatal error: Call to undefined method CentralAuthUser::getPasswordHash() in /srv/mediawiki/wmf-config/Bug54847.php on line 161 [18:21:01] hhvm log [18:21:05] but not in the fatal log [19:36:31] Reedy: Still here? :D [19:36:42] It's actually not funny... but well, it is funny [19:36:44] I screwed [21:21:16] legoktm[NE]: What's NE? [21:21:38] Oh... saw my nice screw ups earlier...? :/ [21:22:59] hoo: New England Patriots, it's American football :P [21:23:15] I just got online, what happened? [21:23:16] :D [21:23:31] My CentralAuth changed broke the Bug54...php thing [21:23:35] then I "fixed" it [21:23:43] but the new method is protected [21:23:51] >.< [21:23:53] so I then fixed it again after maybe two hours [21:24:02] if anyone wants to look at confirm edit.... https://phabricator.wikimedia.org/T86453 [21:24:07] otherwise i'll look more tomororw [21:24:16] multiple issues [21:24:18] I think we just need to migrate that to core's password reset system [21:24:19] I grepped all extension for that function use.. :P [21:24:22] I think [21:25:15] aude: I think that's actually two bugs [21:25:46] * should be two bugs [21:25:46] i am splitting them up [21:25:53] thought they were one, but indeed are two [21:27:17] split [21:28:43] aude: Not sure how I would actually solve the Wikibase bug [21:28:54] we could have a nicer error message, but taht's about it [21:29:04] ui integration wont be anywhere near easy [21:29:21] Maybe we want to just disable the captchas for Wikidata NS0 [21:29:58] needs more investigating [21:30:07] also why i get no error message? (empty) [21:30:20] might be yet another bug [21:31:16] We probably mess with the returns to our editfiltermerged hook stuff [21:31:19] just a guess [21:31:26] maybe