[06:07:52] 6MediaWiki-Core-Team, 10GlobalUserPage, 5Patch-For-Review: user pages with an additional namespace prefix appear to be existent as global user pages on Meta - https://phabricator.wikimedia.org/T91029#1072869 (10Legoktm) [06:44:34] 6MediaWiki-Core-Team, 10Deployment-Systems, 10Librarization, 6Security, 5Patch-For-Review: Have a check for reported security issues in dependencies - https://phabricator.wikimedia.org/T74193#1072879 (10Legoktm) 5Open>3Resolved https://gerrit.wikimedia.org/r/193057 If there are any other repos commi... [06:58:53] 6MediaWiki-Core-Team, 10CirrusSearch: CirrusSearch: Ignore ( and ) in prefix search - https://phabricator.wikimedia.org/T89201#1072892 (10FriedhelmW) >>! In T89201#1067113, @Manybubbles wrote: > I suppose it'd be better to require the ( if it is there but make it optional. I think this requires two index fil... [13:12:01] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: RDF Issues - https://phabricator.wikimedia.org/T90119#1073293 (10Manybubbles) [13:12:02] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: Prefix vs Suffix - https://phabricator.wikimedia.org/T90121#1073290 (10Manybubbles) 5Open>3Resolved a:3Manybubbles Resolved. Use whatever you want just try to make the IRIs resolve. We believe prefixes will be more convenient to u... [13:26:58] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: RDF Issues - https://phabricator.wikimedia.org/T90119#1073316 (10Manybubbles) Adding this here for posterity: It seems like the primary objection to RDR is vendor lock in. Its a BlazeGraph specific thing and would have to be reimplement... [13:42:48] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: Value representation - https://phabricator.wikimedia.org/T90123#1073326 (10Manybubbles) One proposal is to use the "center" value as the actual value and use reification (RDR or otherwise) to add stuff like precision and error to the resu... [13:57:29] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: Operational issues - https://phabricator.wikimedia.org/T90103#1073359 (10Manybubbles) [13:57:30] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: Update performance - https://phabricator.wikimedia.org/T90114#1073357 (10Manybubbles) 5Open>3Resolved After talking to @Thompsonbry.systap, I'm reasonably confident we can handle the update rate we're seeing. I think its important th... [13:59:43] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: Operational issues - https://phabricator.wikimedia.org/T90103#1073362 (10Manybubbles) [13:59:44] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: Machine Sizing/Shaping - https://phabricator.wikimedia.org/T90116#1073360 (10Manybubbles) 5Open>3Resolved I'm happy enough with what I know now for this not to block the decision. Generally we know we'll want SSDs and RAM. Probably... [14:58:02] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: RDF Issues - https://phabricator.wikimedia.org/T90119#1073420 (10Manybubbles) [15:32:19] <^d> bd808: Speaking of vagrant. I went to a talk last night by Ryan at Lyft. They use vagrant + docker for their development and CI environments [15:32:46] <^d> So a dev's laptop runs vagrant, and then salt spins up docker containers in it for each "service" you need [15:32:46] I bookmarked the youtube stream yesterday but haven't watched yet [15:32:57] *nod* [15:33:07] ^d: btw, no beta work today. hardening toollabs atm. [15:33:19] (another hardware(?) related labs outage today) [15:33:20] <^d> I saw the e-mails. Priorities man :) [15:39:24] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: RDF Issues - https://phabricator.wikimedia.org/T90119#1073580 (10Manybubbles) [15:39:35] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: RDF Issues - https://phabricator.wikimedia.org/T90119#1052919 (10Manybubbles) [15:47:57] bd808: Any word on that ApiResult/Wikidata thing? [15:48:21] argh. I knew I forgot to do something [15:50:43] * bd808 writes an email and sets a reminder [15:51:49] <^d> Holy crap I'm basically done [15:51:50] <^d> https://phabricator.wikimedia.org/P339 [15:52:18] death to explicit profiling! [15:52:48] anomie: actually I think I'm just going to open a phab task first and then follow up with an email [15:52:52] <^d> A lot of those are probably not all that interesting and can be dropped. [15:52:58] bd808: Works for me [15:53:02] <^d> The rest can be turned into ProfileSections if they must [15:53:41] <^d> bd808: The common thread I'm seeing is SQL, HTTP request, shelling out. I know we've got explicit profiling of the first one. [15:54:02] <^d> We should make sure we've got good profiling of HTTP requests and shell requests and then basically nobody needs a reason to profile anymore [15:54:48] *nod* [16:07:54] <^d> bd808: For http requests, what about giving it a profiling parameter like we do with sql? [16:08:04] anomie: task and email sent. Sorry I didn't do that on Monday when you asked [16:08:07] <^d> (a calling method) [16:08:15] Not a big deal [16:10:28] ^d: sounds reasonable. I like to see repeated patterns [16:13:24] <^d> Only thing I don't like is that it would require adding a ton of extra parameters to profiling what's currently a bare Http::get($url) call [16:13:45] <^d> You'd have to do Http::get($url, 'default', array(), __METHOD__ ) [16:14:05] hmmmm [16:14:42] <^d> Eh, Http::request() and Http::post() wouldn't be bad. It's just get() because of that historical timeout parameter [16:15:19] that signature is a bit ugly [16:16:00] pita to track down usage of [16:16:39] <^d> Not really, it's always been static. Nobody instantiates an Http object [16:16:41] facebook has a fancy parse tree aware grep for things like that. I've been meaning to figure out how to use it [16:16:44] <^d> 'Http::get' is easy [16:17:52] usage in core is tiny [16:18:28] includes/installer/Installer.php uses it wrong [16:24:20] * bd808 reads confusing email about Lyon travel booking [16:39:28] <^d> bd808: I just saw the wrong usage in Installer [16:40:44] <^d> I see enough wrong usages in extensions too. We should just deprecate that parameter as it is and figure out behavior based on what's passed [16:43:03] that should be easy enough [16:43:42] if !is_array() add to params as timeout [16:44:02] <^d> Yeah [16:59:43] <^d> calling get( $url, array(), __METHOD__ ) for the simple case ain't so bad [16:59:50] <^d> If we can merge the first change [17:09:20] <^d> AaronS, bd808: https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/core+branch:master+topic:profile-http,n,z :) [17:10:31] does anybody use the 3 args properly? [17:11:35] <^d> Not in core, lemme check exts again [17:12:18] It seems like it would be safer (but uglier) to use func_num_args() inside the function if so [17:12:39] <^d> A few, actually [17:35:59] 6MediaWiki-Core-Team, 10GlobalUserPage, 5Patch-For-Review: user pages with an additional namespace prefix appear to be existent as global user pages on Meta - https://phabricator.wikimedia.org/T91029#1073813 (10Legoktm) 5Open>3Resolved [17:37:52] <^d> bd808: You have a link to that youtube stream? [17:38:03] <^d> (also, yeah, we'll need to use func_num_args()) [17:39:05] ^d: https://www.youtube.com/watch?v=EV-PoM7BLTM [17:39:18] bad hold music! [17:40:47] Ryan starts at about 1:23:00 or so [18:03:55] <^d> Yeah heh [18:09:47] anomie: interested in https://phabricator.wikimedia.org/T88661 ? [18:10:05] $oldLinks = $this->findLinks( $title, $oldtext ); [18:10:13] I wonder why that can't use << $oldLinks = $this->getLinksFromTracker( $title ); >> [18:10:28] * anomie looks [18:11:14] 6MediaWiki-Core-Team, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), 7Performance: Improve performance of Captcha extension on edit forms - https://phabricator.wikimedia.org/T88661#1074032 (10aaron) On one branch of the $isContent check, it calls: $oldLinks = $this->findLinks( $title, $oldtext );... [18:17:16] AaronS: Looks like Ia3bb66f9 wasn't properly rebased to take into account I9529b7e8. I'll look at fixing that. [18:17:54] thanks [18:21:24] <^d> So I have an IPv6 address from comcast according to my router and all the "test your ipv6" websites. But I can't seem to traceroute6 to any domain names (eg: wikipedia.org, google.com) [18:26:28] <^d> Ah I don't think comcast's dhcp gives me IPv6 dns entries [18:33:19] AaronS: https://gerrit.wikimedia.org/r/193404 [18:48:07] Error: your composer.lock file is not up to date, run "composer update" to install newer dependencies [18:48:10] Krinkle|detached: ^ [18:52:52] <^d> AaronS: "Also the b/c code will try to set a field of an integer." <- huh? [18:53:50] $options['foo'] = $options when $options == 3 [18:54:32] <^d> Ah yes, of course [19:04:43] legoktm: I'm going to write up the wikitech-l email for AuthManager so you can focus on SUL stuff [19:16:41] 6MediaWiki-Core-Team, 10Wikidata-Query-Service: BlazeGraph Finalization: Value representation - https://phabricator.wikimedia.org/T90123#1074339 (10Jdouglas) Sounds good to me. [19:27:51] bd808: didn't I already send it? [19:28:01] * bd808 didn't see it [19:28:19] now I see it [19:28:41] wonder why it didn't show up for me before? stupid gmail [19:28:58] legoktm: thx [19:32:14] 6MediaWiki-Core-Team, 10MediaWiki-RfCs: RfC: AuthManager - https://phabricator.wikimedia.org/T91105#1074400 (10bd808) 3NEW [19:34:33] 6MediaWiki-Core-Team, 10MediaWiki-Authentication-and-authorization, 7Epic: Modernize MediaWiki authentication system - https://phabricator.wikimedia.org/T89459#1074416 (10bd808) RfC now ready for review (T91105) [19:36:01] 6MediaWiki-Core-Team, 10MediaWiki-Authentication-and-authorization, 7Epic: Modernize MediaWiki authentication system - https://phabricator.wikimedia.org/T89459#1074425 (10bd808) [19:36:03] 6MediaWiki-Core-Team, 10MediaWiki-Authentication-and-authorization: Develop use-cases & user stories for authentication system - https://phabricator.wikimedia.org/T89460#1074422 (10bd808) 5Open>3Resolved a:3bd808 Use-cases documented in [[https://www.mediawiki.org/wiki/Requests_for_comment/AuthManager|Au... [19:41:09] 6MediaWiki-Core-Team, 10MediaWiki-RfCs: RfC: AuthManager - https://phabricator.wikimedia.org/T91105#1074465 (10bd808) [19:41:10] 6MediaWiki-Core-Team, 10MediaWiki-Authentication-and-authorization, 7Epic: Modernize MediaWiki authentication system - https://phabricator.wikimedia.org/T89459#1074464 (10bd808) [20:09:41] anomie: Yeah, if vendor/ is invalidated then mediawiki can't be installed in the current system. [20:10:05] Whoever bypassed Jenkins to merge stuff in vendor should either also merge the core change or revert immediately [20:11:03] Seems it was just an unlucky race during the 2 minutes that was not in sync [20:11:06] recheck should be fine :) [20:14:19] <^d> "does anyone have an example of connecting multiple elasticsearch instances to work as a cluster?" [20:14:23] <^d> um, what? lol. [20:16:53] https://phabricator.wikimedia.org/T90303 [20:22:52] bd808: can i remove status now from https://www.mediawiki.org/wiki/Wikidata_deployment ? [20:23:27] guillom didn't like when i did that in the past because it broke some stuff [20:50:53] csteipp: https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/master/maintenance/migrateAccount.php#L178 why do we require ALL accounts to have the same confirmed email? couldn't we just migrate those that match with the picked home wiki? [20:56:31] * legoktm is going to have lunch as well [21:10:43] 6MediaWiki-Core-Team, 10MediaWiki-RfCs: RfC: AuthManager - https://phabricator.wikimedia.org/T91105#1074698 (10daniel) a:3Legoktm [21:11:09] legoktm: I think this script was meant to be run multiple times, and the next run would basically do that [21:12:40] 6MediaWiki-Core-Team, 10MediaWiki-RfCs: RfC: AuthManager - https://phabricator.wikimedia.org/T91105#1074712 (10daniel) a:5Legoktm>3bd808 [21:14:23] bd808: since you seem to know a lot about vagrant setup, can I bother you a bit more about it? [21:15:18] e.g. I'm trying to change DB server settings only for wikidata part, but only changes to ./mediawiki/LocalSettings.php seem to take effect [21:15:36] if I edit ./settings.d/wikis/wikidatawiki/LocalSettings.php nothing happens [21:16:01] ah. yes. I made that crap more confusing than it should be [21:16:12] gj bd808 [21:16:13] :) [21:16:37] also, not sure how to change DB name for wikidatawiki - it seems to just ignore one in LocalSettings [21:16:41] * bd808 waves to captain Reedy [21:17:13] so where I need to poke it to make it work? [21:17:20] SMalyshev: add you custom settings that are only for wikidatawiki to settings.d/wikis/wikidatawiki/settings.d [21:17:35] The LocalSettings files aren't used [21:17:47] which is confusing and dumb [21:18:02] hehe [21:18:14] yeah that is kind of surprising :) [21:18:36] The LocalSettings files under settings.d are the stubs created by the installer. I just keep them around to make puppet happy [21:18:57] I may actually be able to stop saving them now [21:19:33] at one point $IP/LocalSettiings.php was a symlink to the latest one the installer had created [21:19:52] but that didn't last long because of windows users [21:20:57] changing the db name will also require editing the dbConf.php file in the wikidatawiki settings directory I think [21:21:21] that file gets merged with others at runtime by the wikifarm setup in mw-vagrant [21:25:10] I wonder how badly I'm misusing oojs-ui in working on T89386 [21:25:46] anomie: MatmaRex may be able to help you determine that [21:26:43] coincidentally robla and I were just talking about ApiSandbox yesterday [21:26:53] Oh? What were you saying about it? [21:27:05] stuff, and things [21:27:11] :o [21:27:45] we were looking at https://rest.wikimedia.org/en.wikipedia.org/v1/?doc and wondering how hard it would be to do something similar for api.php [21:28:06] MatmaRex: Since you're here, is there any better way to do a multi-select than "ginormous list of checkboxes"? Also, a file upload widget? [21:28:39] I actually started poking at the library they are using to drive that interface to see if I could figure out how to mash our api spec into it [21:29:04] bd808: A page that shows basically nothing? Should be easy enough, but why? [21:29:08] bd808: ok, that worked settings-wise, but something seems to be wrong trying to use labsdb [21:29:14] anomie: really? [21:29:16] * anomie clicks on stuff and nothing happens [21:29:18] Error: 1146 Table 'wikidatawiki_p.text' doesn't exist (wikidatawiki.labsdb) [21:29:28] anomie: needs a bunch of js [21:29:30] I wonder if it's supposed to be there? locally it's there [21:29:45] anomie: https://rest.wikimedia.org/en.wikipedia.org/v1/?doc#!/Page_content/page_title__title___get [21:29:56] * anomie reloads and now it does stuff [21:30:14] SMalyshev: oh... I have no idea how to hook it to an external db [21:30:19] Meh. Looks like ApiSandbox. [21:30:31] `text` (and external storage) tables aren't available on labs [21:30:34] bd808: ok, will research that [21:30:56] SMalyshev: ^^ legoktm may have an answer for you [21:31:09] legoktm: is there any way to use labs dbs on wiki instance then? [21:31:17] anomie: multiselect - sadly, no. we have a bug to implement a "tokenizer" thingy (like phabricator has for project selection, similar to jquery.chosen too). we also have a plan to implement a wrapper for list of checkboxes like HTMLMultiSelectField as soon as someone requests it. there is a wrapper for list of radios so far :) [21:31:36] there's nothing for file upload now. [21:31:51] legoktm: or any other place that has a reasonable replica of the data? [21:31:55] SMalyshev: I haven't tried it myself, but https://github.com/liangent/mediawiki-extensions-Labs might be useful. [21:32:43] anomie: the bug is https://phabricator.wikimedia.org/T88250 [21:33:08] anomie: it does look like apisandbox but kind of shinier [21:33:26] MatmaRex: One thing I hate about Phab's thing is that there's no way to browse the list... [21:34:02] yeah [21:35:01] anomie: basically, phab implements search suggestions mith multiple choices, rather than real multiselect. both make sense, depending on the context; multiselect would've been better here [21:35:02] MatmaRex: Is there a bug for "OO.ui.DropdownWidget doesn't let you type to jump like