[00:01:41] legoktm: hey, out of curiosity [00:02:13] you wrote a bot for replacing broken links with archive.org copies a while ago, right? [00:02:16] is that running? [00:02:49] no, I only wrote a prototype [00:03:21] what was prototypal about it? (i.e., what else would need to happen for it to be production-worthy?) [00:04:54] mainly that enwp's citation templates were totally crazy and needed lots of special handling [00:05:03] there's been some standardization efforts since then [00:05:18] and supposedly citoid will help with this, but I haven't had time to look into it [00:05:36] there are some details/ideas on https://www.mediawiki.org/wiki/Archived_Pages [00:05:48] it's a really cool idea, by the way [00:06:20] yup :D [00:07:01] I think Betacommand had a fully functioning web tool for this, but his code wasn't under a free license and was using crazy regexes instead of a proper template parser [00:07:36] https://gist.github.com/legoktm/6618c305e03dc02aae01 was my prototype [00:29:20] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Message describing OAuth activities is confusing to end user (in context of Wikidata Game) - https://phabricator.wikimedia.org/T69082#1168903 (10Peteforsyth) >>! In T69082#1168572, @Anomie wrote: > Unless I've forgotten, it's not ea... [00:47:11] 6MediaWiki-Core-Team, 6Security, 5Patch-For-Review: Custom JavaScript may yield privilege escalation - https://phabricator.wikimedia.org/T85855#1168994 (10He7d3r) I assume the fix works for edit links with the URL parameter `&preview=yes` too? [00:57:29] 6MediaWiki-Core-Team, 6Security, 5Patch-For-Review: Custom JavaScript may yield privilege escalation - https://phabricator.wikimedia.org/T85855#1169023 (10csteipp) >>! In T85855#1168994, @He7d3r wrote: > I assume the fix works for edit links with the URL parameter `&preview=yes` too? I don't think edit link... [02:36:45] 6MediaWiki-Core-Team: Trying to register an account name with an interwiki prefix results in the prefix being dropped - https://phabricator.wikimedia.org/T94656#1169203 (10MrStradivarius) 3NEW [07:20:37] 6MediaWiki-Core-Team, 5Patch-For-Review: Devise caching (memcached) strategy for multi-DC mediawiki - https://phabricator.wikimedia.org/T88492#1169454 (10Gilles) >>! In T88492#1130390, @aaron wrote: > See https://gerrit.wikimedia.org/r/#/c/187074/ and https://github.com/AaronSchulz/python-memcached-relay/blob/... [07:21:36] 6MediaWiki-Core-Team, 5Patch-For-Review: Devise caching (memcached) strategy for multi-DC mediawiki - https://phabricator.wikimedia.org/T88492#1169455 (10aaron) Or just https://github.com/AaronSchulz/python-memcached-relay [08:04:45] 6MediaWiki-Core-Team, 6operations, 5Patch-For-Review: Store unsampled API and XFF logs - https://phabricator.wikimedia.org/T88393#1169498 (10fgiunchedi) looks like after removing the stray uncompressed log files and the current retention we're stable in terms of disk usage: {F107657} [08:22:38] 6MediaWiki-API-Team, 10SUL-Finalization, 5Patch-For-Review: GlobalRename tool should not list IP address of the user performing renames as 127.0.0.1 in Checkuser - https://phabricator.wikimedia.org/T94516#1169541 (10Legoktm) [08:42:52] 6MediaWiki-Core-Team, 5Patch-For-Review: Devise caching (memcached) strategy for multi-DC mediawiki - https://phabricator.wikimedia.org/T88492#1169603 (10Gilles) python-memcached-relay -> might be worth renaming that, since it also covers redis and plans to do varnish/squid too. I'm happy to review it as soon... [08:48:09] 6MediaWiki-Core-Team, 7Epic: Audit and fix extensions that call saveSettings() to lazy-set preferences when loaded - https://phabricator.wikimedia.org/T94480#1169643 (10Gilles) This looks like something I can do. What's the "right way" for these extensions to behave in regards to their preferences? [08:53:49] 6MediaWiki-Core-Team, 10MediaWiki-JobQueue: Use local jobqueue class for jobs enqueued on pages views - https://phabricator.wikimedia.org/T91819#1169652 (10Gilles) [08:54:07] 6MediaWiki-Core-Team: Add code to enable setting sticky DC cookies for POST requests - https://phabricator.wikimedia.org/T91816#1169654 (10Gilles) [08:54:51] 6MediaWiki-Core-Team: Audit cache usage to see what can be DC-local and what needs cross-DC purges - https://phabricator.wikimedia.org/T91815#1169656 (10Gilles) [08:55:21] 6MediaWiki-Core-Team, 10MediaWiki-General-or-Unknown: Augment user_touched with an in-memory field - https://phabricator.wikimedia.org/T91279#1169658 (10Gilles) [09:00:53] 6MediaWiki-Core-Team, 5Patch-For-Review: Fix various DB master warnings from dbperformance.log - https://phabricator.wikimedia.org/T92357#1169674 (10Gilles) Only patch listed above still in review: https://gerrit.wikimedia.org/r/#/c/199826/ [09:08:43] 6MediaWiki-API-Team, 10MassMessage, 10SUL-Finalization: MassMessage sent twice to local user talk - https://phabricator.wikimedia.org/T93049#1169707 (10Nemo_bis) 5Open>3stalled >>! In T93049#1165299, @Keegan wrote: > This was likely a fluke due to using a modified form of MassMessage for this task. Ok.... [09:08:44] 6MediaWiki-Core-Team, 10SUL-Finalization: Run MassMessage to contact user talk pages of all affected accounts - https://phabricator.wikimedia.org/T90820#1169709 (10Nemo_bis) [11:02:25] 6MediaWiki-Core-Team, 6Project-Creators, 15User-Bd808-Test: Create Search-Team project - https://phabricator.wikimedia.org/T94493#1169972 (10Aklapper) >>! In T94493#1167460, @bd808 wrote: > It does actually, but the addition of our custom sprint board plugin has hijacked the screen. :( [OT] Sprint is unrel... [11:03:54] 6MediaWiki-Core-Team, 10Librarization: Make MWException handle non-MW exceptions better - https://phabricator.wikimedia.org/T76652#1169981 (10Aklapper) @aaron: Please reply to T76652#951747 [12:19:44] 6MediaWiki-Core-Team, 6operations, 5Patch-For-Review: Store unsampled API and XFF logs - https://phabricator.wikimedia.org/T88393#1170145 (10Anomie) >>! In T88393#1110251, @Andrew wrote: > api-feature-usage logs: 90 days I've already said this elsewhere, but I'll put it here too so it can be found more eas... [13:10:55] AaronS: There's a Bug56269 log? ... Ok, added in Gerrit 121402 but apparently no one ever made it actually log anywhere, which makes me think "probably not" unless greg-g and ^demon|away want to have more logs to tell people to fix. I don't see any hits in archived testwiki or test2wiki logs that aren't side effects of something else being broken. [13:11:39] * anomie has a bouncer and so can make 14-hour-delayed replies now! ;) [13:41:53] <^demon|away> anomie: Yeah, looks like no one decided to log it anywhere :) [13:42:37] * miserycat lurks [13:54:18] <^demon|away> manybubbles: I merged the last Flow change for Cirrus [13:54:29] \0/ [14:32:16] Not feeling well today, going to take a sick day. [14:42:47] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 7Design, 5Patch-For-Review: keyboard Tab order in OAuth Confirm dialog starts with Cancel - https://phabricator.wikimedia.org/T64763#1170392 (10Ricordisamoa) @Jaredzimmerman-WMF it seems that the proposed patch would move the "accept" button to the left. [14:46:56] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Message describing OAuth activities is confusing to end user (in context of Wikidata Game) - https://phabricator.wikimedia.org/T69082#1170395 (10Ricordisamoa) >>! In T69082#1168903, @Peteforsyth wrote: > If I understand it correctly, the W... [16:27:09] 6MediaWiki-API-Team, 6CA-team, 6Commons, 6operations: db1068 (s4/commonswiki slave) is missing data about at least 6 users - https://phabricator.wikimedia.org/T91920#1170668 (10Aklapper) Any news / progress here? Asking as this has "Unbreak now" priority... [16:31:25] 6MediaWiki-API-Team, 6CA-team, 6Commons, 6operations: db1068 (s4/commonswiki slave) is missing data about at least 6 users - https://phabricator.wikimedia.org/T91920#1170679 (10Krenair) Given that this DB server is out of rotation, I doubt it's actually still unbreak now. We also know that there are no oth... [16:35:40] is it just me or is http://en.wikipedia.beta.wmflabs.org/wiki/Special:Preferences partially unstyled for others? [16:35:50] obviously you need to login [16:38:04] <^d> I saw something on VPT about that [16:38:22] hm, ok [16:38:32] <^d> Same, unstyled [16:38:38] <^d> No tabs, at least [16:38:53] also problems with wikidata styles on beta, but then again we deployed no code there [16:39:00] but can't reproduce the issues locally [16:39:12] new* code [16:39:30] <^d> I have tabs on prod [16:40:13] me too [16:40:22] beta sometimes has caching issues [16:40:47] * aude might not spend much time investigating and wait to see what happens on test.wikidata [16:43:42] 6MediaWiki-Core-Team, 6Project-Creators, 15User-Bd808-Test: Create Search-Team project - https://phabricator.wikimedia.org/T94493#1170705 (10Aklapper) I'd really like to see a differentiation between such a project and existing "code" projects in the team project description, as I expect a **lot** of misfile... [17:19:10] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: OAuth permission screen needs redesign for better usability and comprehension - https://phabricator.wikimedia.org/T75062#762237 (10MarkTraceur) That patch is 1) so it's easier to work with and 2) so it's more consistent across desktop and... [17:19:59] 6MediaWiki-Core-Team, 6Project-Creators, 15User-Bd808-Test: Create Search-Team project - https://phabricator.wikimedia.org/T94493#1170863 (10bd808) >>! In T94493#1170705, @Aklapper wrote: > If someone could come up with a good project description covering these concerns, that would be awesome. Planning proj... [17:58:10] 6MediaWiki-API-Team, 10SUL-Finalization: Contact accounts that were notified about potential global rename for their renamed accounts due to redirect - https://phabricator.wikimedia.org/T93467#1170986 (10Legoktm) a:3Legoktm [18:05:51] ^d: 1_25 next week? /me better finish and poke some people about some logging stuff [18:10:25] <^d> Hey I just follow the schedule man :) [18:43:34] <^d> bd808: Heh, asus switched from vcs's (svn -> git?) between firmware version updates. Version is going blablah-2769 -> blahblah-g1bb5fac :) [18:47:31] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth, 7Design, 5Patch-For-Review: keyboard Tab order in OAuth Confirm dialog starts with Cancel - https://phabricator.wikimedia.org/T64763#1171210 (10Jaredzimmerman-WMF) @Ricordisamoa that is not correct and should be removed from the patch. [19:12:24] 6MediaWiki-API-Team, 6CA-team, 6Commons, 6operations: db1068 (s4/commonswiki slave) is missing data about at least 6 users - https://phabricator.wikimedia.org/T91920#1171412 (10Krenair) p:5Unbreak!>3Normal [19:13:48] <^d> +0 from Symfony [19:13:50] <^d> Hahahaha [19:44:09] 6MediaWiki-Core-Team, 10CirrusSearch: Fix highlighting for phrase prefix queries - https://phabricator.wikimedia.org/T93014#1171668 (10Jdouglas) This problem appears to be twofold: 1) The search highlighter seems to only work when we run our phrase_prefix query against text.plain -- not for title.plain, all.p... [20:50:44] 6MediaWiki-API-Team, 10MediaWiki-Configuration, 10MediaWiki-Maintenance-scripts, 5MW-1.25-release: Update mergeMessageFileList.php to support reading extension/skin.json files - https://phabricator.wikimedia.org/T94756#1171929 (10Legoktm) 3NEW a:3Legoktm [20:53:30] omg next week [20:54:26] so little time! [20:55:13] <^d> It's been...one week! [21:00:47] ^d: Cocked your head to the side, and -2'd me [21:01:51] Rrrrrit's been [21:03:26] but it will still be two days till you say your sorry [21:07:07] too many nick changes :/ [21:08:32] Oh, wait, no, that's not me. [21:16:10] 6MediaWiki-Core-Team, 10CirrusSearch: Fix highlighting for phrase prefix queries - https://phabricator.wikimedia.org/T93014#1172065 (10Jdouglas) This gets us halfway there: https://gerrit.wikimedia.org/r/#/c/201350/ Still to figure out - why phrase prefix highlighting is working for the title, but not the text. [21:18:24] bd808: https://gerrit.wikimedia.org/r/201235 will doing that break the i18n cache? [21:19:24] I ... don't know [21:19:24] <^d> bd808: Mike and I are making reservations at L'Auberge Du Pont De Collonges whilst in Lyon :D [21:19:35] ^d: yum [21:20:03] Paul Bocuse! [21:20:10] <^d> Yes! [21:20:28] hey, is api.log sampled now? [21:20:42] I'm pretty sure, yes MaxSem [21:20:44] <^d> bd808: Celebrating 50 years of 3 stars :) [21:20:55] 1:100 or... ? [21:21:37] more like 1:1000 or even 1:10K o_0 [21:21:38] 1:1000 [21:21:49] https://github.com/wikimedia/operations-mediawiki-config/blob/master/wmf-config/InitialiseSettings.php#L4183 [21:22:07] api-feature-usage is 1:1 [21:22:51] There was a ticket somewhere to make sure fluorine has enough disk to set api.log back to 1:1 [21:22:59] Not sure what ever happened to ti [21:23:01] *it [21:23:04] well, api-feature-usage should be called api-feature-misuse :P [21:23:19] oh yeah [21:23:47] ^d: I'm pretty jealous of that dinner plan. You will have to tell me about it in gory detail [21:24:06] <^d> I shall. Not a pea shall go unreported [21:32:14] hmm, how do I estimate the current number of searches per day? [21:32:20] api or not [21:34:16] maybe, ^d or manybubbles know? ^^ [21:34:23] I know things [21:34:31] <^d> mt_rand() [21:35:24] MaxSem: look in fluorine:/a/mw-log/CirrusSearch-all.log [21:35:37] we log all the searches (without the user names of course) [21:35:39] ^d, multiplied by a very big number, I assume? :P [21:36:06] <^d> ;-) [21:36:14] thanks manybubbles! :) [21:36:53] MaxSem: ~30 million full text, ~130 prefix. You can grep and awk toyour heart's content [21:37:11] oh noes! :P [21:38:07] (I'm preparing a card about potential increase of number of GeoData requests) [21:38:18] <^d> go go gadget geodata! [21:39:31] gogogog maps with POI! [21:40:38] ^d: Bocuse has some brasseries in Lyon too -- http://www.nordsudbrasseries.com/ [21:40:56] Maybe I can get something tasty at one of them while I'm there [21:42:26] everyone’s going to be enjoying the food and I’m going to be cringing am I not? [21:42:28] * YuviPanda sighs [21:43:48] YuviPanda, you can always enjoy drinks so much that people will forget about food while envying you! ;) [21:44:02] MaxSem: I’ve, uh, moved on from drinking so much... [21:44:59] YuviPanda: There will be things you like I bet. But you may have to eat around a bone [21:45:25] yeaaaah [21:45:44] Pork belly? It's bacon only better [21:46:49] oh really? [21:46:51] mmm [21:46:53] now I’m interested [21:46:58] but I don’t really like pork... [21:47:02] but maybe that’s just bad pork [21:47:16] umm... bacon is pork dude [21:47:25] i know [21:47:27] non bacon pork [21:47:29] I meant [21:48:16] <^d> mmmmm, pork belly [21:49:06] If I go to a brasserie I want something like -- https://en.wikipedia.org/wiki/Pot-au-feu [21:50:54] 6MediaWiki-API-Team, 10SUL-Finalization, 5Patch-For-Review: GlobalRename tool should not list IP address of the user performing renames as 127.0.0.1 in Checkuser - https://phabricator.wikimedia.org/T94516#1172237 (10Legoktm) a:3Legoktm [21:52:18] Lyonnaise cuisine is all about sausages, pate and roast pork -- heavy fatty meaty food [21:53:13] <^d> I re-watched the Bourdain episode the other night [21:57:43] bd808: I’ll try bone-desensitizing before coming by eating a lot of chicken wings, I guess... [23:13:39] MWException from line 3710 of /srv/mediawiki/php-1.25wmf23/includes/User.php: User::addToDatabase: hit a key conflict attempting to insert user '' row, but it was [23:13:39] not present in select! [23:15:20] <^d> csteipp: I got another overseas mail. Some guy registering for classes in Islamabad :p [23:15:25] * ^d is on so many watchlists [23:16:08] Awesome [23:43:09] hey TimStarling, are you around? [23:43:17] yes [23:43:42] hello! how was your vacation? [23:44:01] (I'm about to ask you for code review, if you have time for it. But I really do want to hear about how it went. :P) [23:44:04] very good [23:44:21] the weather was very nice [23:44:28] no hurricanes [23:44:33] that's always a plus [23:44:56] i had a dream that there was a mediawiki core offsite in australia and you took us around a shopping mall [23:45:03] it was very strange [23:45:34] good idea though [23:45:59] really? what sort of consumer goods are available that aren't readily available in north america? i figure it's mostly the same, no? [23:46:17] oh, you meant holding the offsite in australia, not the shopping mall excursion [23:46:50] if you have time for two patches designed to restore profiling functionality, https://gerrit.wikimedia.org/r/#/c/201375/ and https://gerrit.wikimedia.org/r/201384 would be useful [23:47:11] I meant "good idea though ;)" [23:47:19] sorry, missing smiley [23:47:32] you have a lot of open changes [23:49:58] Yeah, though a whole bunch need to be abandoned [23:50:02] I should groom that backlog [23:53:06] what is the point of the constructor parameter? just to be a rebel? [23:54:06] WebRequest is mostly a wrapper around the superglobals so it seems a bit weird to pass one of them in as the sole constructor parameter [23:54:45] I didn't know if it is a contingent fact that there exists one WebRequest instance, corresponding to the main request, or if in principal there could be others, representing other requests, which may have a different start time. Though I guess that is the point of DerivativeRequest. [23:54:59] s/or if/and if/ [23:55:43] yes [23:56:03] for the main request, it is better to have it set to $_SERVER['REQUEST_TIME_FLOAT'], but surrogate requests should default to microtime( true ) [23:57:25] I can amend the change so that this happens by dint of the constructors knowing which value to set it to rather than the callers passing it in [23:58:30] I think that would be better [23:59:20] it's probably not ideal to have an object whose job it is to extract data from global state and present it as non-static object state [23:59:29] it leads to confusion [23:59:48] but it's better to follow precedents or refactor completely than to introduce inconsistencies within a class