[00:05:44] 6MediaWiki-API-Team, 6CA-team, 10MediaWiki-API, 10MediaWiki-User-login-and-signup, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1205386 (10Deskana) Elena checked with the APK that I sent her, which had @dbrant's patch in it. So I guess that fi... [01:22:36] ^d: Do you have access that can help debugging why Gerrit is not replicating VisualEditor properly to GitHub? [02:11:11] what's not replicating Krinkle? [02:11:39] it looks like you're fiddling with VisualEditor-VisualEditor [02:48:35] Krenair: Yeah, trying to reset it somehow [02:49:17] Krenair: Merges to Gerrit in VE do not get pushed to GitHub [02:49:23] the 'master' branch is over a month outdated [04:21:50] bd808: I thought http://www.wired.com/2015/04/lost-spirits/ was you for a second [05:16:23] 6MediaWiki-API-Team, 10MediaWiki-extensions-CentralAuth, 5Patch-For-Review: Add javascript confirmation button to Special:GlobalRenameQueue - https://phabricator.wikimedia.org/T95428#1205804 (10Legoktm) 5Open>3Resolved [13:20:33] <^d> Krinkle: I have root to that box, so yes :) [13:21:50] ^d: Perhaps anything in the error logs there? Assuming there are some [13:24:34] <^d> Heh, show-queue would've shown you something interesting already. [13:24:38] <^d> Don't even need the logs [13:25:18] <^d> https://phabricator.wikimedia.org/P516 [13:26:06] <^d> [2015-04-14 13:25:48,669] ERROR com.googlesource.gerrit.plugins.replication.ReplicationQueue : Cannot replicate to git@github.com:wikimedia/VisualEditor-VisualEditor [13:26:06] <^d> org.eclipse.jgit.errors.TransportException: git@github.com:wikimedia/VisualEditor-VisualEditor: Missing unknown 483b51dffe82bff3bab7014cface623701ac4907 [13:26:10] <^d> There's your error ^ [13:29:18] <^d> Fixed all but VE and puppet/cdh [13:30:10] <^d> I think this has something to do with repos that were renamed? [13:43:34] 6MediaWiki-API-Team, 10MediaWiki-API, 6WMF-Legal, 7Documentation, 5Patch-For-Review: Special:ApiHelp should include licensing information - https://phabricator.wikimedia.org/T93994#1206408 (10Anomie) 5Open>3Resolved [13:55:35] <^d> Ah, I think it happens when a branch is deleted on gerrit, not on github, and you end up with orphan commit(s) [13:56:26] <^d> Yep [13:58:30] <^d> Krinkle: Your gh-pages branch on github isn't in gerrit, so it barfs because there's a sha1 it has nfc about [14:00:06] ^d: OK [14:01:15] ^d: Got a merge incoming in 1 minute. Let's see [14:01:23] Removed the branch for now. Will re-create within gerrit [14:01:55] <^d> Replication unstuck [14:07:44] <^d> the heck? [14:07:51] <^d> PHP Warning: file_get_contents(): SSL operation failed with code 1. OpenSSL Error messages: [14:07:52] <^d> error:14090086:SSL routines:ssl3_get_server_certificate:certificate verify failed in /Users/chad/Desktop/fetch_missing_repos.php on line 17 [16:21:42] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth: Only show grants that the user has permission to use, to avoid confusion - https://phabricator.wikimedia.org/T94478#1206931 (10MarkTraceur) OK, so, your suggestion would be to show: * Grants that the user has all the rights for * Grants that the user has some... [16:54:38] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth: Only show grants that the user has permission to use, to avoid confusion - https://phabricator.wikimedia.org/T94478#1207017 (10csteipp) >>! In T94478#1206931, @MarkTraceur wrote: > As annoying as it would be to app authors, I'm leaning towards the latter, beca... [16:55:44] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth: Only show grants that the user has permission to use, to avoid confusion - https://phabricator.wikimedia.org/T94478#1207022 (10MarkTraceur) Oh, OK, I don't feel too bad about it, then. :) I'll set about doing that now, and it should be set sometime this week. [17:08:32] 6MediaWiki-API-Team, 10SUL-Finalization, 10Wikimedia-Site-requests, 5Patch-For-Review: Set $wgCentralAuthCheckSULMigration = true in production - https://phabricator.wikimedia.org/T95735#1207086 (10Legoktm) 5Open>3Resolved [17:14:52] ^d: https://gerrit.wikimedia.org/r/#/c/203987/4 [17:29:36] 6MediaWiki-API-Team, 6CA-team, 10MediaWiki-API, 10MediaWiki-User-login-and-signup, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1207171 (10Etonkovidova) Re-checked next day after the first edit. All edits were saved with my user name and 'T... [17:29:48] 6MediaWiki-API-Team, 6CA-team, 10MediaWiki-API, 10MediaWiki-User-login-and-signup, and 4 others: App says I'm logged in, but edits are saved from IP - https://phabricator.wikimedia.org/T75086#1207184 (10Etonkovidova) 5Open>3Resolved [17:35:00] 10MediaWiki-Core-Team, 10AutoWikiBrowser, 10MediaWiki-API: Annotate redirects from prop=info if target is an interwiki - https://phabricator.wikimedia.org/T85417#1207202 (10Reedy) [18:25:44] 6MediaWiki-API-Team, 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:SpecialPages broken on wikis with UploadWizard enabled - https://phabricator.wikimedia.org/T96057#1207415 (10MarkTraceur) 5Open>3Resolved [18:41:12] anomie: This whole thing is built in a really cool way [18:41:19] But it is so hard to follow. :P [18:41:25] marktraceur: OAuth? [18:42:06] Yeah [18:42:25] anomie: Off the top of your head, where should I filter the permissions granted before they get stuck in the database [18:42:32] Or...hm [18:43:12] I was about to say "aha, in the model, then I don't need to worry about it" but a model with session awareness seems wrong [18:44:32] marktraceur: ... Yeah, I have no idea. Aaron wrote that part of it. [18:44:44] Accursed aaron [18:44:50] Him and his brilliance [18:45:12] I'll figure it out eventually [18:53:55] cheesecat: https://gerrit.wikimedia.org/r/#/c/204093/ [18:54:51] there's nothing brilliant about code that is hard to follow :P [18:56:02] jenkins no likie [18:57:16] Fatal error: Couldn't find constant BufferingStatsdDataFactory::STATSD_METRIC_COUNT [18:58:00] boggle [19:04:36] use Liuggio\StatsdClient\Factory\StatsdDataInterface; ? [19:26:40] 6MediaWiki-API-Team, 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:SpecialPages broken on wikis with UploadWizard enabled - https://phabricator.wikimedia.org/T96057#1207552 (10Umherirrender) mediawiki/core is not broken, seems to be an issue in combination with an extension.... [19:28:57] 6MediaWiki-API-Team, 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:SpecialPages broken on wikis with UploadWizard enabled - https://phabricator.wikimedia.org/T96057#1207565 (10MarkTraceur) @Umherirrender and yet, the patch fixed it - might have been that UW was the only one n... [19:43:57] 6MediaWiki-API-Team, 10MediaWiki-extensions-UploadWizard, 6Multimedia, 5Patch-For-Review: Special:SpecialPages broken on wikis with UploadWizard enabled - https://phabricator.wikimedia.org/T96057#1207605 (10Umherirrender) It is calling ContextSource::setContext from HtmlForm which does not allow a null to... [20:10:20] 6MediaWiki-API-Team, 10Beta-Cluster, 10SUL-Finalization: Finalize SUL on beta cluster - https://phabricator.wikimedia.org/T96075#1207662 (10Legoktm) 3NEW a:3Legoktm [20:24:08] 7Blocked-on-MediaWiki-Core, 10MediaWiki-General-or-Unknown: MediaWiki and CC 4.0 license - https://phabricator.wikimedia.org/T96077#1207712 (10Nasirkhan) 3NEW [20:25:42] (I archived https://phabricator.wikimedia.org/tag/blocked-on-mediawiki-core/) [20:36:58] cheesecat: https://gerrit.wikimedia.org/r/#/c/193881/ [20:37:47] 6MediaWiki-API-Team, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: Clean up 'infinity' handling - https://phabricator.wikimedia.org/T92550#1207777 (10Anomie) 5Open>3Resolved [22:06:57] could I get a review on https://gerrit.wikimedia.org/r/#/c/193881/ ? for some reason I thought that was already merged :/ [22:09:49] I looked. I don't think I can help. [22:15:09] :| [22:15:17] thanks for looking though [22:26:50] It looks ok [22:29:00] Krenair: wanna +2? I'd like to get it into swat today... [22:29:25] will look a bit closer at some of the details first [22:34:15] legoktm, why are you adding the header at the end? :/ [22:35:15] Krenair: it adds it to the top of the html, $html = $this->msg( 'centralauth-rename-progress-list-header' )->escaped() . $html; [22:35:28] right, but it's weird [22:38:15] remind me why we have multiple entries with the same old name? [22:38:28] oh, it's one entry for each local account? [22:38:31] yes [22:43:39] done [22:43:44] thanks :) [23:01:41] 6MediaWiki-API-Team, 10MediaWiki-extensions-OAuth: Add warning for user on /authorize about privacy policy - https://phabricator.wikimedia.org/T64687#1208264 (10MarkTraceur) @csteipp my solution to T59457 actually means we can't add this to an existing message, because I'm using the message(s) in core. In that... [23:02:19] bd808: You in town yet? [23:02:23] blazecat: should I not deploy that patch in SWAT? When I tested it locally a few weeks ago it worked fine without ORDER BY [23:02:45] legoktm: you mean GROUP BY? [23:02:56] yeah [23:03:22] ragesoss: I was told to ask you the foolish question "What do you dislike about the OAuth interface?" :) [23:04:00] marktraceur: I am. I'm on 3 right now [23:04:01] I hear all the cool kids are up on 5 [23:04:04] We are. [23:04:21] Well, greg-g thinks he's cool, but even if 3 is cool, he's only there 2/5 of the time. [23:04:48] bd808: I'm going to also ask you "what should I do about the OAuth interface" because I feel like I'm running out of stuffs to do. [23:04:53] marktraceur: :-) [23:05:15] marktraceur: which interface? for developers, or users of OAuth apps? [23:05:22] ragesoss: Either? Both? [23:06:55] legoktm, was https://phabricator.wikimedia.org/T87901 resolved? [23:06:59] For developers, the lack of connection between Special:OAuthListConsumers and Special:OAuthConsumerRegistration is very confusing. [23:07:09] blazecat: so...I'm going to go ahead and put it in swat [23:07:31] legoktm: so is the new_name always the same? wouldn't if have a different wiki suffix? [23:07:41] (same per old name) [23:08:15] ragesoss: RIGHT? [23:08:17] I hate that [23:08:19] this probably only works for the same reason GROUP BY can be used non-standardly in mysql [23:08:23] In particular, there's information that you may want to look about your consumers, but it doesn't show up in Special:OAuthConsumerRegistion/list. [23:08:23] And I've only been using this for five days [23:08:34] "works" as in doesn't give a query error at least [23:09:05] marktraceur: how do I get into 5? White door or brown [23:09:06] ragesoss: I will work on that, then! Thanks! [23:09:11] bd808: Either? [23:09:13] Both? [23:09:28] blazecat: oh yeah... [23:09:42] marktraceur: the number one thing is callback url. If you forget what you put in for it, and you don't know about OAuthListConsumers, then you're going to be pulling out your hair. [23:10:19] legoktm: sorry I disappeared for a while thinking about some wl_notification stuff [23:10:41] blazecat: should it be DISTINCT(ru_newname) then? [23:10:55] marktraceur: another thing is that there's no clear method for seeking approval. In many cases, you'll be registering consumers just for testing and you don't need or want them to be approved (since you can use them with your own account for dev) [23:11:02] legoktm: do you still want to select ru_oldname? [23:11:21] marktraceur: but when you actually are ready to propose a consumer that needs to be approved, there's no clear process for seeking approval. [23:11:42] blazecat: I want all the unique ru_oldname, ru_newname pairs [23:11:45] marktraceur: and unless you know who to ask for approval directly, it's likely to just sit there indefinitely. [23:11:55] right, since it's for everyone [23:12:18] * legoktm found a piece of tape for the ethernet cord that keeps falling out [23:13:07] also if the old name is hidden what happens? [23:13:50] the oldname shouldn't exist in the database anymore [23:14:41] hmm [23:14:50] for promotetoglobal, I don't think we handle that at all? [23:15:01] the local would still be suppressed, but the global would be public... [23:15:02] I don't see a need for DISTINCT then [23:15:17] so how do we de-duplicate then? [23:15:24] marktraceur: as a user of OAuth apps, I don't like that the approval interface has no option to switch usernames. Many others have a "not John Smith? Log in with your own account" type flow. Of course, as someone with multiple Wikipedia accounts that I use on a regular basis, my use case is maybe not that common. But still, it's common to have that sort of thing. [23:16:13] legoktm: would you have a->b on one wiki and a->b on another? [23:16:24] I thought the new names would be suffixed [23:16:45] there is no unique index that says this though [23:16:59] both [23:17:24] (oldname, newname, wiki) is unique [23:17:35] if it's a promotetoglobal type rename, (oldname, newname) will be unique [23:19:25] marktraceur: the number one OAuth issue I've had is the one that tgr's patch-for-review addresses: https://gerrit.wikimedia.org/r/#/c/204059/ [23:22:08] legoktm: if duplicates are possible, you can just use 'DISTINCT' in the $option param after __METHOD__ [23:22:54] marktraceur: one minor thing with the propose interface is that the checkboxes for applicable grants are hard to use. For one, it's not easy to see which grant a given checkbox corresponds to, because of all the white space in between the short ones. the grants are also not arranged in a useful order or divided according to type, or anyting else that might make it easier to make sense of the options. [23:23:30] marktraceur: as a quick improvement, I would suggest putting the checkboxes to the left of the grants, aligned right up next to them. [23:25:47] marktraceur: and add the really common 'just normal editing' grants — edit existing, created/edit/move, upload files, and maybe send email — right at the top. And then next, the own-user ones like view and edit watchlist, edit prefs, and edit CSS/js. And then the advanced rights ones, escalating from rollback and patrol up to admin stuff and then checkuser. [23:33:19] blazecat: like https://gerrit.wikimedia.org/r/204192 ? [23:33:45] yes [23:33:49] * legoktm tests [23:35:30] I guess you can get ori to look at https://gerrit.wikimedia.org/r/#/c/203379/ maybe [23:38:11] ragesoss: I guess I'll OOUI-ify the other forms first [23:38:42] marktraceur: yeah, in general, obviously there' [23:39:21] s plenty of easy headway to make with just updating the UI styling to be more consistent with the good parts of modern mediawiki. [23:39:35] :-) [23:39:42] Right. [23:39:49] And most of the usability will follow naturally. [23:39:58] OK, I'll file a task for that (those) [23:42:55] blazecat: I tested https://gerrit.wikimedia.org/r/#/c/204192/ and it works properly [23:46:59] TimStarling: can I pm? [23:47:37] yes [23:49:34] blazecat: can you +1 203379 if it looks good to you? [23:54:38] 6MediaWiki-API-Team, 10MediaWiki-extensions-CentralAuth, 10SUL-Finalization: Code review CentralAuth's GlobalUserMerge and related UserMerge code before SUL finalization mass usage - https://phabricator.wikimedia.org/T961#1208463 (10tstarling) a:5brion>3tstarling