[00:41:14] filed https://phabricator.wikimedia.org/T99468 [01:02:31] thanks for the reviews. I'll rework the patch [01:34:08] ori: we'll need more reliable and scalable queuing fairly soon for services, and have made it a goal for next year [06:00:19] TimStarling: so for some reason, skins loaded through skin.json aren't being cached in APC properly, and will re-appear when I `touch` the skin.json file...we first saw it with Nostalgia on nostalgiawiki, and now CologneBlue is missing from mediawiki.org, but touching it on mw1017 made it come back...do you have any ideas on how this is possible? [06:00:52] the code should throw an exception if a file doesn't exist, so I don't understand how it's caching nothing. [06:01:52] I will have a look [06:04:52] thanks [07:21:44] bd808: do you know why travis-ci isn't running for pull requests? https://github.com/wikimedia/composer-merge-plugin/pull/29 [13:12:03] legoktm: Sure, T71589 could be fixed in AuthManager. In fact it looks like I did, code is already there in AuthManager::autoCreateAccount(). [15:36:02] legoktm: looks like they actually are running but just not showing up with links in the github ui? -- https://travis-ci.org/wikimedia/composer-merge-plugin/builds [16:28:39] anomie: left a question on https://gerrit.wikimedia.org/r/211722 [16:29:22] * anomie looks [16:30:24] legoktm: Replied [18:38:47] AaronSchulz: yt? [19:06:04] ori: https://phabricator.wikimedia.org/T99557?workflow=create [19:06:54] legoktm: https://gerrit.wikimedia.org/r/#/c/207730/ [19:07:34] ori: can we just revert APC for now? that's a larger change to review [19:09:26] no [19:09:57] the gadgets manifest loads on every backend page view [19:10:37] how broken is the broken cache? no invalidation at all, ever? [19:10:45] a little bit of added latency affecting millions and millions of users outweighs a small handful of people needing to wait a bit extra for the cache to expire [19:10:50] of anything gadget-related? [19:11:06] it's ~24h iirc [19:11:28] $cache->set( $key, $gadgets, 60 * 60 * 24 ); [19:11:43] or just the gadget list (and metadata)? [19:11:46] MatmaRex: any changes to MediaWiki:Gadgets-definition [19:12:06] right. well, that's less horrible than i thought, then [19:12:14] it's tolerable atm [19:12:29] ori: given that gadgets run for all users, it's not just "a small handful of people" being affected, but I see your point [19:12:30] but it will still be really incredibly annoying if somebody, say, adds a new dependency. especially since no one knows this is the case [19:12:41] i just spent half an hour debugging the Gadgets extension myself… [19:24:44] that sucks, sorry. [19:37:53] ^d: happy (belated) birthday! [20:56:09] Can this be another APC issue? https://phabricator.wikimedia.org/T97924#1292000 [20:56:09] Why would it be an APC issue? [21:24:45] anyone seen/looked into https://facebook.github.io ? [21:25:20] someone mentioned it in a meeting I'm in as an A/B testing solution for us [21:26:33] "Engineering at Facebook"? [21:36:05] greg-g: did you mean to link to https://facebook.github.io/planout/ ? [21:36:19] gah, yes [21:36:32] If so, ori at least glanced at it at some point -- https://www.mediawiki.org/wiki/Wikimedia_MediaWiki_Core_Team/Backlog#A.2FB_testing_framework [21:37:45] https://github.com/vimeo/ABLincoln [21:38:02] neat! it's managed by Eytan! i went to school with him [21:38:13] (planout) [21:48:23] ori: btw, if you want an intro to Eytan Bakshy (re Planout), I went to school with him