[02:43:05] TimStarling: thanks for the review. I updated the patch to sanitize \x7f in Parser::fetchTemplateAndTitle() and re-checked for usage of deprecated functions in extensions. [02:49:20] gave it +2 [03:33:11] thanks [13:20:09] Does anyone else think https://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions/PHP&diff=1662063&oldid=1660201 and https://www.mediawiki.org/w/index.php?title=Manual:Coding_conventions&diff=1662845&oldid=1499459 are linkspam, or am I just being over-sensitive? [13:26:54] I reverted the second one because it's php-specific [13:27:00] so should only be on the php subpage [13:27:33] as for the first one... it does seem specifically designed for this page - https://www.organicdesign.co.nz/Extension:CodeTidy [13:27:46] I would just leave it [13:28:48] * anomie is skeptical about external links under "see also" that lead to a page with "give me money!" in the sidebar. [13:31:14] * anomie makes an "External links" section for it [15:28:57] MatmaRex: "semicolon-separator" or "ooui-semicolon-separator"? [15:30:00] anomie: ooui-, i have no idea how translatewiki would react to one message being used in different repositories [15:30:09] anomie: and i think they can easily copy the translations over [15:31:35] Is oojs-ui even in translatewiki? But I'm sure they'd have to handle it already, unless it's not being separate from the MW i18n setup. [15:33:42] MatmaRex: ^ [15:34:22] it is [15:35:21] Should I be updating anything besides core.js to update the i18n? [15:44:07] we use core messages in extensions sometimmes [16:06:27] MatmaRex: Ah, I see an i18n directory now. Should I be adding the new messages to i18n/en.json and i18n/qqq.json? [16:08:33] anomie: yep [16:08:40] it's the same format as mediawiki [16:08:50] anomie: added you as a CC to https://phabricator.wikimedia.org/T100872 . Would love your thoughts on that. I think there's no bug per se; it's just Scribunto doing its thing. But it's very ripe for optimization. [16:12:19] ori: I'll have a look [16:12:33] thanks [16:23:44] ori: So the bit you quote there is from the handler for someone doing "require( 'Module:Yesno' )" in their Lua module. Within each page parse the return value there *should* be cached within Lua, even across multiple #invokes (the code for that is in engines/LuaCommon/lualib/mw.lua). Do we not see the same thing for widely-used templates? [16:26:35] anomie: no, the text IDs I saw at the top of memcached servers were all modules IIRC. I can check again to confirm. [16:27:36] ori: It could be we don't have templates that are as widely used as utility modules like Module:Yesno, I suppose. [17:02:06] bd808: Meeting? [17:02:21] gah yeah [17:04:49] debugging hangouts sucks [18:07:13] dapatrick: I'm in the hangout whenever you're ready [18:30:32] anyone want to merge https://gerrit.wikimedia.org/r/#/c/214436/ ? YaronKoren punted to Foxtrott, and Foxtrott +1'd. It also has Tim's +1. [18:31:32] 1+1=2 [18:31:42] thanks legoktm :) [18:31:47] np [18:32:44] ori: do you know if we keep any statistics about how long it takes from job insertion to execution? specifically I'm looking into making Echo utilize the job queue again and last time it was turned off due to notifications arriving really late [18:33:14] I'm not sure; AaronSchulz would know [18:33:57] it should be fairly easy to add if we don't do it already [18:33:59] and it'd be useful [18:35:51] when is wmf8 going to wikipedias? [18:36:42] * ori can't read calendars [18:37:19] wednesday, it looks like [22:01:26] legoktm, probably best to wait on https://gerrit.wikimedia.org/r/#/c/208852/ before doing that [22:01:52] AaronSchulz: wait on doing what? [22:02:01] we don't have great stats on that...we do store the timestamps in redis, so I guess we could send (now - time) to statsd and make a graph [22:02:08] making echo use the jq [22:02:10] ah [22:03:37] AaronSchulz: https://gerrit.wikimedia.org/r/#/c/208852/ LGTM. Do you want to schedule a deployment for that? You could still make today's SWAT. [22:03:54] today is fine [22:04:06] I'll +2; can you add it to the calendar? [22:10:26] sure [23:31:57] I filed https://phabricator.wikimedia.org/T101054 for the jobqueue stats