[01:31:22] can we switch eventlogging to use formatversion=2 now? [01:35:24] milimetric, bd808: https://gerrit.wikimedia.org/r/234202 [01:36:22] that would be swell. that patch I made made me feel dirty inside [01:36:32] lego, sure, there's no rush as I understand it to hack around the bug this time [02:17:42] TimStarling: the documentation for $wgExtraNamespaces says extensions are supposed to use $wgCanonicalNamespaceNames, but that hasn't been possible since your https://www.mediawiki.org/wiki/Special:Code/MediaWiki/r85327 since it's now unconditionally set in Setup.php. Do extensions have to use the CanonicalNamespaces hook? Extension registration is currently incorrectly adding the canonical english names to $wgExtraNamespaces, which is [02:17:42] preventing them from being localized properly. [02:19:56] Scribunto uses the CanonicalNamespaces hook [02:20:15] which means it is probably current best practice [02:20:19] legoktm / bd808: in case you don't see it on phab, I've added this to our backlog: https://phabricator.wikimedia.org/T110450 so the hack-around is not needed, we'll take care of this soon-ish [02:21:12] I think it's fair to say that extension namespaces haven't been completely thought through, there are probably some improvements to be made [02:23:54] hmm yeah, a hook with no logic that has to run on basically every request doesn't seem like a great idea [03:00:34] TimStarling: how does https://gerrit.wikimedia.org/r/234146 look? [03:01:54] looks good [03:02:24] if you've tested it I'll merge it right now [03:03:27] yup, I tested it with the namespaces added by Gadgets [03:04:57] yay thanks :) [05:52:29] anomie: can I paste your mw-api email about deprecated User stuff to https://phabricator.wikimedia.org/T110433 ? [08:24:36] is there a way to have config variables shipped with an RL module instead of all pages? [08:28:26] ori: maybe you have an idea for https://gerrit.wikimedia.org/r/#/c/233719/4/ContentTranslation.hooks.php [08:28:49] couldn't find such feature in resource loader [13:06:43] tgr|away: Sure [16:49:14] Nikerabbit: re: https://gerrit.wikimedia.org/r/#/c/233719, I think it's fine [16:49:23] it's pretty small [16:49:35] thanks for taking that into consideration though [17:05:07] Nikerabbit: Unfortunately there's no such feature in RL, but I've wanted one for years [17:55:03] Nikerabbit: RoanKattouw: There is actually, however you shouldn't want it as a config variable. mw.config should be considered site-wide (and some user/page specific stuff). For anything acompanying your code, expose them in your own host object instead of riding mw.config. [17:55:12] Nikerabbit: Look at the LanguageDataModule for example. [17:55:18] and VisualEditorDataModule [17:55:39] extend your FileModule and prepend or append extra information as needed [17:55:44] see also JqueryMsgModule [17:55:54] Totally possible :) [18:02:44] Krinkle: yeah but sounds inconvenient compared to setting configVariables: [ 'foo', 'bar', 'baz'] in module config :o [18:04:03] Well, it's our job play the inconvenient part for the convenience of our users. [18:04:08] :) [19:51:42] * AaronSchulz pesters legoktm about https://gerrit.wikimedia.org/r/#/c/233677/ again [21:43:35] tgr: I hear you're going to tackle SpecialUserLogin? [21:44:40] git rm [21:44:41] JOB DONE [21:46:16] RESOLVED WORKSFORME [22:20:00] …tackle? [22:20:38] break all teh things