[18:54:20] <legoktm>	 AaronSchulz: what does "DBError from line 476 of /srv/mediawiki/php-1.26wmf24/includes/jobqueue/JobRunner.php: Timed out waiting on commit queue." mean? saw it on a global rename job
[20:06:45] <AaronSchulz>	 legoktm: it means the job couldn't commit due to already high slave lag (the runner doesn't want to pile on)
[20:12:15] <AaronSchulz>	 Krinkle: https://gerrit.wikimedia.org/r/#/c/240873/ that was irking me
[21:05:58] <legoktm>	 AaronSchulz: hmm. will that job get retried then? there's a stuck LocalRenameUserJob job on wikimania2012wiki
[21:06:21] <AaronSchulz>	 I assume it gets the normal 3 tries
[21:07:47] <hashar>	 Krenair: thanks for the test addition on mediawiki-config patch https://gerrit.wikimedia.org/r/#/c/239754/ :)
[21:09:30] <Krenair>	 hashar, np, after that we went back and made it actually work
[21:09:41] <Krenair>	 turns out it's actually called with $IP/../langlist
[21:09:59] <Krenair>	 it was finding the last . and thinking the rest was the extension
[21:10:00] <hashar>	 Krenair: ho so writing the test caught a bug ?
[21:10:04] <Krenair>	 no
[21:10:08] <Krenair>	 the test did not catch the bug
[21:10:23] <hashar>	 :(
[21:10:56] <hashar>	 at least the code was good
[21:11:07] <Krenair>	 so we are now using pathinfo( $filename ) instead of parsing it ourselves
[22:00:01] <ori>	 MaxSem: includes/site/SiteList.php is amazing
[22:00:13] <ori>	 it's basically a reimplementation of PHP arrays
[22:00:39] <ori>	 look at site::preSetElement
[22:00:44] <ori>	 SiteList::preSetElement
[22:00:45] <ori>	 i mean
[22:01:17] <Krenair>	 I wonder who wrote that
[22:06:01] <Reedy>	 WMDE?
[22:06:35] <Reedy>	 https://github.com/wikimedia/mediawiki/blob/master/includes/site/SiteList.php#L27
[22:07:34] <Krenair>	 specifically...