[01:44:28] [09:41:09] AaronSchulz: instead of having configuration variables like $wgLanguageConverterCacheType = CACHE_ANYTHING, etc., wouldn't it be simpler to have DefaultSettings.php $wgObjectCaches['LanguageConverter'] = array( 'factory' => 'ObjectCache::newAnything' ), and then you can just override it? [01:46:03] It's simpler in the implementation code, but it makes the LocalSettings.php much more complicated (you have to get the array syntax right), and it requires directly knowing the function you want (which makes it much harder to change if we ever need to), while we can re-define the constant to do whatever we want [13:49:29] bd808, hashar: We looked at symfony in the planning for AuthManager, and "a few narrow interfaces we could use and all the real work would need to be done from scratch" was the conclusion we reached then too. [13:49:54] anomie: good monday morning ! [13:50:04] I am happy you figured out the garbage collecting issue [13:50:22] hashar: As you probably saw, the memory leak was a circular reference that HHVM won't collect. I had thought about it but hoped it wouldn't turn out to be a big deal. At least I knew right where to go to fix it. [13:50:28] anomie: great to see you at least considered reusing a 3rd party lib :D [13:50:49] does HHVM even has a garbage collector ? [13:53:12] HHVM has a reference-count garbage collector, but doesn't do the cycle-collecting that Zend does since 5.3. [13:53:47] A blog post from IIRC 2012 says they have one implemented but it's disabled due to bugs. And I tested a week or two ago, no cycle collection until global destruction. [13:57:09] I did recall correctly: http://hhvm.com/blog/431/on-garbage-collection [14:43:30] * anomie tried to be nice to a newbie in https://gerrit.wikimedia.org/r/#/c/243643/ [14:52:52] anomie: Krenair and I have been trying all afternoon [14:53:33] We were working him towards an OOPs way, but it seems his programming skills are minimum, and blames that he doesn't know MW core [14:54:32] I thought he was working on the idea of extracting those few lines of code, and overriding it in the subclass, but apparently that went out of the window [14:55:42] * anomie isn't here to teach someone to code, so if that's his problem he's going to have to figure it out on his own. [14:55:57] Yeah, exactly [14:56:20] Telling him what to do is one thing, but then he was wanting hand holding through the whole process... [15:00:48] Heh. He just asked for hand-holding on #wikimedia-dev. I told him no. [16:05:59] tgr|away: Heh. That should work, although I meant something like do { $boundary = '=_' . md5( 'php-gpglib' . uniqid( mt_rand(), true ) ); } while ( strpos( $textToBound, $boundary ) !== false); [18:30:38] tgr: Your PgpMime::encrypt method should probably use stripos() for checking for content headers, in case the caller normalizes as all-lower-case. [23:25:06] csteipp: if you get a minute, would you mind following your +1 of https://gerrit.wikimedia.org/r/#/c/236683 up with a +2? [23:27:33] bd808: done [23:27:39] thanks