[15:34:30] legoktm: https://github.com/wikimedia/composer-merge-plugin/pull/67 is still waiting patiently for you to review it ;) [17:31:34] ostriches: can you look into https://phabricator.wikimedia.org/T116375 ? I'm not to familiar with what that code is doing. [17:33:49] AaronSchulz: The installer used to be simple until people tacked resourceloader onto it :p [17:34:05] the problem is something trying to use "none" [17:34:21] maybe it takes that value from the user and does not convert it to the constant somewhere [17:34:48] The only place we take 'none' from the user is when generating LocalSettings. [17:34:53] But that /should/ work [17:35:09] case 'anything': [17:35:10] case 'db': [17:35:10] case 'memcached': [17:35:10] case 'accel': [17:35:10] $cacheType = 'CACHE_' . strtoupper( $this->values['wgMainCacheType'] ); [17:35:10] break; [17:35:10] case 'none': [17:35:11] default: [17:35:11] $cacheType = 'CACHE_NONE'; [17:37:00] Plus, installer's constructor should properly disable all caches. [18:46:44] csteipp: FYI, https://phabricator.wikimedia.org/T116413 (Security review request for SessionManager) [19:12:27] anomie: thanks! What's your preferred timeline for that? [19:14:49] csteipp: I get to pick? It'd be nice to at least get the php-session-serializer bit reviewed so unit tests don't gratuitously fail. Other than that it's not blocking work on anything else. [19:14:58] bd808: ^ Any suggestion? [19:15:29] last month! [19:23:45] csteipp: less flippantly, as soon as you can get to it. This is a step towards our Q2 goal of shipping AuthManager [19:24:15] Cool. I will try to work it in soon. Might be able to do it early next week. [19:24:18] * bd808 realizes that there is nearly no way AuthManager will actually ship in Q2 due to December deploy freeze [19:25:02] next week would be awesome [19:35:18] csteipp: would you object to transferring https://github.com/Stype/mwoauth-php to Wikimedia and including it properly in OAuthAuthentication? [19:35:35] No, would be happy to [19:42:02] tgr: I made a pretty nice to use OAuth lib in https://github.com/wikimedia/wikimedia-slimapp/tree/master/src/OAuth too. It could be broken out to be separate from the rest of the code in that library [19:42:41] it is a copy-paste of Chris' code with some niceities added in [19:43:23] Mostly I added PSR3 logging and split the upstream OAuth lib into separate files [19:44:14] https://github.com/wikimedia/wikimedia-slimapp/commit/b7cab722278867bb650c2d4315489ad31d12593c [19:44:33] does it have an equivalent of MWOAuthClient? [19:45:06] https://github.com/wikimedia/wikimedia-slimapp/blob/master/src/OAuth/Client.php [19:46:16] (kind of obvious in hindsight) [19:47:00] I use it in the bash tool to do OAuth with mw.o [19:47:26] so what would you recommend? create a new repo with that code under Wikimedia/? [19:48:05] Yeah, it would be easy to do. That lib is actually in gerrit so probably make the new one in gerrit too [19:48:31] ugh [19:48:40] no gerrit love? [19:48:43] that tends to mean a three-day delay [19:49:01] bah. it just means "poke ostriches or ori to make the repo" [19:49:29] you just need to know who the cool kids with rights are [19:51:31] what should the name be? mediawiki/oauth? [19:52:15] csteipp: ^ is that too general? Maybe oauthclient? *shrug* [19:52:18] names are hard [19:53:09] I'd go for mediawiki/oauthclient-php.. or something like that. Aaron Halfaker has a python oauth client, so want to leave room in the family for both [19:54:19] works for me [19:59:20] ostriches, ori: can you help with that? https://www.mediawiki.org/w/index.php?title=Git/New_repositories/Requests/Entries&diff=1921694&oldid=1917818 [20:26:46] tgr: sure [20:27:25] thanks! [20:28:29] tgr: do you have a short description for the repo? [20:28:41] "PHP OAuth client to use with Wikipedia and other MediaWiki-based wikis running the OAuth extension" [20:31:57] tgr: done, but I have to run so I can make it to the office by 2pm. could you update mediawiki.org for me? [20:32:08] sure, thanks! [20:32:11] np, bye [20:37:34] we probably should have a Library: namespace [20:50:27] We have a category for now [22:33:55] bd808: can you re-review https://gerrit.wikimedia.org/r/#/c/248494/ ? [22:40:04] tgr: left 3 more tiny nitpicky doc comments. tests run clean and this was all cleared by csteipp when I put it into slimapp so I can +2 as soon as you tell me to stop finding little nits to pick at :) [22:40:43] You should get legoktm to hook it up to all the zuul/jenkins stuff [22:41:02] * legoktm looks [22:41:47] we keep making new libraries to distract us from the drudgery of AuthManager ;) [22:45:56] tgr: commented on both patches :) [22:52:32] bd808: I need the library because it has a feature missing from the old version used in OAuthAuthentication which makes it work with vagrant which provides a test case for Special:Userlogin [22:52:37] so totally legit! [22:55:14] :) It all looks good to me now. I suppose we should wait for zuul integration so I don't have to force merge it [22:56:28] legoktm: can you give it another look? [22:58:13] bd808: should it be a hard dependency for slimapp or a suggested one? [22:58:44] tgr: looks good, I'm going to remove the jsonlint because composer validate already takes care of that [23:05:46] bd808: CI is setup [23:06:23] legoktm: should Doxygen also be set up in CI? [23:06:28] I forgot about that [23:06:34] uh, yeah [23:25:30] bd808: could you create a packagist entry? [23:25:45] yup [23:26:04] also, what's needed to get travis working? it doesn't show up in the Wikimedia list [23:26:37] you have to force them to rescan our repo list [23:26:44] I did, I think [23:26:46] I can do that after I get packagist working [23:28:45] https://packagist.org/packages/mediawiki/oauthclient [23:32:21] tgr: https://travis-ci.org/wikimedia/wikimedia/mediawiki-oauthclient-php/builds/87140364 [23:33:26] thanks! [23:36:56] huh, error handling fail [23:37:09] tgr: you've used up your getting-things-shipped credit for the year, though -- from now on it's a minimum of six months from patch submission to merging [23:37:12] travis just gives a white screen of death when it does not like the URL [23:37:29] :)