[14:49:06] Reedy: y2k_compliance....Removed in PHP 5.4.0 [14:49:25] PHP 5.4+ isn't y2k compliant! [19:39:53] AaronSchulz: Watching the logs, I'm seeing CAS exceptions every few minutes. Is that expected? [19:40:11] csteipp: from time to time, usually double-posts from users [19:40:21] has it trended up? [19:41:17] AaronSchulz: I haven't looked that far into it. It was just in some Auth code, so I wasn't sure if that was something I needed to look at. Double submit would make sense. [19:44:34] csteipp: do you remember what oauthauth-set-email is supposed to be in https://github.com/wikimedia/mediawiki-extensions-OAuthAuthentication/blob/master/utils/Hooks.php#L86 ? [19:44:46] it's missing from the i18n files [19:45:19] csteipp: however far you end up looking into it, could you file a task for monitoring CAS trends? [19:45:25] a link to the remote wiki's email change form, or just some kind of "can't do that" message? [19:46:41] tgr: Oh, that was a warning message saying you didn't have a password, and a password is required to set your email address, so sorry, you're out of luck if you want to set one... [19:47:01] But now that we have private data in OAuth, it should be set from OAuth [19:47:52] So it should say, "This is set from your login on (whatever site), if you want to change it, set it there and it will be updated next time you authenticate" [19:48:12] If the extension is actually updating email now... I forget if I fixed that or now [19:48:16] s/now/not/ [19:54:11] ori: done. https://phabricator.wikimedia.org/T117470 [19:54:21] csteipp: <3 thanks [19:59:05] csteipp: https://gerrit.wikimedia.org/r/#/c/250385/ , but I did not want to bother getting that in a mergeable state since it has to be rewritten after AuthManager anyway [22:44:21] bd808: can I get a quick review on https://gerrit.wikimedia.org/r/#/c/250581/ ? It's needed for something the web team is working on [22:46:53] * bd808 tests [22:50:00] tgr: I'll fix the linter barf if it works otherwise [22:53:42] I'll fix that, that was stupid, I was using [] instead of {} [22:53:49] surprised that even works [22:54:31] [foo => bar] is apparently equivalent to [foo, bar] [22:57:16] puppet's DSL is full of fun stuff like that [22:59:30] tgr: I've got it fixed locally, just retesting [23:02:01] thx [23:02:35] how do you lint puppet locally? I just get a bunch of errors about dependencies not installed when I try rake lint [23:03:05] I did `bundler install; bundler exec rake lint` [23:03:27] my system rake doesn't work with it