[00:29:13] <Reedy>	 Why do I feel like progress is being impeded by stupid things
[04:12:11] <greg-g>	 welcome to the world
[15:30:59] <Reedy>	 bd808: What was the resolution of that php reference/value hook bug?
[15:31:04] <Reedy>	 Relax the check in core?
[15:32:17] <Reedy>	 https://github.com/wikimedia/mediawiki/commit/cdc50e9029f9781958bec0318ca743265f6a11d7
[15:43:09] <bd808>	 Reedy: yeah. The throwing of exceptions there was new and we just ripped it back out
[15:43:23] <Reedy>	 heh
[15:43:28] <Reedy>	 How new? :P
[15:43:36] <Reedy>	 I just backported to 1.25 and 1.26
[15:43:55] <Reedy>	 Do I need to do 1.24 and 1.23 too?
[15:43:55] <bd808>	 I was added like a week before
[15:44:17] <Reedy>	 User reporting it in #mediawiki in 1.25
[15:44:21] <bd808>	 so it was new in 1.27 to error on that particular issue
[15:44:31] <Reedy>	 -	 * @since 1.18
[15:45:06] <bd808>	 hmm.. maybe it was just the last 2 conditions that were brand new
[15:45:40] <anomie>	 bd808: Throwing an exception for hook signature mismatches doesn't seem to have been new, looks like it was added in 2010 (r70109)
[15:46:29] <Reedy>	 That sounds vaguely 1.18
[15:47:39] <bd808>	 this was the change that was new in 1.27 that led to looking into all of it -- https://gerrit.wikimedia.org/r/#/c/247952/
[15:48:19] <bd808>	 so the "expected to be a ref" throw was there from 1.18
[15:48:47] <bd808>	 but the "missing arg" and "expects param" were new
[15:48:56] <anomie>	 The new bit seems to have been detecting "Missing argument" and " expects parameter ", which was inexplicably added along with reverting how I0f1c66f2 started passing all *other* errors during hook calls to MWExceptionHandler::handleError.
[15:49:56] <bd808>	 Apparently Aaron didn't like how many AbuseFilter related things ended up in the error log
[15:56:09] <anomie>	 So the situation now is that with Zend PHP, if someone screws up the reference status of parameters in a hook function that function will just not be called (with a PHP warning maybe logged) and MediaWiki execution will happily continue.
[15:56:59] <Reedy>	 Well, that's a complete set of backports done
[15:57:22] <Reedy>	 1.23->1.26
[15:57:23] <anomie>	 With HHVM, however, the hook function will still be called.
[20:15:25] <bd808>	 tgr: should we try to get our longer meeting time back since the showcase ended early?
[20:23:02] <tgr>	 bd808: is that 12:30-13:30?
[20:23:12] <bd808>	 yeah
[20:23:15] <tgr>	 sure, i'll see if the room is empty
[20:23:17] <bd808>	 up to you
[20:23:23] <bd808>	 cool
[21:35:26] <Reedy>	 [21:27:50] <AaronSchulz> jynus: hi, will you get a chance peek at https://gerrit.wikimedia.org/r/#/c/256875/ today/soon?
[21:35:26] <Reedy>	 [21:35:04] <-- jynus (~jynus@wikimedia/JCrespo-WMF) has quit (Quit: Leaving)
[21:35:27] <Reedy>	 hahah