[12:18:05] https://github.com/hhvm/oss-performance/pull/57#issuecomment-165632845 [12:18:06] lol [15:11:21] Deskana|Away: Regarding the CirrusSearch completion suggester, does the plan for taking it out of beta status include killing the "cirrus-suggest" API module in favor of making the completion suggester be the implementation behind action=opensearch when Cirrus is installed? [20:59:24] AaronSchulz: do you have a few minutes on this friday afternoon to think about file uploads, and how hopeless they are? https://phabricator.wikimedia.org/T121874#1891515 [21:06:10] RC rows are deferred to avoid contention and wasting time blocking the request. I wouldn't want to change that. It seems like passing the tags "all the way down" is the best in way in theory...though the current code probably makes that uglier than it should be. [21:07:43] hmm, fair enough. [21:08:20] AaronSchulz: and now to raise the bar - what if i wanted to add tags from the UploadComplete hook? [21:08:44] i supposed i'd have to introduced a BeforeUploadComplete, and call that hook before LocalFile::upload() [23:42:19] Hmm [23:42:24] DonationInterface has their own vendor repo [23:42:42] committed in place