[04:39:05] <Leah>	 ori: Pull-to-refresh for mobile seems kind of silly.
[04:41:06] <ori>	 swipe to revert!
[04:43:14] <Leah>	 Heh.
[08:47:32] <Reedy>	 left to revert, right to thank?
[16:26:39] <bd808>	 anomie: have you seen https://phabricator.wikimedia.org/T124406 yet?
[16:27:17] <anomie>	 bd808: Been working on T124409 all morning
[16:27:33] <bd808>	 fun
[16:28:04] <bd808>	 I'll see if I can reason about the other one. (is null in CA query)
[16:49:35] <bd808>	 If UserInfo is created with a null User then UserInfo->getName() will return null
[16:49:35] <bd808>	 which looks to be what is getting to CA's onSessionCheckInfo hook
[16:49:42] <bd808>	 That hook blindly creates a CAUser using whatever $info->getUserInfo()->getName() returns
[17:09:30] <anomie>	 bd808: Seems likely. Are you doing anything with that, or should I fix it?
[17:09:46] <bd808>	 anomie: I put a patch up
[17:09:58] <bd808>	 anomie: https://gerrit.wikimedia.org/r/#/c/265759/
[17:10:17] <bd808>	 suggestions on making it better welcome
[17:10:59] <anomie>	 bd808: Looks good to me. But I'm going to grep for any other places where that's being done before +2ing.
[17:11:09] <bd808>	 I wondered if there are other shitty usernames that might show up too
[17:11:14] <bd808>	 like false
[17:12:24] <anomie>	 bd808: Code I just added in includes/session/CentralAuthSessionProvider.php line 198 needs the same treatment.
[17:12:45] <anomie>	 That looks like it, if you want to add that to your patch I'll +2
[17:13:01] <bd808>	 cross-repo patching? ;)
[17:13:19] <anomie>	 ?
[17:13:19] <bd808>	 oh CA, never mindh
[17:13:25] * bd808 can't read today
[17:16:33] <legoktm>	 good morning
[17:16:44] <bd808>	 morning legoktm 
[17:57:49] <MatmaRex>	 AaronSchulz: re https://phabricator.wikimedia.org/rMW0b3e2ff21f133fc24a0b39260217c798abc82a59 - would the old code fail to purge the pages correctly under some circumstances? (or was this just cleanup?)
[17:57:55] <MatmaRex>	 (or anyone who knows how WANObjectCache works)
[19:13:07] <AaronSchulz>	 the old code would basically have done nothing meaningful
[21:32:16] <anomie>	 tgr|away, legoktm, anyone: Review of https://gerrit.wikimedia.org/r/#/c/265799/ would be nice so I can get T124468 fixed before I'm done for the day.
[21:32:26] <legoktm>	 looking
[21:33:12] <legoktm>	 > a new global object
[21:33:15] * legoktm cries
[21:33:28] <anomie>	 legoktm: Do you have a better suggestion?
[21:34:04] <tgr>	 anomie: on phone but virtual +2
[21:34:05] <legoktm>	 nope!
[21:34:13] <legoktm>	 +2'd
[21:34:18] <anomie>	 thanks!
[21:36:24] * anomie is about ready to eat breakfast, shower, and so on after dealing with one "unbreak now!" bug after another all day. ;)
[21:58:26] <anomie>	 Ok, I'm out. If more stuff is broken, I hope someone else can fix it ;)
[22:18:15] <legoktm>	 AaronSchulz: is there an easy way/script I can re-queue a bunch of abandoned jobs? context: https://phabricator.wikimedia.org/T124441#1956519 the exception is now fixed, just needs re-running
[22:34:39] <legoktm>	 I guess I could use JobQueueGroup::singleton()->getQueue('MassMessageJob')->getAllAbandonedJobs() and repush them all?
[22:34:55] <legoktm>	 just get*()