[00:50:19] TimStarling: https://gerrit.wikimedia.org/r/271452 [05:02:33] legoktm: I don't think most people do that. [05:12:32] still needs review [05:40:13] Leah: maybe not intentionally, but unless you explicitly disable it, touching LocalSettings.php will bump $wgCacheEpoch, and most MW upgrades require you to change your config in some way [05:41:40] I couldn't remember if that was a Wikimedia hack or not. [05:41:44] The mtime thing. [05:43:16] $wgCacheEpoch = '20130601000000'; [05:43:18] Hm. [05:43:53] if ( $wgInvalidateCacheOnLocalSettingsChange ) { [05:43:53] MediaWiki\suppressWarnings(); [05:43:53] $wgCacheEpoch = max( $wgCacheEpoch, gmdate( 'YmdHis', filemtime( "$IP/LocalSettings.php" ) ) ); [05:43:53] MediaWiki\restoreWarnings(); [05:43:53] } [05:46:33] And Wikimedia sets that to false? [05:46:59] Yeha [05:47:01] Yeah* [05:47:08] I guess Wikimedia also doesn't use LocalSettings.php. [05:47:44] https://noc.wikimedia.org/conf/highlight.php?file=CommonSettings.php [05:48:02] * On high-traffic wikis, this should be set to false, to avoid the need to [05:48:03] * check the file modification time, and to avoid the performance impact of [05:48:03] * unnecessary cache invalidations. [05:48:20] I was just looking at https://phabricator.wikimedia.org/rSVN77878 [05:48:32] I remember that change, I didn't remember the new $wg variable. [05:50:37] I run update.php after running "git pull" to update mediawiki-core.git, but I don't deliberately touch LocalSettings.php. [06:11:23] wfSetVar, what a bad idea [06:11:37] we don't need syntax, let's write lisp [06:34:48] ApiParse::makeParserOptions() calls WikiPage::makeParserOptions() which calls ContentHandler::makeParserOptions() which calls one of three factory methods, depending on the type of the $context parameter: if IContextSource, ParserOptions::new FromContext(); if User, ParserOptions::newFromUser(); if 'canonical', ParserOptions::newFromUserAndLang(). [06:38:12] all of which call ParserOptions::_construct, which calls ParserOptions::intializeFromUser, [14:44:17] Damn, the new Phab workboard UI wastes a lot of space. [14:49:05] * anomie updates his greasemonkey thing to change lots of margins and padding, and so on. [15:46:08] anomie: on the plus side the workboard cards now shows other projects attached to the card