[18:35:48] anomie: I asked AaronSchulz the following question and didn't get a reply -- but maybe you know: [18:36:12] 21:32 ori: AaronSchulz: what *exactly* is the relationship between ObjectCache and BagOStuff? The interfaces are nearly identical but there is no common ancestry. [18:36:12] 21:35 ori: For example, anomie added a CachedBagOStuff class, which wraps a BagOStuff backend. It could just as easily wrap an ObjectCache instance, were its constructor's $cache parameter not typed to BagOStuff [18:37:01] you can see where I'm going with this: I'd like to use CachedBagOStuff in User.php (as you suggested) to rectify the defect in my patch to deduplicate lookup [19:34:03] ori: Uhh, ObjectCache is a class with only static methods. Were you referring to WANObjectCache? In which case my answer is "I was wondering the same thing, ask Aaron". [20:03:22] anomie: ori : BagOStuff has a too broad abstract interface, many methods of which are conceptually incompatibel with a scalable multi-DC backend. As such WANObjectCache couldn't implement BagOStuff. [20:03:30] However we might be able to define a subset. [20:04:12] (mostly from memory when I asked Aaron the same question last year) [20:04:30] nod [20:39:41] anomie: Could you work on the core changes around https://phabricator.wikimedia.org/T127920 perhaps? It's the easiest/last blocker for RL no-session. I could do CR (or otherway around, if you're willing to review/merge/deploy with me) [20:48:01] Krinkle: IMO it's not really a blocker at all, since we cleaned up all the existing code to call ->inLanguage(). T127920 would mean we don't have to wait for a new Wikidata extension build with the fix to the Wikibase extension, which is the one thing blocking https://gerrit.wikimedia.org/r/#/c/273372/. If you want to make a patch, I'll review. [20:48:01] T127920: Let Message class use appropiate user language based on entry point - https://phabricator.wikimedia.org/T127920 [21:00:53] anomie: maybe we worked around three random instances that popped in the log, but "the code" in general doesn't use this pattern of explicitly stating inLanguage. There are more instances out there. And also probably a few unknowing pending in CR that add more instances [21:00:58] I'll make a patch thanks [21:02:30] Krinkle: I don't know about pending in CR, but we didn't find the existing instances through checking logs. We found them by me looking through everything that subclasses ResourceLoaderModule or implements the 'ResourceLoaderGetConfigVars' hook in deployed extensions. [21:02:56] Checking logs is step 2 (: [21:08:11] i need help from somebody not easily discouraged by paranormal events [21:08:19] i am looking at https://commons.wikimedia.org/wiki/Category:Pastorie_Sint_Servatiuskerk,_Schijndel at the moment [21:08:27] there seems to be a single page in this category [21:08:52] i can't figure out why it's showing there. the page doesn't have the category on it. the database's telling me that the page is not in this category. [21:09:09] there doesn't seem to be any caching of this that would explain it. [21:09:28] i need an explanation before i go crazy. [21:10:05] note that this page (which is in the File namespace) is displaying as an ordinary page under the headings for pages, rather than as a file (which would be an image thumbnail under separate heading) [21:13:10] MatmaRex: https://commons.wikimedia.org/w/index.php?curid=38058376. You might need to delete it via the API with the pageids parameter, I forget if the web UI deletion will get confused by the invalid title. [21:13:35] huh. [21:15:47] MatmaRex: Likely left over from https://phabricator.wikimedia.org/T87645 [21:26:19] anomie: thanks, i instructed someone how to delete it using the wonderful new apisandbox :) [21:27:27] MatmaRex: Speaking of which, did you see T128277? [21:27:28] T128277: Return Special:ApiSandbox to the old design or provide an option to switch to it in preferences - https://phabricator.wikimedia.org/T128277 [21:29:18] anomie: nope [21:46:33] anomie: tell you what, the double scrollbars are annoying me too. https://gerrit.wikimedia.org/r/273980 [21:46:49] (please link that with a relevant task, if any) [21:47:26] anomie: i'm also not sure if i've caught all the cases where we change the amount of content within a page [21:47:51] MatmaRex: When you add enough stuff to a CapsuleMultiSelectWidget to make it wrap onto a new line? [21:48:16] (that kind of stuff is why I didn't bother with trying to resize to fit the content) [21:48:53] anomie: hmph, true [21:50:12] could probably do .on( 'change', ApiSandbox.resizePanel ), on any input widget [21:51:04] MatmaRex: addDynamicParamWidget and removeDynamicParamWidget (lines 1072 and 1068)? [22:18:39] anomie: done