[17:06:10] bd808, tgr: https://gerrit.wikimedia.org/r/#/c/278310/ for your consideration [20:33:11] ori: cool. I'll update the Firefox plugin [20:52:52] ori: new version uploaded to mozilla for approval. https://github.com/wikimedia/FirefoxWikimediaDebug/releases/tag/v0.6.1 [20:59:21] anomie: https://gerrit.wikimedia.org/r/#/c/277778/ feels really hacky. [21:00:58] legoktm: It is, somewhat. But the alternatives are to undeprecate action=tokens and have hackiness and duplication there, or undeprecate action=login returning "NeedToken" responses, which is the same sort of thing we got rid of in a few other modules years ago. [21:03:55] I was wondering more if there was a better way to override the isReadMode() check by seeing if the only instantiated module is ApiQueryTokens instead of looking at the url parameters [21:05:54] We'd need to check the URL parameters anyway to avoid stuff like action=query&titles=foobar&export=1 that doesn't instantiate any submodules. It seemed safest to me to just whitelist exactly the parameters that are needed for this situation. [22:32:20] bd808: hah, you're fast! thanks [22:33:23] ori: only fast because I had just done it and remembered all the steps :) [22:34:02] bd808: if you have some cause to update it again, it'd be good to maybe add a small '?' link that points to https://wikitech.wikimedia.org/wiki/X-Wikimedia-Debug [22:34:38] but it's not worth updating it just for that [22:35:38] yeah. There's a link in the README but having one in the add-on would be nice [22:36:06] I was thinking of adding an indicator to the button of what flags are active too [22:36:26] * bd808 will save that for some day when he's bored