[01:48:17] 10MediaWiki-Core-Team, 10MediaWiki-Unit-tests: Fatal error: Argument 1 passed to AbstractContent::getParserOutput() must be an instance of Title, null given - https://phabricator.wikimedia.org/T131039#2154252 (10kaldari) [15:29:34] "An error occurred while loading the API query response: HTTP error: undefined." [15:29:35] Sigh [15:31:12] (from the api sandbox) [15:32:41] * James_F blames an extension author. [15:33:10] James_F: Blaming the author of EducationProgram!? [15:33:42] It's not the only extension with issues. [15:33:46] lol [15:33:49] * Reedy grins [15:34:17] https://phabricator.wikimedia.org/T131057#2154736 was fun to write. Don't want to spook the horses. [15:35:06] > var_dump( EducationProgram\Courses::singleton()->updateSummaryFields( null, array( 'id' => 111 ) ) ); [15:35:06] NULL [15:43:38] fuck this shit [20:30:30] Krinkle: if you haven't checked your email recently, there are replies to your wikitech-l/ambassadors email about wikibits [20:32:20] MatmaRex: Yeah, saw. Not too worried. Like I said, I'm mainly worried about the large body of obsolete globals that have no future. [20:32:51] meh. have fun handling the importScript fallout then [20:33:02] addPortletLink, importStylesheet/importScript* are highly used, well supported and totally valid. They're just outdated shortcuts. I have no objection to keeping them around, perhaps even indefinitely. [20:33:08] There is no fall out. [20:33:28] meh [20:34:33] importScript is imho an anti-pattern that creates fragile dependencies and unreliable code that isn't very portable. We should not encourage its use and as such I am reluctant to "just" move it to mw.loader as-is. mw.loader is already a viable alternative. Constructing such a url isn't too hard, especially for the relevant audience in particular. [20:34:54] However since it has every little added value to remove it, it's best to keep around as alias. [20:35:28] Although one coudl wonder how many .js pages containing importScript() are already broken in other ways (and as such just fatal either way). [20:35:44] My main beef is about the other 99% of wikibits. [20:36:16] and about it being a separate run-time discovered dependency which is terrible. [20:37:12] I'll add some replies later. [23:00:06] https://github.com/blog/2131-git-2-8-has-been-released