[12:49:18] <Reedy>	 "<?xml version=\"1.0\"?><api><warnings><login xml:space=\"preserve\">Fetching a token via action=login is deprecated. Use action=query&amp;meta=tokens&amp;type=login instead.</login></warnings><login result=\"NeedToken\" token=\"43c087b5ed074ea5f597cd1fc596a36c56fe6df2+\\\" cookieprefix=\"enwiki\" sessionid=\"REMOVED" /></api>"
[12:49:33] <Reedy>	 anomie: Any idea why I'm getting needtoken and that warning, when I'm passing the token?
[12:50:01] <Reedy>	 Which has only just been retrieved a few seconds before
[12:50:27] <Reedy>	 It seems to be some race condition...
[12:50:48] <Reedy>	 I can trigger it if I login with AWB, login in the browser, and then login again with AWB (in vaguely the same session)
[12:52:18] <Reedy>	 Hmm. I can repliate it with logout in AWB and login again
[12:52:24] <Reedy>	 Ignoring the browser part
[12:52:31] <Reedy>	 But login, login, login etc, works fine
[12:52:39] <Reedy>	 I wonder if we're caching something
[12:58:15] <anomie>	 Reedy: In the non-race case, are you fetching a new login token for the second login or are you reusing the old login token?
[12:58:28] <Reedy>	 nope, always fetching a new token
[12:58:59] <Reedy>	 https://github.com/reedy/AutoWikiBrowser/blob/master/WikiFunctions/API/ApiEdit.cs#L580 onwards
[13:07:08] <Reedy>	 Like I say, I can repeatedly log in and it's fine
[13:07:17] <Reedy>	 It's when I logout, that it doesn't seem to work again till I restart
[13:07:27] <anomie>	 Reedy: Hmm. Can't reproduce it by going through the login-logout-login process with curl. Can you capture the requests and responses (with full headers) going on when it fails?
[13:07:28] <Reedy>	 Which suggests we're doing something funky somewhere
[13:10:13] <Reedy>	 bd808 just suggested it's probably cookies
[13:10:15] <Reedy>	 looks likely
[13:13:54] <Reedy>	 Yup, looks to have fixed it
[13:13:57] * Reedy blames MaxSem
[13:38:20] * anomie thought AWB would have had correct cookie handling already
[13:41:35] <Reedy>	 Yeah, Not sure why it only comes up in this weird edge case
[13:42:14] <Reedy>	 var urls = new[] {uri, new Uri(uri.Scheme + Uri.SchemeDelimiter + "fnord." + host)};
[13:42:15] <Reedy>	 Thakns MaxSem!
[13:56:12] <Reedy>	 I guess with the session updates, we're being sent new/additional cookies or something that causes confusion when we start sending htem all back again
[20:09:49] <csteipp>	 dapatrick: Looks like bryan found the issue for T131445. Could you look at adding that hook back in?
[20:09:49] <stashbot>	 T131445: 2FA seems to be broken on wmf.19 - https://phabricator.wikimedia.org/T131445
[20:10:05] <csteipp>	 Stashbot is running here now?
[20:10:23] <dapatrick>	 csteipp: Yep, I'll take a look.
[20:11:02] <csteipp>	 dapatrick: I'm mostly finished with a patch to fix the SUL issue I hit in labs yesterday...
[20:17:09] <dapatrick>	 csteipp: The issue with the oathauth_users table?
[20:20:18] <csteipp>	 Yeah
[20:37:55] <dapatrick>	 csteipp: I have a patch in to add the hook.
[20:38:23] <dapatrick>	 I can't login to labstestwikitech. Should I expect my wikitech creds to work there?
[20:38:50] <Reedy>	 No
[20:38:55] <Reedy>	 Sign up for a new account :)
[20:40:07] <dapatrick>	 Okay, thanks.