[09:58:54] <Reedy>	 "+51, -52"
[09:59:04] <Reedy>	 That counts as reducing code duplication?
[09:59:27] <Reedy>	 Ah, more function comments
[10:02:28] * hoo initially thought the same :P
[10:05:46] <Reedy>	 Jenkins disagrees
[21:25:13] <bd808>	 Still too many bots using the http POST loophole -- https://logstash.wikimedia.org/#/dashboard/elasticsearch/api-feature-usage-http
[21:26:07] <Reedy>	 loophole?
[21:26:39] <Reedy>	 Glad AWB isn't in the list :)
[21:26:49] <bd808>	 we allow http POST requests because there is no safe way to redirect a POST
[21:26:57] <Reedy>	 Ugh
[21:27:24] <bd808>	 there's a phab ticket to close that backdoor
[21:27:51] <bd808>	 https://phabricator.wikimedia.org/T105794
[21:27:59] <Reedy>	 At least one user in that list is on IRC often
[21:28:46] <Reedy>	 Oh, wait
[21:28:47] <Reedy>	 "WikiFunctions ApiEdit/5.8.5.1 (Microsoft Windows NT 6.1.7601 Service Pack 1; .NET CLR 2.0.50727.5485)"
[21:29:28] <Reedy>	 Seems to be one specific user
[21:30:34] <Reedy>	 I wonder if he'd modified the source
[21:32:45] <bd808>	 this frwiki bot seems to be the worst offender -- https://fr.wikipedia.org/wiki/Utilisateur:DickensBot
[21:33:44] <Reedy>	 I've opened a task and assigned it to the AWB offender...
[21:33:59] <Reedy>	 It's curious he's the only one
[21:35:31] <bd808>	 "The official MediaWiki PHP bot framework." -- https://github.com/MW-Peachy/Peachy
[21:35:33] <bd808>	 really?
[21:35:37] <bd808>	 official?
[21:35:53] <Reedy>	 lol
[21:36:38] <bd808>	 I do know that it is officially used by some of the most api abusive bots
[21:42:11] <greg-g>	 coverage: 1%, even worse than MW's!
[21:43:34] <Reedy>	 heh
[21:44:06] <bd808>	 I've been meaning to dig into that lib and cyberbot's usage to see if I can find a fix for the high volume of null edits that bot does
[21:48:31] <bd808>	 here's the data that pchelolo dug up on that -- https://phabricator.wikimedia.org/T128838#2149971
[21:48:46] <bd808>	 looks like its a poorly coded stop button
[21:50:00] <Reedy>	 Do we have a timescale to disable it?
[21:54:06] <bd808>	 the http loophole? no. It's been emitting a deprecation warning for 2 months but we haven't picked a drop dead date
[21:57:51] <MaxSem>	 disable it for a couple hours as a warning?
[21:59:24] <Reedy>	 lol
[21:59:32] <Reedy>	 Just disabling it fully will force them to fix it
[22:54:38] <Reedy>	 bd808: That should be the AWB/WF user fixed
[22:54:55] <Reedy>	 We define WMF projects as default, they decided to do it manually... and set http
[22:54:57] <Reedy>	 oh, ok then
[22:55:47] <bd808>	 nice
[22:56:59] <Reedy>	 https://phabricator.wikimedia.org/T132099#2188739
[22:57:04] <Reedy>	 That sounds... fishy
[23:04:03] <bd808>	 Reedy: but reasons!