[16:26:03] lol. Company taking offence to me outing them for storing passwords in plaint text in the database [17:42:43] tgr: I think I figured out your problem with UTSysop being ping limitable. Working on a fix now. [17:49:32] anomie: was it the upload job test? [17:51:49] tgr: I don't think so. Iec4ed4c8 made it so addCoreDBData() only gets called once, but doesn't do anything about resetDB() clearing out 'user_groups' (there's a hack to make it not clear out 'user'). So after the first test that mentions 'user_groups' in $this->tablesUsed (e.g. any API test), boom, UTSysop isn't a sysop anymore. [17:53:19] tgr: https://gerrit.wikimedia.org/r/282735 [17:55:55] bd808: I think the 10m sleep was a good call, by the way. It's a bad idea to go any deeper and implicitly assume some ownership of the code. Adding the sleep shrinks the problem to a small enough size that we don't need to worry about it. [17:56:30] ori: *nod* totally not my life goal to rewrite that crud [17:59:56] huh, thanks [18:00:04] I doubt I would have figured that out [18:18:45] tgr: Grr. Apparently Echo and Gather both have tests that break if 'user' gets cleared like it's supposed to. [18:19:32] Gather is moribund, you could probably just delete the test without anyone feeling too sad about it. [18:24:30] * anomie tries to use mediawiki-vagrant, but it complains "Could not find gem 'mediawiki-vagrant (= 0.13.2)' in any of the gem sources listed in your Gemfile or available on this machine." [18:25:12] hmmm... have you tried running ./setup.sh anomie? [18:25:24] bd808: That's what it says when I try running ./setup.sh [18:25:34] yuck [18:26:57] marxarelli: ^^ Does anomie's error ring a bell with you? "Could not find gem 'mediawiki-vagrant ..." while running setup.sh [18:27:46] it doesn't [18:27:55] anomie: which version of vagrant? [18:28:06] marxarelli: Vagrant 1.8.1 [18:29:06] hmm... i'm still running 1.7. i'll try to reproduce it [18:31:39] anomie: you could try removing the installed plugins (rm -rf ~/.vagrant.d/plugins.json and ~/.vagrant.d/gems) and re-running setup.sh in the interim [18:32:13] maybe the plugin registry is b0rked for some reason [18:33:06] marxarelli: It installed the "vagrant-vbguest" plugin, but then same error for "mediawiki-vagrant" [18:34:21] marxarelli: If it helps, it also whines about "Warning: this Gemfile contains multiple primary sources. Using `source` more than once without a block is a security risk, and may result in installing unexpected gems. To resolve this warning, use a block to indicate which gems should come from the secondary source. To upgrade this warning to an error, run `bundle config disable_multisource true`." [18:34:23] anomie: kk. i'll look into it. mind filing a task? [18:34:59] marxarelli: I'm just heading into a meeting, then other stuff for the rest of today. Hopefully I don't forget to file it later. [18:35:29] anomie: alright [18:36:09] anomie: oh, what os/distro are you running? [18:37:29] marxarelli: Debian unstable [18:37:39] oh neat :) [18:37:40] thanks [19:24:53] Is is just me that's irked by Services folder being capitalised in includes? :P [19:31:42] Yes. [19:33:00] pfft [19:33:08] * James_F grins. [20:10:54] Reedy: now is the time to fix it, code is pretty new [20:11:08] I'll make a commit [20:13:19] https://gerrit.wikimedia.org/r/282757 [20:15:10] irks me too, +2'd :P [20:22:23] now revert all the things [20:22:51] ugh.