[15:02:25] 10MediaWiki-Core-Team, 06Language-Engineering, 10MediaWiki-extensions-General-or-Unknown, 15User-bd808: Pass-by-reference arguments not passed by reference through StubObject::_call() - https://phabricator.wikimedia.org/T78427#2199031 (10Tgr) [15:20:12] 10MediaWiki-Core-Team, 06Language-Engineering, 10MediaWiki-extensions-General-or-Unknown, 15User-bd808: Pass-by-reference arguments not passed by reference through StubObject::_call() - https://phabricator.wikimedia.org/T78427#844896 (10bd808) Note: the solution here was a one off fix for the `Language::fi... [15:48:05] 10MediaWiki-Core-Team, 06Language-Engineering, 10MediaWiki-extensions-General-or-Unknown, 15User-bd808: Pass-by-reference arguments not passed by reference through StubObject::_call() - https://phabricator.wikimedia.org/T78427#2199294 (10Tgr) Fix is in https://gerrit.wikimedia.org/r/#/c/282953/. Apparently... [18:00:36] anomie: tgr i'll be 3-5 minutes late, wrapping up q3 review [18:01:44] tgr: Meeting? [18:28:08] anomie: tgr|away sorry, conenction bad [18:30:21] anomie: tgr|away connection shoddy [18:30:42] anomie: tgr i was going to say on the styling for templates, probably good to jump in on the phab task(s) if haven't done already [18:30:56] anomie: tgr you linked up with that volunteer? [18:31:10] no [18:31:13] anomie: tgr i think that was coren who we all know and love :) [18:31:16] it was Coren, I think? [18:32:08] I can ping him, although we won't be able to do anything about that before AUthManager is safely in 1.27, anyway [18:32:21] , probably [18:32:23] tgr: yeah, that's right. tgr, given that brion and coren are interested, seems like you've got some people who really know this problem well! but anyway staying involved seems best next step [18:34:27] that's the end of the "to discuss" list - is there anything else we should talk about? [18:34:39] type about [18:38:28] tgr: how do I configure / use the sampling functionality provided by SamplingStatsdClient? [18:49:56] ori: it reads the rate set in StatsdData::setSampleRate [18:50:31] and where are you meant to call that? In the instrumented code, or in configuration code? [18:51:18] so $context->getStats()->()->setSampleRate($x) [18:51:27] which is admittedly kind of crap [18:51:48] because the data object is created whether it gets in the sample or not [18:53:17] you can set a global sample rate on the Client somehow if you want to sample all keys uniformly, I never tried to do that [18:53:32] that would have to be done in ResourceContext I think [19:04:52] doesn't make a whole lot of sense to me, because the value really depends on the installation [19:05:51] sampling MediaWiki.image_cache.hit at 1:100 might make sense for the WMF; for a smaller installation it might make the metric completely useful [19:05:55] *useless [19:34:35] dapatrick: Btw, I tried deploying OATH in beta yesterday, and hit some issue-- users couldn't login, but there were no exceptions/errors in the logs, so I'm not sure what happened. I'm going to add some debugging and try again-- so might need you to review a patch in a bit. [20:01:48] good to know (that you'll mess up beta login again ;) ) [20:49:52] ori: what would make more sense? a per-metric (or per-metric-prefix) sampling rate configuration array? [20:51:36] tgr: yes, but I'd support wildcards [20:51:53] fnmatch()