[14:22:12] bd808: If I give you a list of 26 API parameter names, can you tell me if people are including '#' in the values? Or would it be better for me to just grep the text logs on fluorine? [14:36:56] I think we can do that with a hive query [14:37:21] * bd808 looks at the schema [14:40:18] bd808: The parameters are: adrexcludeuser adruser aiuser arvexcludeuser arvuser bkusers drexcludeuser druser drvexcludeuser drvuser leuser name rcexcludeuser rcuser rvexcludeuser rvuser ucuser user username ususers wlexcludeuser wlowner wluser wrowner [14:45:13] what do you need to know? Just if the values for any of those match /.*#.*/ ? [14:49:36] bd808: Yeah. [14:50:10] Basically, I'm checking if https://gerrit.wikimedia.org/r/#/c/283777/ is going to make people's stuff break [14:51:25] hmmm.. # is apparently a special character in hive queries [14:51:31] * bd808 tries to find out how to escape [14:55:27] anomie: I made a couple queries last week when testing [14:56:34] the signup form username check script will break when someone types a # in the username [14:57:00] but that's already true for other weird characters like .. or unicode control chars [14:57:10] so not sure how much of an issue that is [14:58:55] doh. not special I just have an unterminated string literal elsewhere [14:59:31] tgr: Right now we're just checking for whether people actually are submitting '#' for various user-typed parameters, to see how much I need to worry about people's stuff getting broken by getting an error where they weren't before. [15:00:05] running now for the day of 2016-04-01 [15:02:42] anomie: https://phabricator.wikimedia.org/P2914 [15:02:55] It's not unknown but certainly not very common [15:03:28] Thanks! [15:05:45] anomie: you should get hooked up with the permissions to poke around in this data [15:05:59] Yeah, perhaps I should. [15:06:35] You just need to file an access request like this one -- https://phabricator.wikimedia.org/T115548 [20:40:39] legoktm: I sent email re: 1.27/1.28 branching. <3 [21:19:25] ostriches: https://phabricator.wikimedia.org/project/profile/1946/ :-) [21:38:36] ostriches: thanks :)