[12:33:52] anomie: I merged https://gerrit.wikimedia.org/r/#/c/273373/, do you want to write an announcement or should I? [13:15:43] tgr: I don't have any particular desire to write it. But if you don't *want* to do it either, I'll do it. [13:15:52] Also, \o/ [15:24:39] tgr: Want to give a quick review to https://gerrit.wikimedia.org/r/#/c/287098/ (i.e. make sure I didn't spell something wrong)? [15:26:47] anomie: "it attempted" -> "is attempted", looks good otherwise [15:27:23] tgr: Updated. Thanks (that's why I didn't self-merge). [15:28:18] tgr: So should I write the announcement, or do you actually *want* to do it? [15:33:19] anomie: I don't have any particular desire for it either :) [15:33:29] tgr: Ok, I'll do it [15:33:39] thanks [17:23:48] tgr: What did we decide on, "Special:RecoverAccount"? [17:24:50] anomie: yes, but I would rather put it in a separate patch in case someone wants to bikeshed about it [17:25:06] there is a global and a hook that should probably be renamed accordingly [17:25:23] tgr: ok, if you want [17:28:15] the other pending thing (which I would also rather do separately) is using the Throttler class for the ping limiter [17:30:47] Since that's outside of AuthManager, I agree, a separate patch is probably better. [18:23:35] tgr: Ha, I guessed right. The test failure on https://gerrit.wikimedia.org/r/#/c/280945/ looks like it was probably because using "Password" as a test password was being warned about by password policies. [20:31:22] tgr: Good news: the test wikitech seems to function with AuthManager + my LdapAuthentication patch + my OpenStackManager patch (although OATHAuth blows up, and with https://gerrit.wikimedia.org/r/#/c/253300/ it doesn't seem to inject itself into $wgAuthManagerConfig) [20:41:55] anomie: awesome! [20:42:03] yeah, I didn't make the patch do that [20:42:10] there is a vagrant patch which does it [20:42:50] https://gerrit.wikimedia.org/r/#/c/253302/ [20:43:08] I'm not sure how well providers auto-adding themselves will scale [20:45:10] OTOH, not auto-adding means that everyone upgrading has to add to LocalSettings.php to enable each extension. [20:48:50] what do you think about having $wgAuthManagerConfig default to null, auto-adding to $wgAuthManagerAutoConfig, and copying it over at the end of setup if $wgAuthManagerConfig was not set manually? [20:50:24] The idea being that then the admin doesn't have to worry about putting $wgAuthManagerConfig after all the extensions get loaded? [20:50:24] I might be overcomplicating things, of course [20:50:34] yes [20:50:54] Yeah, that sounds good to me. [22:00:16] anomie, tgr: login is broken for me on beta cluster: https://gist.github.com/MaxSem/75e2c9ec10e6560afcf68ab41c72ca39 [22:00:54] legoktm: ^ [22:03:51] (that's when logging in on enwiki, btw) [22:17:34] MaxSem: see https://phabricator.wikimedia.org/T119736 [22:18:16] it's been going on for a while, no one has the time to look into it apparently [22:18:53] look into why those users disappear, I mean [22:19:14] you can run the maintenance script mentioned in the task to fix them [22:19:29] or I can, I guess [22:24:20] ran it, didn't find anything [22:24:39] maybe a different bug then