[14:34:52] tgr: Why did you rebase https://gerrit.wikimedia.org/r/#/c/288240/ on top of https://gerrit.wikimedia.org/r/#/c/288453/? There doesn't seem to be any dependency relationship there. [14:36:40] huh, not sure [14:36:58] probably just followed the structure of the core patches without thinking [16:40:42] anomie: Chad gave his blessing for the backport into rc0 [16:41:00] apart from the problems with the recaptcha patch, are we missing anything? [17:28:09] tgr: As far as bundled extensions? Not that I know of, although I don't recall the checklist of which extensions are bundled. [17:35:32] anomie: the extension list is https://phabricator.wikimedia.org/diffusion/MREL/browse/master/make-release/make-release.yaml , the only matches with T110282 are ConfirmEdit, Renameuser, SpamBlacklist, TitleBlacklist [17:35:33] T110282: Update extensions which are deployed on the Wikimedia cluster to use AuthManager - https://phabricator.wikimedia.org/T110282 [17:37:32] tgr|away: Well, TitleBlacklist isn't merged yet thanks to the unit test class dependency, but it's otherwise ready to go IMO. Renameuser and SpamBlacklist are done. [18:02:08] bd808, Krenair: do we use master of SemanticForms on wikitech, or is it a different branch? [18:04:59] legoktm: If you have a minute, do https://gerrit.wikimedia.org/r/#/c/195297/172/docs/extension.schema.json and https://gerrit.wikimedia.org/r/#/c/195297/172/includes/registration/ExtensionProcessor.php look right? [18:05:48] anomie: is there an example of what AuthManagerAutoConfig would look like? [18:07:59] legoktm: https://gerrit.wikimedia.org/r/#/c/195297/172/includes/DefaultSettings.php is the default value for it. Extensions would be doing the extension.json equivalent of lines 36-47 at https://gerrit.wikimedia.org/r/#/c/284499/20/includes/CentralAuthHooks.php [18:10:28] yes, that looks correct then. You could add further validation in the schema for the 'class', 'args', 'sort' properties too [18:15:10] legoktm, SemanticForms... master I think [18:15:37] it's not in special_extensions [18:15:50] ok, thanks [21:34:37] * anomie facepalms at the PrivateDomains extension [21:57:01] anomie, so what if it's ugly? it works for someone so its goal is accomplished ;) [21:57:18] MaxSem: ENOCONTEXT [21:57:54] PrivateDomains [21:58:30] It's not that it's ugly, it's that you can trivially bypass it by editing via the API. [21:59:20] we should really kick ourselves then for having two sets og editing hooks ;) [21:59:56] In this case, it's not even that. They hide the edit form on the edit page if you're not allowed, but do nothing to try to prevent actual editing beyond that. [22:49:55] hmm... OutputPageCheckLastModified hook was changed to take two args in includes/OutputPage.php but not in ApiMain.php [22:50:06] anyone knows anything about it? [23:11:54] SMalyshev: uh, probably Roan didn't know that it was also called in ApiMain. [23:12:16] yeah he already posted the patch, thanks [23:15:03] anomie: centralauthtoken's are single-use only, but can you get a batch of them and then send out multiple requests, each using a different token? (https://gerrit.wikimedia.org/r/#/c/288722/ is context) [23:16:03] is it right that language is currently linked to the page's title but not the content? [23:16:37] which language? user language, content language, page language...? [23:16:47] content language I'd imagine [23:17:11] the language the content is in :) I can't find any reference to language in Content interface [23:17:30] there's title->getPageLanguage() but it's on Title [23:17:51] ContentHandler::getPageLanguage( $title, $content = null ) [23:17:57] ahh [23:18:09] ok, that's better :) [23:19:12] still wants Title though... [23:21:13] and looks like it's actually not using $content... [23:21:38] so does Content have language for itself? [23:21:59] I don't think so. [23:22:03] It's Title+Content based [23:22:47] hmm... so how Content plays a role? [23:23:42] it looks it's just uses $wgContLang now basically. Which means it is assumed all wiki content is in one language? [23:28:19] this looks like there could be trouble if we ever get multi-content pages... or work with wikis that do more than one language (like commons or wikidata)... [23:28:47] the interface is written in a way that people can use Content if they want to I think? [23:29:36] well, I'm not sure how - Content interface has no methods for specifying language [23:30:34] and Content can't discover its won language since ContentHandler needs Title for that (and Content doesn't know its Title) [23:45:18] (is there a meme for "I should not have tried to understand that." ? My head hurts.) [23:46:42] quiddity: this one: http://classicprogrammerpaintings.com/image/143064709101 [23:46:49] quiddity, it's really not any more complex that conditional in pure wikitext :) [23:46:59] http://classicprogrammerpaintings.com/post/143064709101/programmer-finds-1395-conflicts-after-git-merge rather [23:47:26] XD [23:47:43] or this: http://classicprogrammerpaintings.com/post/143689360827/junior-developer-after-his-first-day-pablo [23:48:16] glorious. thank you.