[08:31:40] hmm, looks like we missed https://www.mediawiki.org/w/index.php?title=Template:MW_version/status&action=history during the great luafication of version templates :( [15:29:16] tgr: At some point you should probably go through and rename that "authmanager" logging channel to something like "authevents". [15:30:13] anomie: I figured I'd do that (or just discard the whole thing) once AuthManager is safely out [15:30:36] so I don't have to juggle multiple metrics on the dashboards [15:30:48] That's fine, I was just mentioning it. [15:30:54] * anomie thought ostriches and tgr would have https://gerrit.wikimedia.org/r/289498 merged by now [15:31:17] * ostriches mutters something about 99 problems [15:31:18] although I guess I would only have to update WikimediaEvents so I can do it now just as well [15:31:23] (of which this is clearly one lol) [15:32:22] I feel there will be enough torches and pitchforks about that patch without it being a self-merge :) [15:32:41] Mmmm, torches and pitchforks. [17:07:36] ostriches: i backported some Vector and MonoBook skin changes to REL1_27 (https://phabricator.wikimedia.org/T127758). please confirm that they will be magically included in any tarballs and i don't need to worry. :) [17:08:17] If they're in the branch they'll show up [17:08:30] ok. thanks [17:13:51] PHPunit is failing in vagrant for me with centralauth.unittest_globaluser doesn't exist. [17:14:10] Ran vagrant git pull; provision and git-update. [17:14:12] No difference [17:30:32] Krinkle: IIRC the unit testing's creating of temporary tables doesn't happen for CentralAuth's tables if you have CentralAuth pointing to a different database, because it only does it for the wiki's current database. There are some hacks to make it work in Jenkins, look for use of $wgWikimediaJenkinsCI. [17:30:57] phpunit used to work by default in vagrant, what changed? [17:31:27] the CA tests have been messed up forever I think [17:32:19] I have a settings.d/99-phpunit-hacks.php file with if ( defined( 'MW_PHPUNIT_TEST' ) ) {$wgSharedDB = null;} [17:32:21] No idea. CentralAuth has additional hacks for its own tests to work around it too (that were in place before the Jenkins-specific hacks were added), but if anything else being tested gets into CentralAuth it has always blown up like that as far as I know. [17:32:25] I think that's related [17:34:08] Perhaps it's time for someone to add a hook to MediaWikiTestCase to tell it additional databases that need cloning when it's doing the cloning? [17:43:21] Yeah, the DB handling in centralauth was horribly fragile. CentralAuth would need a lot of changes to make it testable with a mock db object. Or mediawiki's testing db setup could be changed to support all the global extensions. [17:46:44] tgr: AuthManager is in wmf2, right? [17:47:29] csteipp: yes but disabled [17:48:18] Cool. Is there a date for enabling it? [17:50:28] csteipp: whenever the blockers in T135504 get done [17:50:28] T135504: Enable AuthManager in WMF production - https://phabricator.wikimedia.org/T135504 [17:50:38] probably week after next [17:53:19] tgr: For T110282, does that mean we're going to merge authmanager changes into all the extensions and enable authmanager at the same time? Or are we going to run the AuthPlugin provider while we gradually update the extensions? [17:53:20] T110282: Update extensions which are deployed on the Wikimedia cluster to use AuthManager - https://phabricator.wikimedia.org/T110282 [17:55:22] csteipp: I would rather wait until the extensions are updated, unless we really need to hurry [17:55:30] the AuthPlugin hack has its limits [17:55:49] e.g. anything that uses AbortNewAccount and reads from the request would break [17:55:52] tgr: Nope, just wanted to understand how you were planning to do it. [17:57:41] csteipp: most extension patches look like this: https://gerrit.wikimedia.org/r/#/c/288902/1/AbuseFilter.hooks.php [17:57:51] so they don't have to be merged exactly the same time [17:58:18] some have been merged already (esp. the ones that will be in the 1.27 bundle) [17:58:32] Makes sense [18:29:22] bd808: anomie: Hm.. so what changed? Was CentralAuth not previously enabled by default in Vagrant? (afaik it wasn't so that's possible). [18:29:34] Or did CA regress and break something by default. [18:36:33] CA still should not be enabled by default [18:36:35] Krinkle: Or it might be that something started hitting one of CAs hooks from a unit test where it didn't before. [18:48:59] bd808: Hm.. ok, I wonder what made it enable for me then. [18:50:39] We don't have any good dependency graph for the various roles. You can see what you have enabled with `vagrant roles list -e` [18:51:05] Anything that wants multiple wikis for testing is likely to enable CA [18:51:17] Flow does for example [18:52:16] Cirrus creates its own wiki, yet needs no CA [18:52:34] (sorry if I missed the context) [18:56:47] Flow is enabled for me, though I didn't enable it. [18:57:04] I enabled ve, navtiming and mobilefrontend. [18:57:08] I guess one of those enables the other. [19:00:38] apparently flow doesn't (at least directly); echo, wikimetrics, globalcssjs do [20:39:34] bd808: I have a patch sitting to get rid of it for GlobalCssJs! https://gerrit.wikimedia.org/r/#/c/264614/ [20:41:22] bah. needs rebase legoktm [20:41:29] * bd808 was going to +2 [20:41:43] sigh. I'll do that now [20:46:37] bd808: rebased :) [21:03:17] thanks :D [23:16:15] csteipp: I just filed T135784 (which I should have done a month ago to get a better place in line) [23:16:16] T135784: Security review of Tool Labs console application - https://phabricator.wikimedia.org/T135784 [23:16:37] The app is a work in progress still but I want to get on your list [23:17:03] I should have a test environment up sometime next week [23:24:46] apparently I should check my email more often :/ [23:36:55] bd808: aww, was just finished fixing that [23:39:55] tgr: to use hiera? [23:40:41] will push a patch in a minute if you have some more review time [23:40:52] yeah, no worries [23:48:13] thanks