[15:29:46] ori: Reviewed the whole thing. [18:14:54] awesome, thanks. looking it over now [18:22:04] dr0ptp4kt, tgr: Do you know if anyone actually owns Campaigns? I started to look at T135043, and the code is confusingly complex (e.g. it sets a JS config var and loads an RL module just to set a cookie) which makes me wonder whether it is that way for a good reason or if it's just overcomplicated. Looking at the history, S (who's no longer with us) seems to be the only major contributor. [18:22:04] T135043: Update Campaigns to use AuthManager - https://phabricator.wikimedia.org/T135043 [18:24:32] anomie: Collaboration, per the Google doc [18:25:00] There's a Google doc? Should someone copy that info into https://www.mediawiki.org/wiki/Developers/Maintainers? [18:27:42] not sure if they use the same definition of maintainer [18:28:06] it's mostly about which WMF team to go to if something breaks [18:28:47] w.g. the two of us officially own PdfHandler in that sense but I wouldn't call us maintainers [18:29:55] Hahaha [18:42:48] Apparently I own "all documentation, including that on MediaWiki.org" [18:42:50] Oh my god. [19:13:21] dr0ptp4kt, tgr: Almost all the blockers of T110282 have patches now. Exceptions: TranslationNotifications, which I'm still hoping Language will look at; JsonConfig, which I'm hoping yurik will look at; and Campaigns, which I complained about earlier. [19:13:21] T110282: Update extensions which are deployed on the Wikimedia cluster to use AuthManager - https://phabricator.wikimedia.org/T110282 [19:14:16] tgr: About Campaigns, am I right in thinking there's currently no sane way to replace what it's doing with the UserLoginForm hook for AuthManager? [19:20:39] anomie: looks like awight or andyrussg might be potentials points of contact for Campaigns (dstrine is the po for fr-tech). [19:20:53] anomie: glad to hear you're making good progress on all of those! [19:22:57] Krinkle: don't worry, you don't only have to maintain all of the documentation, you also get to maintain all of its javascript ;) [19:31:59] anomie: yes, messing with the default template variables is not supported anymore [19:33:20] if someone is actually using that data, I'd say just do it from JS [20:48:29] Krinkle: great, we'll assign bug 1 to you ;) [20:59:48] legoktm: T2001 now [20:59:49] T2001: Documentation is out of date, incomplete (tracking) - https://phabricator.wikimedia.org/T2001 [21:00:44] :< [21:49:15] T1 isn't as exciting [21:49:15] T1: Get puppet runs into logstash - https://phabricator.wikimedia.org/T1 [21:49:23] Though logstash is always exciting [21:49:30] Thanks stashbot for reminding us