[08:12:17] anomie: I thought a bit about the login CTA thing, I could just move everything inside the HTMLForm (use a HTMLInfoField instead of $form->addFooter) and then extensions could mess with it without having to create another hook [08:12:32] (of course if it's not used at all it should be scrapped) [12:18:32] anomie: apaprently there is a single person in WMDE who has rights to update the gemfile registry and he is not responding [12:27:10] We have a few org admins [12:27:29] but only Lydia and Jeroen are on IRC regularly [12:27:36] so Lydia is your best bet [12:38:16] hoo, tried yesterday [12:38:52] I think we can go forward with enabling AuthManager and people can update tests at their leisure [12:39:50] I've put up some temporary workarounds in https://gerrit.wikimedia.org/r/#/c/290855/ and https://gerrit.wikimedia.org/r/#/c/290897/ in case finding the right people is problematic [13:02:21] tgr: So we're ready to try https://gerrit.wikimedia.org/r/#/c/290809/? [13:09:10] anomie: yes [13:09:38] * anomie +2inates [13:09:39] in any case, the gem just got updated [14:43:05] ostriches: hey. yesterday's CentralNotice SWAT deployment is breaking all JS in a bunch of browsers (https://phabricator.wikimedia.org/T136387). can you revert it? https://gerrit.wikimedia.org/r/#q,291120,n,z [14:43:24] ostriches: everyone responsible seems to be still away [14:43:34] greg-g: i dunno if you're around ^ [14:44:15] Krenair: since those two are probably still asleep, maybe you can? ^ it looks like you were the deployer yesterday [14:46:15] I'm awake just not in front of my laptop yet [14:46:45] Gimme like 10m [14:46:51] sure. thanks [14:51:21] reverting [14:53:19] Beat me to it [17:54:36] tgr: I submitted https://gerrit.wikimedia.org/r/#/c/291285/ that should hopefully make the test screwing up UTSysop fail so we can find out which one it is. [17:58:05] thanks! I was going down the CI rabbit hole but this is a lot simpler [18:06:07] I ran core tests locally and they passed (and presumably whatever broke it passed to merge), so I figured this was easier than trying to reproduce locally with the somewhat large pile of extensions that job runs against. If it passes on core, we can use Depends-On on the patch where you reproduced it originally. [18:40:41] tgr: Hmm. It didn't work. [18:44:46] bd808: On the one hand, I love all your pep8 fixes. On the other hand, lazy af...chained them all :P [18:51:00] tgr: We ready to land https://gerrit.wikimedia.org/r/#/c/291227/ on REL1_27? [18:51:12] I think everything was merged to master, just dunno if they were all backported [18:53:15] ostriches: I think se; let me look through one more if there is anything else backport-worthy [19:02:04] tgr: I think https://gerrit.wikimedia.org/r/#/c/291309/ will fix T132411, with that https://gerrit.wikimedia.org/r/#/c/291298/ passes where it failed before. [19:02:04] T132411: UTSysop is not a sysop - https://phabricator.wikimedia.org/T132411 [19:08:07] ostriches: Yeah, that was lazy. :/ [19:08:29] it's called 'efficient' [19:09:16] luckily they shouldn't be interdependent so splitting the chain should be simple [19:09:35] Hehe :) [19:11:33] wow. about half have been merged already [19:11:56] ostriches: I think we are good [19:13:16] Once all that other stuff lands? [19:13:16] :) [19:15:47] ostriches: nothing there is really important [19:16:04] +2 [21:11:55] bd808: To answer your question about being a reviewer on Differential. I found an easier way. Actions dropdown on comment box -> "Resign as reviewer" (which also prompts you to suggest someone else, neat!) [21:47:12] ostriches: oh cool. I wonder if that's new? I looked in the comment options and didn't notice it last week [21:47:29] Maybe? I just noticed it today. Could've been there forever for all I know :p [22:40:58] ostriches: the chain is all broke up now. We are 18 +2s away from a clean flak8 test for ops/puppet [22:41:18] :D