[02:08:43] tgr|away: it gets worse [02:09:21] it turns out that PHP calls SessionHandler::gc() after loading session data, not before [02:10:52] so if you use a BagOStuff that does not evict on get, and that does implement a real deleteObjectsExpiringBefore, the test fails [02:11:06] because the stale session data gets loaded before it is garbage-collected [02:14:46] in other words: not only is the test not actually testing what it purports to be testing, if it were actually testing it, it would fail [13:08:46] tgr: There's no token cookie at all in BotPasswords, all sessions only last as long as the session cookie. The bp_token field is just used to invalidate existing sessions if the user changes the bot password. [16:08:57] tgr: I think all the extension fixes are in wmf.4 except https://gerrit.wikimedia.org/r/#/c/265210/ [16:10:54] ostriches: uhh, forgot about that one [16:11:09] I was just going over the last few to make sure they made it [16:11:13] Otherwise I think we're good :) [16:11:29] I'll do another backport [16:12:46] ostriches: can I grap the current deploy window (16-17 UTC) to do that and deploy https://gerrit.wikimedia.org/r/#/c/289866/ ? [16:14:06] anomie: any objections to switching on in beta? [16:15:19] tgr: Nope. Although I just submitted https://gerrit.wikimedia.org/r/#/c/292167/ for review, and we should probably do something about T136710 and T136000 sooner rather than later. [16:15:19] T136710: Add links to Special:LinkAccounts, Special:UnlinkAccounts, Special:ChangeCredentials, and Special:RemoveCredentials to Special:Preferences somewhere - https://phabricator.wikimedia.org/T136710 [16:15:20] T136000: Unify Special:UnlinkAccounts and Special:RemoveCredentials - https://phabricator.wikimedia.org/T136000 [16:59:55] tgr: And BotPasswords was enabled for zerowiki/JsonConfig, was there anything left to close out on that one? [17:01:20] ostriches: yurik still needs to update the JsonConfig configuration and the zerowiki varnish config fetcher to actually use a bot password, I believe. [17:01:33] * ostriches nods [17:06:09] central autologin seems broken [17:06:16] does that normally work on beta? [17:10:05] tgr: How so? [17:10:58] anomie: log in on en -> go to es -> the checkLoggedIn AJAX call returns not logged in [17:13:23] in any case, I don't see anything that would merit a rollback - no logstash errors, and login/logout/account creation works [17:13:32] will send a mail asking people to test [17:14:32] dr0ptp4kt: just enabled AuthManager on beta cluster, probably should be mentioned in scrum of scrums [17:17:20] tgr: Hmm. It mostly works for me, except it's not auto-creating a local account for me there. [17:17:55] which means you are not logged in [17:18:22] which happens as far as I can see because the checkLoggedIn request gives the wrong answer [17:18:45] I wouldn't swear this hasn't existed before the AuthManager rollout, though [17:19:17] tgr: checkLoggedIn is working for me. It gets all the way to setCookies, which complains about no local account. [17:27:26] tgr: thanks for the heads up [17:52:02] tgr: "there are some new special mages" :D [17:52:21] MW needs more mages [18:34:51] tgr: https://gerrit.wikimedia.org/r/#/c/292196/ should fix my problem with CA auto-creation on beta labs. Not sure if it'll fix yours too. [20:04:36] Hm.. it seems PrefixIndex is broken in production. [20:04:37] https://az.wikipedia.org/w/index.php?title=X%C3%BCsusi%3APrefixIndex&prefix=&namespace=8 [20:04:44] it's supposed to show a 'next page' link somewhere [20:04:48] since there is definitely more pages than that [20:04:55] for example "Monobook.js" is not listed [20:05:04] It shows up with https://az.wikipedia.org/w/index.php?title=X%C3%BCsusi%3APrefixIndex&prefix=M&namespace=8 though [20:06:44] https://phabricator.wikimedia.org/T18434 [22:31:14] do we have some provision for unit test to remporary define hook so it would be removed after the test has run (i.e. on tearDown)? [22:32:32] robla: feel free to ping when ready, I'm interruptable now [22:34:19] thanks. I'll PM to coordinate [22:49:00] SMalyshev: setMwGlobal [22:49:21] tgr: aha, thanks... but that's not hook-specific I imagine [22:49:55] i.e. it needs some code to work with hooks. Maybe mergeMwGlobalArrayValue [22:52:54] SMalyshev: https://github.com/wikimedia/mediawiki-extensions-ConfirmEdit/blob/master/tests/CaptchaPreAuthenticationProviderTest.php#L291 is what I used [22:53:45] tgr: looks good. I think maybe I add it to MediaWikiTestCase? [22:54:53] one thing is hook doesn't have to be callable, strictly speaking, IIRC. But doesn't matter for my case