[15:37:58] ostriches: OK to backport https://gerrit.wikimedia.org/r/#/c/293975/1 to REL1_27 after it's merged? (documentation-only change, followup) [15:38:41] Sure. [15:38:58] I'll probably tag the branch around lunch time, do any last minute backports this AM [15:40:44] tgr: Did anyone ever finish the cleanup for T135656? [15:40:45] T135656: GlobalRename is broken, presumably due to authmanager changes - https://phabricator.wikimedia.org/T135656 [15:43:22] anomie: not that I know [15:45:17] tgr: Any objection to me just deleting the rows for those 17 stuck renames, and relying on people to tell us if anything else about them is still broken? They all look to be *actually* renamed already. [15:46:06] s/17/16/ [15:46:29] none, my understanding is the errors are caused by the rename process breaking just before updating the job status so that should work [15:47:37] thanks for taking care of that; I completely forgot that those people still cannot log in [18:10:10] MaxSem: T137509 :) [18:10:11] T137509: Installer without mbstring installed fatals before the environment checklist - https://phabricator.wikimedia.org/T137509 [18:10:22] yeaaaah [18:10:27] Krinkle: T131318 :) [18:10:27] T131318: Minor issues with 'mediawiki.checkboxtoggle' module - https://phabricator.wikimedia.org/T131318 [18:10:37] not forgotten [18:12:45] And I guess I gotta finish figuring out what's up with that findHooks regex. [18:12:49] That's an ugly ass regex. [18:20:47] ostriches: yep, my day starts in 1 hour :-). First thing! [18:21:01] Thank youuuuuu [18:23:48] ostriches: Is that [ugly ass-regex] https://gerrit.wikimedia.org/r/#/c/293874/? [18:28:56] Yep that one [18:33:11] ostriches: Commented. [18:40:47] anomie: Worked! [18:40:51] vagrant@mediawiki-vagrant:/vagrant/mediawiki/maintenance$ php findHooks.php [18:40:51] Undocumented: AbortChangePassword [18:40:51] Undocumented: LoginPasswordResetMessage [18:40:51] Undocumented: PrefsPasswordAudit [18:40:51] The script finished with errors. [19:11:56] ostriches: those are removed by the same patch that removes $wgDisableAuthManager [19:12:16] Mainly was just making sure the script worked [19:12:26] Kinda convenient they were there because no output would be worrying :p [20:47:40] Any postgres fans want to fix AbuseFilter for it? https://gerrit.wikimedia.org/r/#/c/191947/ has been in need of a reviewer for 16 months (apparently broken since REL1_20). [21:20:29] Krinkle: We good with the backport? :) [21:26:09] MaxSem: Last call on mbstring plz. [21:26:30] uh, we're doing an rc today ostriches? [21:26:36] Today is the final release. [21:27:36] the commit is ready, I just keep on trying to build php without mbstring [21:28:11] Put the commit up for review. [21:28:23] ostriches, does it need release notes? [21:28:36] Probably not, it was a regression within this cycle. [21:29:51] https://gerrit.wikimedia.org/r/294172 [21:35:04] In theory that could be too late to set it, but it's probably fine in practice. [21:35:20] Would require someone to do something kind of ugly in a config callback [21:38:34] it would be scary if we accessed Language so early in initialization when LC is not initialized. luckily, we don't [21:39:10] accidentally committed this into REL1_27 :P [21:42:21] legoktm: Can I get a review? https://gerrit.wikimedia.org/r/#/c/293874/ [21:47:15] MaxSem: lgtm, I'll merge. [21:48:05] version for master: https://gerrit.wikimedia.org/r/#/c/294177/ [21:48:20] also sorry, didn't realize time's pressing [21:48:50] ostriches: looking now [21:50:09] MaxSem: It's ok. It should've been out a few weeks ago tbh [21:50:13] But AuthManager had to land :) [21:52:18] ostriches: yay +2'd [22:07:30] tgr|away / ostriches / legoktm: https://phabricator.wikimedia.org/T135498 can be closed now? [22:08:07] That only leaves https://phabricator.wikimedia.org/T131318 which I'm minded to say "oh well". [22:09:39] Meh, it's fixed enough imho [22:10:01] ostriches, so we're releasing AM a wek after it went live? [22:10:19] Something like that yeah [22:10:32] what could possibly go wrong? :P [22:11:00] Other option is waiting until the 27th [22:11:24] Today, tomorrow, or 27th or later :) [22:13:18] I'm super confident about that patch I couldn't test, however it just tells people they're screwed slightly nicer [22:16:57] I'm still nervous about AuthManager. [22:17:03] Just because it's big and critical. [22:17:46] ostriches: It's not going to get more fixed between today and tomorrow. Production for a week… [22:18:05] ostriches: do we have usage statistics about how many people have been testing out the rc? [22:18:13] That I can check! [22:18:22] The RC shipped without AM though? [22:18:33] Yeah [22:18:44] So, less useful stats. [22:18:59] bleh, no root on bromine, can't check apache req logs [22:19:04] Er, I think we should have an rc with AM then? [22:19:11] That's my thinking. [22:19:14] Otherwise it really wasn't a release candidate... [22:19:20] Do RC.1 with AuthManager. [22:19:28] Let it stir 2 weeks [22:19:35] (And people, plz test that shiz for once) [22:19:42] Then release like the 27th when I'm back [22:19:59] It'll be late, but I'll feel better about it since we're putting LTS on the box. [22:20:57] Thoughts anyone? [22:21:09] +1 [22:21:41] Better a few weeks late than horribly broken :p [22:22:05] https://wikiapiary.com/wiki/Generator:MediaWiki_1.27.0-rc.0 [22:22:07] +1 [22:22:38] I'm planning to upgrade a few wikis tomorrow to 1.27.whatever [22:22:53] I'll do the RC.1 today then [22:22:56] Shouldn't take too long [22:23:39] ostriches, I can dig that up in hive [22:23:57] I'm not too worried, wikiapiary only says 6 wikis [22:27:30] Who can click +2 the fastest? https://gerrit.wikimedia.org/r/294182 [22:28:36] gold star for legoktm [23:13:33] ostriches: Thx, good to go [23:54:06] heh [23:56:24] ostriches, I finally tested it - still crashes :P though nothing really new, it also crashes from the lack of ext-xml, for example. guess we'll have to stick to plain unlocalized error messages early in installer? [23:58:01] Could work [23:58:57] The installer sanity checks can only check for you if you've got enough sanity checks passing to get that far 😝 [23:59:39] ostriches, also my query finished: we had 614 downloads of mediawiki-1.27.0-rc.0.tar.gz