[00:00:43] MaxSem: More than I thought. [00:00:48] Ok, rc.1 is needed. [00:18:48] MaxSem: The check for mbstring.func_overload is useless too. [00:18:53] We already fataled at the top of WebStart. [00:19:59] actually, for me it crashes on the first attempt to parse wikitext in messages [00:22:04] * ctype [00:22:04] * iconv [00:22:04] * json [00:22:04] * mbstring (new requirement in 1.27) [00:22:04] * xml [00:22:08] Listed as required. [00:22:23] We should check those early in WebStart and other entry points and bail hard and fast. [00:22:41] Rather than pretending we're ok until something randomly dies. [00:23:29] make it part of the php version check? [00:23:34] Heh, I wonder if update.php even does the env checks. [00:23:51] You could very easily be running an existing wiki with a now-invalid form of PHP secretly. [00:24:06] legoktm: That's probably the best. [00:24:17] Puts it in one place, self-contained. [00:29:04] curl is another extension that is needed once you use any feature that makes HTTP calls [00:29:06] like VE [00:49:24] gwicke: No, we have fallback using file streams and such. [00:49:30] But curl is better. [00:49:35] (and installer suggests it. [00:50:23] I'm pretty sure MultiHTTPClient depends on curl [00:51:12] Yeah, curl should probably be made required. [01:04:00] legoktm, MaxSem: https://gerrit.wikimedia.org/r/#/c/294209/ [01:04:07] * ostriches wanders off for dinner & such [01:19:08] yeah it needs php5-curl IIRC [01:19:54] php7-curl [01:20:00] php7.0-curl [01:33:25] or that [02:07:11] Funny, most version checks in maintenance scripts are pretty useless. [02:07:22] At least for major versions [02:07:30] Would've failed to parse before we hit the check [02:07:35] Entry points are fun [07:05:48] Done: https://gerrit.wikimedia.org/r/294259 [07:12:09] bd808: I managed to get a core dump and bt for the segfault, but I'm not sure how to debug further... https://phabricator.wikimedia.org/P3239 [13:38:27] SMalyshev: hey, wanna check out https://github.com/php/php-src/pull/1943 (fix for https://phabricator.wikimedia.org/T97253)? it's an updated version of your patch from a year ago, perhaps you could merge it :) [13:44:02] tgr: I posted a patch for T137799 [13:47:54] ouch. [14:58:35] tgr: Should we also cherry-pick https://gerrit.wikimedia.org/r/#/c/294312/ to CA's REL1_27 branch? [15:41:48] tgr: https://gerrit.wikimedia.org/r/294337 [16:38:35] Aww, no MaxSem [16:40:32] ostriches: https://gerrit.wikimedia.org/r/#/c/294352/ ? [16:41:35] anomie: lol. +2 [16:45:19] anomie: https://gerrit.wikimedia.org/r/#/c/294222/ ? [16:49:00] ostriches: +2 [16:49:10] ty [17:04:38] James_F: I left a comment on your curl change, we should discuss first :) [17:04:42] Like Max did for mbstring [17:05:58] I think it's probably fine, but bumping requirements is always a discussion :) [17:06:20] fine insofar as "most people probably already have it, and it's packaged for basically every distro ever if you need it" [17:07:45] It's a MaxSem! [17:08:21] MaxSem used Deprecation Notice! It's super effective! [17:08:22] * MaxSem hides [17:08:46] ori: Critical Hit! [17:08:52] mbstring fallbacks have fainted! [17:09:34] MaxSem: Was hoping for a final review on https://gerrit.wikimedia.org/r/#/c/294209/. Would like to get it into REL1_27 and tag that rc.1 today [17:09:45] I can't think of anything else I *must* get into the rc [17:12:51] ostriches: patch looks good, I can test it in a little bit, my only suggestion would be to get a list of all the missing extensions first and include all of them in the error message instead of failing on the first missing one? [17:13:28] Hmm. [17:14:45] Heh, will have to use array() syntax, this file has to be parseable by old versions of PHP too [17:14:57] (technically 4.x, but I'm proposing to remove that tbh) [17:16:26] we can add an exclusion for the phpcs rule for that file [17:16:58] https://github.com/wikimedia/oojs-ui/blob/master/phpcs.xml#L11 [17:20:20] Yeah I'm doing it [17:20:23] WIP [17:20:42] I can just use the @codingStandardsIgnore blocks [17:20:45] We already do that in this file [17:46:34] ostriches: Meh. OK. :-) [17:48:28] legoktm: Working on it, heh. https://phabricator.wikimedia.org/F4165689 [18:12:33] How do I fix this lol? [18:12:48] I feel like my fix would be kludgy and only affect my browser, I think it's some -webkit rule [18:15:17] woot [18:15:40] ostriches: get rid of the text-align: center, wherever that's coming from :P [18:42:44] Ok I'll wrap this up after the train [18:43:45] MatmaRex: Ah, body is centered for the top image. [18:49:24] SMalyshev: yay, thanks for the merge. i wonder how much of a pain would be to deploy that PHP patch in our production? [18:50:15] MatmaRex: well, our prod runs on hhvm IIRC so we need to see if we need to patch hhvm code to do the same [18:51:23] legoktm, MatmaRex: Amended. [18:54:44] MatmaRex: somewhere around here I assume: https://github.com/facebook/hhvm/blob/ea6ff01f6c31f1615a935ef96622d623a6277d37/hphp/runtime/ext/gd/ext_gd.cpp#L6584 [18:59:01] hm [19:02:48] Huh. Apparently gerritbot got confused by https://gerrit.wikimedia.org/r/#/c/294358/ and added the Patch-For-Review tag to T27987 instead of T29987. [19:02:48] T29987: Function ccnorm shouldn't convert "I" and "L" to "1", "O" to "0" and "S" to "5" - https://phabricator.wikimedia.org/T29987 [19:02:49] T27987: prop=info&inprop=watched doesn't show if a missing page is watched - https://phabricator.wikimedia.org/T27987 [19:08:18] anomie: Numbers are hard :) [19:48:59] ostriches: there's a phpcs issue [19:49:08] figured lol [19:49:12] its a dumb file [19:50:51] Fixed. [19:52:37] +2'd [20:28:01] Thanks. [20:28:03] MaxSem: I'm cherry-picking that to REL1_27 too [20:28:41] ostriches, what? [20:28:55] ah, your commit [20:30:09] Yep [20:34:31] anomie: re: backporting the CentralAuth fix, is it worth it? none of the AuthManager updates are in 1.27 [20:34:44] or should all AM extension patches be backported? [20:35:31] tgr: I'd think it would be a good idea, unless we don't think any third parties are using it. [20:35:54] * anomie didn't know none of the AM patches for CA were backported [20:38:11] only patches for the bundled extensions [20:39:54] anomie: Am I probably right in guessing you don't need the sandbox/anomie/CentralAuth branch on MW anymore? [20:39:58] Just doing some tidying up [20:40:12] Branched like 3y ago lol [20:40:30] ostriches: I doubt it. 3 years ago was probably something for SUL2. [20:40:48] Ok gone [20:40:56] jdlrobson: sandbox/jdlrobson/design? Also 3y old [20:54:13] aude: Am I correct in guessing you don't really need Wikidata or wikidata-wmfphase1beta branches of mw/core? Date from 2012. [21:07:33] ostriches: i don't think so [21:07:38] it was for the content handler [21:08:37] anomie, tgr: uh, please backport CA patches for 1.27...I have to upgrade a wikifarm that is stupidly using it :( [21:21:56] bd808: \o/ it works [21:39:21] tgr (or others, if you know): If you had to pick *1* page to send a third party MW install to to best answer the "Help, my wiki broke after upgrading" and they're probably running outdated extensions, what would it be? [21:39:42] Mainly looking for a "tldr how do I fix?!?!?" [21:40:30] ostriches: if it's specifically about AuthManager issues then https://www.mediawiki.org/wiki/Manual:SessionManager_and_AuthManager/Updating_tips [21:40:40] That seems more for extension developers. [21:41:33] well, a site admin can't do much apart from updating extensions and hoping extension developers have fixed them [21:42:02] Mmk. [21:42:08] or do you mean, how do you figure out which extension is broken? [21:43:55] ostriches: https://www.mediawiki.org/wiki/Manual:SessionManager_and_AuthManager/Troubleshooting has some tips [21:45:03] but I'd expect most problems will require patching PHP code [21:48:57] Here's the section I've been wordsmithing: https://etherpad.wikimedia.org/p/rc1-release-email [21:52:56] Seem ok-ish? [21:56:43] Ok time's up. [22:11:11] ostriches: https://phabricator.wikimedia.org/T110291 might be worth pointing out - if your site has extensions which are listed there and not yet resolved, you probably want to hold off on updating [22:11:51] also we didn't backport most updates to 1.27; I should probably do that [22:13:13] Got 2 weeks before final :) [22:13:25] I expect to see lots of backports when I'm back from vacation :D [22:13:36] https://lists.wikimedia.org/pipermail/mediawiki-announce/2016-June/000190.html by the way [22:19:18] tgr, are there any plans of making WMF an OpenID provider? [22:32:39] MaxSem: not that I know of, but it is an OAuth provider and it has a protocol extension for identifying users [22:33:51] AuthManager can help with making WMF an OAuth consumer, but being a provider is not related to it [23:04:54] legoktm: awesome. Not sure why I didn't notice the need for arg parse changes the first time through