[07:23:52] <James_F>	 anomie: I don't know if for T137832 we care about the WikiObjectModel extension (no real commits in years), but if we do that'd block merge.
[07:23:52] <stashbot>	 T137832: Avoid use of APIEditBeforeSave hook to return precise error messages in the API, as it's possible with EditFilterMergedContent since 1.25 - https://phabricator.wikimedia.org/T137832
[13:07:14] <anomie>	 James_F: I note that's WikiObjectModel *calling* the hook, not having a hook function.
[13:08:18] <James_F>	 anomie: Indeed. I think we should just ignore it.
[16:12:55] <bd808>	 ori: when you have some time could you look at this mw-v puppet patch where tgr is trying to fix the goofy "invalid byte sequence in US-ASCII" bug? -- https://gerrit.wikimedia.org/r/#/c/295943
[17:07:46] <anomie>	 thcipriani: It looks like T138528 and T138529 are probably the same bug, that being that self::$filters isn't containing the filters for some reason. I972e9147a looks very suspect, on a cache hit it will never call self::checkAllFilters() -> self::checkFilter() which is where self::$filters gets filled in.
[17:07:46] <stashbot>	 T138528: Notice: Cannot access property on non-object in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php - https://phabricator.wikimedia.org/T138528
[17:07:47] <stashbot>	 T138529: Notice: Undefined index:  in /srv/mediawiki/php-1.28.0-wmf.7/extensions/AbuseFilter/AbuseFilter.class.php  - https://phabricator.wikimedia.org/T138529
[17:12:23] <thcipriani>	 huh, yup, that patch didn't quite make the cutoff for wmf.6 so it's only in wmf.7
[17:21:13] <anomie>	 thcipriani: As for the huge increase in number of posts, Ied77bdbd1 looks suspect: instead of doing the stash on the backend for previews, it now does it by posting from JS. I12d2c3bb might have something to do with the performance regression, since it will now actually parse revisions that were formerly skipped due to varying on revision, which is apparently a lot of pages thanks to templates using {{REVISIONID}} as a hack to check "am I in 
[17:21:13] <anomie>	 edit mode?" (see T137900).
[17:21:13] <stashbot>	 T137900: Deal with poor edit stash hit rate due to Lua modules using {{REVISIONID}} - https://phabricator.wikimedia.org/T137900
[17:25:27] <thcipriani>	 hmm, that one was definitely back-ported to wmf.6, FWIW