[00:08:36] FFS [00:09:00] Preprocessor_Hash doesn't even increment the generated node count [13:20:45] ori: Implement the custom serializer by implementing the Serializable interface? [19:23:21] Duplicate get(): "{key}" fetched {count} times [19:23:29] One of the spammiest log errors we have, mostly from commonswiki [19:26:57] what is the key? [19:28:12] heh [19:28:45] or key(s) [19:32:09] legoktm: "commonswiki:abusefilter:profile:*:total" [19:32:13] Fetched twice. [19:32:17] (the * is an integer) [19:32:37] Possibly related to all of the "undefined index on line NNN" we're seeing from AbuseFilter.class.php too [19:33:10] Other wikis too, but commons is loudest. [19:39:49] It's called in a deferred update [19:40:28] ostriches: should be only commons, other wikis don't have abusefilter profiling enabled, i think [19:42:15] ostriches: hmm. that probably happens for every upload on commons :D [19:42:28] this is probably from AbuseFilter::recordProfilingResult() [19:42:45] which is called once per filter, for every action that abusefilters are executed for [19:43:14] and abusefilters are executed twice for uploads, once with action=='upload', once with action=='stashupload' [19:43:44] (because core stuff sucks and we don't know whether it's a real upload, or just to stash) [19:51:34] ostriches: if you want to silence the logs, set $wgAbuseFilterProfile=false on commons (and any other wikis that have it true) [19:51:59] Silencing the logs would be nice. [19:52:08] But it's still ugly. [19:52:43] ostriches: and then, you can make the UploadVerifyFile pass information about whether the upload is to stash or about to be published, so that i can make AbuseFilter not run filters twice [19:52:57] (or you can make aaron make it, i guess) [19:53:07] the UploadVerifyFile hook* [20:04:39] bd808: do I need to do anything other than approve https://phabricator.wikimedia.org/D64 ? [20:05:14] Oh. I can land it [20:06:53] legoktm: thanks. If you have "free time" (yeah right) there are 2 PRs from me at https://github.com/wikimedia/composer-merge-plugin/pulls [23:04:20] ostriches: do I need to do anything special to be able to force push a master branch on gerrit? `git push -f origin master` isn't working, and I'm the owner of the mediawiki/debian repo [23:06:38] Push + force isn't granted by default since it's destructive and easy to accidentally things. [23:06:55] Grant your group "Push" with the "force" checkbox checked on the ACL on refs/* [23:06:58] And you're set [23:07:08] ah, thanks [23:07:10] yw