[16:26:27] <Reedy>	 How do we run phpunit phar now?
[16:40:04] <Reedy>	 MatmaRex: Any idea how we're supposed to run phpunit now?
[16:40:48] <MatmaRex>	 Reedy: eh, hm, `composer test` or something?
[16:40:55] <Reedy>	 really?
[16:41:17] <MatmaRex>	 i think there's still some manual way if you need to run a single thing, but i can't recall it now
[16:41:25] <MatmaRex>	 usually i just submit things to gerrit and wait for jenkins :P
[16:41:27] <Reedy>	 lol
[16:41:35] <Reedy>	 I was used to just passing a parameter to where hte phpunit phar lives
[16:41:40] <Reedy>	 that seems to ahve been removed
[16:41:50] <Reedy>	 if ( !class_exists( 'PHPUnit_Framework_TestCase' ) ) {
[16:41:50] <Reedy>	 	echo "PHPUnit not found. Please install it and other dev dependencies by
[16:41:50] <Reedy>	 running `composer install` in MediaWiki root directory.\n";
[16:41:50] <Reedy>	 	exit( 1 );
[16:41:50] <Reedy>	 }
[16:42:33] <MatmaRex>	 Reedy: tests/phpunit/phpunit.php ?
[16:42:46] <Reedy>	 yeah, it was a parameter to that
[16:43:35] <Reedy>	 reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core$ php tests/phpunit/phpunit.php 
[16:43:35] <Reedy>	 PHPUnit not found. Please install it and other dev dependencies by
[16:43:35] <Reedy>	 running `composer install` in MediaWiki root directory.
[16:43:37] <Reedy>	 do not want
[17:00:35] <Reedy>	 Anyone know how I use phpunit without installing it via composer?
[17:04:28] <Krinkle>	 OK. I give up. Is there a way to edit the commit message in the latest Gerrit?
[17:04:35] <Krinkle>	 I can't figure it out after staring at the interface for 10 minutes
[17:04:41] <MatmaRex>	 Krinkle: yes
[17:04:54] <Krinkle>	 I found an 'edit' button, but it seems to relate to files in the diff.
[17:05:02] <MatmaRex>	 it also works for the commit message
[17:05:18] <MatmaRex>	 click it, click "Commit message" in diff list, edit, "Save", "Close", "Publish"
[17:05:21] <MatmaRex>	 lots of clicks
[17:05:51] <Krinkle>	 What, that is a textarea?
[17:05:56] <Krinkle>	 It didn't look like one
[17:06:03] <Krinkle>	 I did actually get to the commit message after clicking edit
[17:06:09] <Krinkle>	 but it didn't look like a textarea 
[17:06:29] <Krinkle>	 With the bottom being cut off and the border being orange and dashed.
[17:06:34] <Krinkle>	 Ok. Thanks :)
[17:07:13] <Reedy>	 Tempting fix PHPUnit/Runner/Version.php
[17:07:14] <Reedy>	 ffs
[17:07:19] <Reedy>	 https://github.com/wikimedia/mediawiki/blob/cc7fca0c14398baeb88b949cfad71846b6b05c83/tests/phpunit/phpunit.php#L251-L271
[17:07:38] <MatmaRex>	 wow what's up with those indents there
[17:13:38] <bd808>	 Reedy: composer is the recommended way to install phpunit upstream now I think
[17:13:45] <Reedy>	 yeah
[17:13:49] <Reedy>	 MaxSem broke it :P
[17:14:04] <bd808>	 are you just hating on having multiple copies installed?
[17:14:55] <Reedy>	 Not really
[17:15:00] <Reedy>	 I just use hte WMF vendor git repo
[17:15:11] <Reedy>	 if ( MW_PHPUNIT_TEST ) {
[17:15:11] <Reedy>	 	include_once stream_resolve_include_path( '/var/www/wiki/mediawiki/phpunit.phar' );
[17:15:11] <Reedy>	 }
[17:15:15] <Reedy>	 I think that'll be my "fix"
[17:15:17] <bd808>	 ah. which has not dev deps in it
[17:15:27] <Reedy>	 though, stream_resolve_include_path isn't need
[17:15:30] <Reedy>	 Right, exactly
[17:15:53] <bd808>	 Reedy: just switch to mw-vagrant ;)
[17:16:09] <ostriches>	 pfft, you and your new fangled vms ;-)
[17:16:26] <ostriches>	 So hipster!
[17:16:35] <Reedy>	 if ( MW_PHPUNIT_TEST ) {
[17:16:35] <Reedy>	         include_once ( '/var/www/wiki/mediawiki/phpunit.phar-old' );
[17:16:35] <Reedy>	 }
[17:21:13] <Reedy>	 undefined constant...
[17:21:17] * Reedy grumbles
[17:21:22] <Reedy>	 oh, that's not in hte test
[17:21:25] <Reedy>	 defined()
[17:33:40] <Reedy>	 if ( defined( 'MW_PHPUNIT_TEST' ) && MW_PHPUNIT_TEST ) {
[17:33:40] <Reedy>	 	include_once ( '/var/www/wiki/mediawiki/phpunit-old.phar' );
[17:33:40] <Reedy>	 }
[17:33:42] <Reedy>	 hackhackhack
[17:35:45] <Reedy>	 Can someone merge https://gerrit.wikimedia.org/r/#/c/300525/ to fix some annoying logspam please?
[17:35:53] <Reedy>	 PHP Notice:  Second parameter should not be a timeout. [Called from TorExitNodes::loadExitNodes_Onionoo in /var/www/wiki/mediawiki/extensions/TorBlock/includes/TorExitNodes.php at line 170] in /var/www/wiki/mediawiki/core/includes/debug/MWDebug.php on line 309
[17:36:37] <Reedy>	 I guess that'll be some noise in prod too
[18:39:49] <Reedy>	 dear unit tests
[18:39:55] <Reedy>	 why the fuck are you failing post extension registration
[18:39:58] <Reedy>	 the config is still the same
[18:45:01] <ostriches>	 xoxo,
[18:45:03] <ostriches>	 reedy
[18:45:09] <Reedy>	 ty
[18:45:40] <Reedy>	 it vaguely feels like something is more subtley broken in the curren version(s)
[21:00:22] <ori>	 Reedy: and https://gerrit.wikimedia.org/r/#/c/300587/
[21:00:39] <Reedy>	 Yup
[21:00:48] <Reedy>	 I keep going down other rabbit holes :)
[21:01:25] <Reedy>	 ori: We could do with getting the other trusted-hosts stuff merged too soon
[21:01:30] <Reedy>	 tidy those up
[21:01:47] <Reedy>	 Let me test your commit
[21:03:23] <Reedy>	 ori: Do we really need to keep cdb support?
[21:03:27] <Reedy>	 Or literally only till we migrate over?
[21:03:35] <Reedy>	 Or being nice to other people that may use it?
[21:34:25] <Reedy>	 ori: ^^
[21:34:26] <ori>	 yeah, I think we should keep it
[21:34:29] <Reedy>	 heh
[21:34:35] <Reedy>	 FOR EVAH?
[21:34:35] <ori>	 it will still be faster on Zend
[21:34:45] <Reedy>	 Did we keep it everwhere else we replaced it?
[21:34:51] <ori>	 yes
[21:35:04] <Reedy>	 ah ok
[21:55:14] <Reedy>	 rebased, because of extension.json stuff
[21:59:08] <Reedy>	 reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core/extensions/TrustedXFF$ MW_INSTALL_PATH=/var/www/wiki/mediawiki/core php generate.php /tmp/xff.php
[21:59:19] <Reedy>	 It seems to be still trying to write a cdb
[22:07:21] <Reedy>	 ori: realpath turns /tmp/xff.php into false
[22:09:00] <ori>	 that's broken, but not broken by my change
[22:09:09] <Reedy>	 yeah
[22:09:12] <Reedy>	 just trying to test it :)
[22:09:30] <ori>	 i wonder why that call to realpath() is there at all
[22:09:32] <ori>	 it's not needed
[22:10:16] <Reedy>	 Blame brion in 2009
[22:10:36] <Reedy>	 guess we should remove it
[22:11:06] * Reedy carries on
[22:19:33] <legoktm>	 ostriches: is there I way I can get rid of the operations/mediawiki-config[master]: prefix in email subjects?
[22:19:48] <Reedy>	 ori: I think it was symlinked into the extension dir at one point... I seem to recall moving it out
[22:20:07] <ostriches>	 legoktm: Nerp. One template for errrybody <3
[22:20:08] <Reedy>	 uncommon dir on the apaches or similar
[22:20:28] <ori>	 even if it's a symlink, so what?
[22:20:57] <legoktm>	 ostriches: :( I have mail filters to sort everything in subfolders so I don't need that extra context...
[22:21:47] <legoktm>	 I will survive though
[22:21:47] <ostriches>	 Sorry :(
[22:21:56] <legoktm>	 it's alright, the rest of the gerrit changes are absolutely awesome <3
[22:22:04] <ostriches>	 :D
[22:22:12] <ostriches>	 I closed like 35 bugs today!
[22:54:09] <MatmaRex>	 legoktm: ostriches: the prefixes are great, i can now ignore backports at a glance!
[22:54:49] <legoktm>	 MatmaRex: I had thunderbird set different colors on emails with a non Gerrit-Branch: master header
[22:55:35] <MatmaRex>	 legoktm: setting up thunderbird filters is so braindead though, i try not to touch them often
[22:55:54] <MatmaRex>	 i already have a bunch for all the bots, for gerrit merges, and such