[00:40:27] Oh no, gerrit removed the old theme [00:40:34] Or is it still there somewhere? [00:50:44] The old change screen? Yeah that's gone forever. [00:55:11] ostriches: But the new circus theme is so buggy... [00:55:39] Sorry. [00:55:56] It's one of the reasons I delayed upgrading for years. I hate the new screen too. [00:56:42] scroll synchronisation in diff view is not implemented properly, comment handling is annoying, commit message (most important thing) is visually deprioritised and overflow-scroll'ed by default, so it's quite tiny. It used to be prime-time. Also there is no longer a way to view the commit message while viewing a diff from the top menu. Commit message editor [00:56:42] is broken in various ways. and more.. [00:57:07] ostriches: I guess there were other benefits from upgrading? [00:57:22] * Krinkle is trying to catch up with mailing lists but there is too much [00:57:47] Being on a supported branch (so plenty of security fixes that never got backported). Way faster (in basically every regard). [00:58:01] speed is relative. [00:58:05] I closed ~35 bugs today. [00:58:06] I'm 10x slower today. [00:58:17] For old issues people had filed that had been fixed. [00:58:53] The SSH daemon is way faster, which makes git operations (plus zuul talking to gerrit) way faster. [00:59:11] Yeah, I saw a few of those. Most of those from my POV were functional bugs, not UI bugs - which has higher impact on productvity imho. [00:59:41] With Phabricator being an even more immature platform for code review, this puts us in a bad position for code quality. [00:59:56] I think you're overstating a day 1 learning curve. [01:00:10] We'll see. [01:00:15] Indeed. [01:00:42] I've been through other upgrades in similar ways that didn't feel like this. [01:00:55] Anway, genuine thanks for pulling it off. It was a major upgrade. [01:01:16] Krinkle: it took me about a week to get used to the new change screen when I switched. Once you know where things moved, it becomes a ton more featureful than the old one [01:01:40] the new positions of buttons and shortcuts I can get used to. [01:02:18] We can do CSS tweaks still too. And I don't see why we couldn't inject some custom JS possibly :) [01:02:46] I've started hacking away at the css -- https://github.com/bd808/userscripts/blob/gh-pages/wmfgerrit.user.css [01:03:07] But the fact that it makes viewing the diff harder to read (bad UI rendering, scroll jitters like crazy, unreadable, almost making me epileptically dizzy), and the commit message being rendered the way it is, that's not gonna change over time. [01:03:27] ostriches: Yeah, the diff handling would require removing JS rather than adding more. [01:03:33] my hacks are mostly about getting it to fit on my web browser [01:03:34] Thanks to closure, it's not always possible to remove that effectively. [01:03:57] So, the diff handling is different because it's actually not doing Just Diffs anymore. [01:04:04] It uses CodeMirror so it's also an in-browser editor [01:04:07] (Oh, features!) [01:06:11] bd808: Once you finish hacking up some CSS we can totally try them out on gerrit-test and then pull them into prod :) [01:07:15] ostriches: well greasemonkey works for me and then I don't have to compromise by keeping things that others want that I don't care about ;) [01:08:05] Well I'm sure some things you're doing are useful ;-) [01:08:10] (to others ;-)) [01:08:33] the selectors I had to use for .changeTable on the all changes/my changes screen are gross [01:08:36] div#gerrit_body.gerritBody > div > div > div.screen > div > table.changeTable [01:09:32] the list of files on a patch has the same .changeTable class for no good reason I can see [01:11:04] They like that .changeTable class [01:11:06] It's like everywhere [13:54:35] Ugh. The new Gerrit eats stuff like Ctrl+T. [13:55:00] there's a bug for it. supposedly fixed in next point release. [13:59:17] anomie: hmm, i actually have a question for you. i want to implement HTMLForm 'hide-if' functionality for OOUI HTMLForms. i'm having trouble figuring out just what exactly is supposed to work, since your implementation in mediawiki.htmlform.js appears to allow all kinds of weird stuff, and i'm not sure if i have to replicate for the OOUI [13:59:34] MatmaRex: [13:59:48] for example hideIfGetField() – why does it allow multiple variants of the 'name', and why does it walk the ancestor tree rather than just look at the current element's form? [13:59:52] MatmaRex: The intent of it is to be able to say "hide this field if this condition is true" [14:01:13] The multiple variants are because HTMLForm does some weird renaming of fields in some cases, so it takes that into account. The walking of the ancestor tree is to handle cases where you have essentially the same field in the form multiple times (e.g. HTMLFormFieldCloner), it needs to use the most proximate version to work right. [22:28:07] bd808: is there an easy way to get the JSON representation of the event in the new kibana? [22:28:38] as in, something that can be copy-pasted and is valid JSON [22:29:24] tgr: open the event and hit the json tab? [22:29:35] looks like valid json to me [22:29:49] too many newlines :( [22:30:00] https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2016.07.26/syslog?id=AVYpUzC65t-gr1WUbx85 [22:30:52] I would have to manually remove all the linebreaks in long strings [22:31:45] I don't get any line breaks in strings when I copy-n-paste from there [22:31:45] I guess I can just remove all newlines and then it will be valid (if ugly) [22:31:57] what browser are you using? [22:32:04] Friefox [22:32:16] hm, looks like Chrome is stupider there [22:32:21] FF 47.0.1 [22:33:14] the markup is a textbox with the json dumped in it and some js pretty printer [22:33:44] ctrl-A even works to select all for me [22:34:26] yeah, and the pretty-printer makes each visual line its own div [22:34:37] apparently Chrome gets confused by that [22:36:05] old Kibana had a raw JSON option, but I'll just write a script for that then [22:37:00] or stop using chrome ;) [22:37:35] that might work too [22:38:05] it used to be the only way to get decent flash support on Ubuntu but I guess these days I would not miss out on much without that