[13:39:48] Heh. Firefox whines about Gerrit's diff scrolling: "This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects for further details and to join the discussion on related tools and features!" [14:57:30] Grr. New gerrit's diff doesn't allow selecting code something to middle-click-paste it elsewhere. [15:03:20] anomie: it works for me with selecting and Ctrl+C – Ctrl+V. (or do you mean middle click copy-paste specifically?) [15:03:40] I mean middle click copy-paste specifically. [15:06:50] * anomie is going to have to remember that Shift+Insert or Ctrl-Alt-V is paste in urxvt. [15:59:24] It seems that gerritbot no longer adds #Patch-For-Review. Is that intentional? [16:07:35] anomie: hmmm... seems unlikely. [16:08:10] the new gerrit version changed somethings about how data is presented, maybe the bot hasn't caught up yet [16:12:47] that bot is actually a gerrit plugin -- https://gerrit.googlesource.com/plugins/its-phabricator/+/refs/heads/master -- I'm not sure exactly how it works or how to update it [16:13:04] * anomie files T141448 [16:13:31] * anomie notes stashbot apparently ignores /me [16:14:04] stashbot: T1234 [16:14:05] T1234: Restrict Bugzilla access to read-only - https://phabricator.wikimedia.org/T1234 [16:14:17] stashbot: T141448 [16:14:17] T141448: Gerritbot no longer adding Patch-For-Review - https://phabricator.wikimedia.org/T141448 [16:14:24] * bd808 shrugs [18:04:37] bd808: he meant it ignores /me, not him :P [18:05:34] lol. Yeah I bet it's not looking at ACTION messages [18:07:25] It's only hooking irc.bot's on_pubmsg callback [18:14:56] https://gerrit.wikimedia.org/r/#/c/300577/ finally passed tests, yay [18:14:58] (trivial) [22:40:02] huh [22:40:19] the new gerrit diff screen is an exercise in fail [22:40:44] scrolling lags, pgup/pgdown does not work, ctrl-f does not work... [22:43:31] it takes over ctrl+f, doesn't it? [22:44:08] yes but poorly [22:44:49] but if you press ctrl-f again you get the browser's search but it only searches in the portion of the page that is visible [22:45:06] I do not even dare to imagine how they achieved that [22:45:25] reimplemented web pages on a canvas or what? [22:45:34] I saw some chatter on irc that upstream has moved on to yet another ui design too [22:45:49] because why not! [22:46:25] the gerrit version of find in page does not have a prev/next function as far as I can tell, which makes it pretty useless [22:48:46] tgr: yeah, it renders as you scroll. it uses some variant of CodeMirror [23:34:24] it seems like line wrapping in gerrit diffs could be fixed by a simple CodeMirror config change [23:35:01] and native scrollbars could be enabled by commenting out a few lines in gerrit (or figuring out how to override its overrides) [23:35:12] is there a test gerrit installation? [23:39:20] tgr: paladox has one in labs. it's running a newer version of gerrit though which is not entirely helpful