[00:49:15] thanks Reedy! sorry for not testing, a bit swamped today [00:49:26] it's alright :) [00:49:43] It seems to work. Get's a few days to sit around on beta [07:49:22] tgr: thanks for the revert. somehow all of us pywikibot people totally missed that it would break :S [07:53:39] sure, reverting for a limited time is no big deal [07:53:52] legoktm: I wonder how the unit tests missed it though? [07:56:26] https://integration.wikimedia.org/ci/view/Pywikibot/job/pywikibot-tests-beta-cluster/lastBuild/consoleFull "02:30:43 Ran 0 tests in 0.013s" [07:56:31] wow [07:59:26] wtf, pwb constructs cookies manually? [07:59:46] no, that's the really sad part [07:59:48] it doesn't [07:59:55] but it still has the code to do so [08:00:10] and *that* was failing [08:00:40] also, am I the only one or search went kaboom on enwiki? [08:02:03] nope, pages went off [08:02:20] yeah, broken [22:26:45] $wgHooks['ChangeTagsListActive'][] = [22:26:45] array( 'MediaWiki\Extensions\OAuth\MWOAuthHooks::getUsedConsumerTags', true ); [22:26:51] What's the purpose of the true? [22:27:17] There's one with a false too in OAuth [22:32:02] Hmmm [22:32:11] Seems to be some weird extra parameter to be passed into the hook itself? [22:32:16] public static function getUsedConsumerTags( $activeOnly, &$tags ) { [22:32:32] Hooks::run( 'ChangeTagsListActive', [ &$extensionActive ] );