[00:07:51] <Krinkle>	 robla: Thanks for the update at https://phabricator.wikimedia.org/E259#2918
[00:08:35] <robla>	 Krinkle: no prob, thanks for chairing!
[00:09:25] <robla>	 I'm currently futzing with automating bits of doing those updates
[00:11:51] <robla>	 Krinkle: btw, I wasn't expecting you (or anyone) to do any of the post-meeting rituals that I typically do; I was just looking for someone less biased than me to chair
[00:12:12] <Krinkle>	 Sure, no worries.
[19:43:49] <ostriches>	 Someone mind having a look at these two backports? https://gerrit.wikimedia.org/r/#/q/is:open+project:mediawiki/core+-branch:master+owner:%22Chad+%253Cchadh%2540wikimedia.org%253E%22
[19:44:09] <ostriches>	 The REL1_23 concerns me more, as the unit tests aren't run by Jenkins and I'm having trouble getting them to run locally on REL1_23.
[19:44:26] <ostriches>	 (HtmlTest was a *disgusting* conflict I had to do manually)
[19:44:40] <ostriches>	 plz & ty and I owe someone a beer <3
[19:51:31] <James_F>	 ostriches: Meh. Whose silly idea was it to support 1.23 this long? ;-P
[19:53:30] * James_F methodically uninstalls all his extensions to test it.
[19:55:08] * ostriches mutters something about LTS
[19:55:13] <ostriches>	 It wasn't me!
[19:55:30] <ostriches>	 It least 1.19 is dead. Supporting *that* sucked
[19:55:31] <James_F>	 ostriches: Uh-huh.
[19:56:28] <James_F>	 Yeah.
[19:56:42] <James_F>	 If only we'd all agreed to stop it from 1.27 onwards. Oh, wait.
[20:05:15] <James_F>	 ostriches: Hmm. "Unexpected non-MediaWiki exception encountered, of type "PHPUnit_Framework_Exception" [b8510769] [no req]   Exception from line 30 of /vagrant/mediawiki/vendor/phpunit/phpunit/src/Util/InvalidArgumentHelper.php: Argument #1 (No Value) of LessFileCompilationTest::__construct() must be a readable file"
[20:05:59] <James_F>	 I think it's probable I'm just Doing It Wrong™
[20:06:12] <ostriches>	 Exactly where I got stuck
[20:06:21] <James_F>	 Yeeeeeah.
[20:06:23] * James_F sighs.
[20:10:00] <James_F>	 ostriches: I just +1'ed, sorry.
[20:10:33] <ostriches>	 Does +2 do unit tests for 1.23?
[20:10:35] * ostriches shrugs
[20:10:53] <James_F>	 ostriches: I'd be very surprised if we had unit tests for gate but not check.
[20:11:37] <ostriches>	 Prolly right
[20:11:54] <ostriches>	 I guess I should figure out what's causing that exception
[20:12:00] <James_F>	 Sorry.
[20:12:36] <ostriches>	 Actually, I got of type "Error" but otherwise the same
[20:12:37] <ostriches>	 Hmmmmm
[20:13:20] <ostriches>	 Class 'SebastianBergmann\Version' not found
[20:13:22] <ostriches>	 Fantastic!
[20:13:30] <ostriches>	 Too new PHPunit + too old MW?
[20:16:24] <ostriches>	 Hmmm, other way around?
[20:16:39] <ostriches>	 I've got PHPUnit_Runner_Version in that file.
[20:20:28] <ostriches>	 There we go!
[20:20:41] <ostriches>	 James_F: `composer require phpunit/phpunit` in your MW root directory
[20:21:01] <ostriches>	 Couple of failures. That's better.
[20:22:37] <ostriches>	 https://phabricator.wikimedia.org/P3819
[20:24:18] <ostriches>	 Funny, couple of attributes still wanted to be unquoted.
[20:24:48] <James_F>	 Odd.
[20:25:24] <ostriches>	 Ah, I see it
[20:25:33] <ostriches>	 I was reading it backwards.
[20:26:26] <ostriches>	 OK (64 tests, 84 assertions)
[20:26:33] <ostriches>	 Pushing amended patch
[20:27:28] <ostriches>	 https://gerrit.wikimedia.org/r/#/c/304300/1..2/tests/phpunit/includes/HtmlTest.php was the fix
[20:27:43] <ostriches>	 https://gerrit.wikimedia.org/r/#/c/304300/1..2/ shows nothing else changed
[20:34:58] <James_F>	 ostriches: Merged. Also there was a request for release notes on the 1.26 merge.
[20:35:51] <ostriches>	 Left a note.
[20:35:55] <James_F>	 kk
[20:39:30] <ostriches>	 Ahahahaha, it does run tests!
[20:39:41] <ostriches>	 And I failed!
[20:41:12] <ostriches>	 Hah! What a busted test in REL1_23
[20:41:31] <ostriches>	 Wait...whaaaa?
[20:42:51] <ostriches>	 The test stripped the closing </li>?
[20:43:16] <ostriches>	 -'<li class="class" title="itemtitle"><a href="url" title="title">text</a></li>'
[20:43:17] <ostriches>	 +'<li class="class" title="itemtitle"><a href="url" title="title">text</a>'
[20:44:43] <ostriches>	 Weird.....
[20:54:44] <ostriches>	 James_F: Relatedly lol, https://gerrit.wikimedia.org/r/304323
[21:54:05] <ostriches>	 That failed test bothers me.
[22:39:03] <bd808>	 ostriches: which failed test?
[22:39:19] <ostriches>	 https://gerrit.wikimedia.org/r/#/c/304300/
[22:39:19] <ostriches>	 https://integration.wikimedia.org/ci/job/mediawiki-phpunit-php53/599/console
[22:39:41] <ostriches>	 It trims the closing </li> in the result
[22:39:51] <bd808>	 hmmm
[22:42:03] <bd808>	 so that's Html::rawElement failing to close it I guess
[22:42:41] <ostriches>	 Yeah which is...odd
[22:43:18] <bd808>	 li is surely not in voidelements
[22:43:38] <ostriches>	 Ah hmmm
[22:43:40] <ostriches>	 I see....
[22:44:03] <ostriches>	 Backport missed some stuff
[22:44:04] <ostriches>	 I see
[22:47:15] <ostriches>	 Manual backports suck. Amended and pushed.
[22:49:21] <bd808>	 ah ha! Html::closeElement was skipping it
[22:49:42] <bd808>	 oh html how you really suck
[22:50:14] <ostriches>	 Funny thing is the patch gave me zero complaints on that file.
[22:50:19] <ostriches>	 So I didn't look twice
[22:50:27] <ostriches>	 git you so useless!
[22:50:30] <bd808>	 "typing is hard and bandwidth is expensive in 1994, so lets make the spec really loose and weird"
[22:53:45] <ostriches>	 Trying the +2 again to see what happens :p
[22:58:52] <ostriches>	 Yay I win!
[22:59:03] <ostriches>	 Just needed that second set of eyes to tell me where I should look closer :p
[23:06:54] <James_F>	 bd808: Cf. "Referer"
[23:07:02] <James_F>	 ostriches: :-)
[23:08:40] <legoktm>	 ostriches: CI isn't running phpunit for 1.23?
[23:09:01] <ostriches>	 It does on gate-and-submit, not on initial test.
[23:09:14] <James_F>	 I was surprised too.
[23:09:21] <legoktm>	 You can comment "check php5"
[23:09:42] <ostriches>	 Oh well, rel1_23 sucks anyway 😂
[23:09:50] <James_F>	 Helpful.
[23:22:07] <Reedy>	 When do we stop supporting it?
[23:30:18] <ostriches>	 NEVER!
[23:30:21] <ostriches>	 (may 2017 I think)