[02:14:16] ok [02:38:24] TimStarling: thanks. If you are feeling ambitious, there is the smallish patch at https://gerrit.wikimedia.org/r/#/c/308326 too [02:39:03] I filed a bug for you, I didn't realise you would be around so late [02:39:34] https://phabricator.wikimedia.org/T144706 [02:40:20] did my comments make sense? [02:42:39] yes, ok [02:43:30] maybe it could be mentioned in the WANObjectCache class doc comment? [02:47:40] https://doc.wikimedia.org/mediawiki-core/master/php/classWANObjectCache.html#a83f206cc616ee6492941da9e0a2db2f0 [02:48:24] TimStarling: the last sentence for pcTTL mentions this. Maybe the wording is lacking? [02:49:53] I had not read that [02:50:07] it's fine [02:51:26] the funny thing is, clearProcessCache() was already called, it was just called from an odd place and so had escaped refactoring so far [02:51:46] and the symptom I was seeing was actually due to the RepoGroup cache [02:52:55] I'm going through all these undocumented setup operations in parser tests and adding comments, and clarifying the setup stage they need to be run at [02:53:10] making it clear which operation invalidates which caches [02:53:36] I'm glad someone is sorting through that mess