[00:23:20] does anyone know for how long it has been possible to call a function with syntax ($foo->bar)($baz)? [00:33:27] never mind [03:53:01] scrollable commit message div [03:53:13] because who really wants to read all that garbage? [04:39:34] Hmmm, at least Gerrit provides a clickable arrow/chevron thing to expand it. [07:32:48] true [08:15:24] TimStarling: https://gerrit.wikimedia.org/r/#/c/309169/ [08:15:48] * AaronSchulz was surprised the default was 0 [17:54:21] anomie: yt? [17:55:19] dr0ptp4kt: yes [17:55:35] anomie: got 5 mins for ghangout? [17:55:41] Sure [17:55:53] anomie: k, i'm on the line... [18:58:52] for some reason Google Chrome thinks the Gerrit login page is in Indonesian [19:13:24] ori: It secretly is ;-) [19:13:36] aude: You were right, db errors from wikidata going down! :) [19:15:59] bd808: I finally got around to writing https://github.com/composer/composer/pull/5660 [19:16:32] they rejected a patch like that before :/ [19:17:11] or at least a bug report that suggested that it would be a good idea [19:17:31] but it would be nice to see it land :) [19:21:56] legoktm Hi, did you manage to do https://gerrit.wikimedia.org/r/#/c/302416/ please? [19:22:08] (not duplicate from -devtools just moved it here) [19:22:18] bd808: https://github.com/composer/composer/issues/5651#issuecomment-245191150 said to send a pull request :) [19:22:58] paladox: huh? I don't know much about that patch [19:23:29] Oh sorry [19:23:31] legoktm ^^ [19:23:32] I mean [19:24:03] https://gerrit.wikimedia.org/r/#/c/193434/ [19:24:11] legoktm ^^ that one and sorry about the wrong link [19:24:25] No, not yet. [19:24:39] Ok [19:24:48] legoktm also could you deploy https://gerrit.wikimedia.org/r/#/c/309048/ please? [19:25:11] yeah, let's talk about that in -releng [19:25:36] Ok [19:25:59] legoktm also when you have a chance could you do https://gerrit.wikimedia.org/r/#/c/193434/ please? [19:28:02] "pl proc line: 2959: warning: points must have either 4 or 2 values per line" [19:28:05] What the heck is this ^? [19:31:57] ostriches: a google search hits on easy timeline -- http://comments.gmane.org/gmane.comp.graphics.ploticus/1465 [19:33:08] Ah hmm, grepping extensions didn't help :) [19:33:41] This is a pretty new one in the logs. Wonder if something changed. [19:34:09] it apparently comes from the ploticus exe that easy timeline uses [19:38:31] Yeah I figured once you mentioned timeline. I wonder if the package upgraded under us. [19:38:33] Or something [20:17:23] "MediaWiki\Auth\AuthManager::autoCreateUser: {username} failed with message {message}" <- How important are these? [20:17:29] They're being logged at the ERROR level [20:17:56] All with "Username entered already in use. Please choose a different name." [20:17:57] depends on the message [20:18:02] afaict [20:18:22] Almost all from loginwiki [20:18:37] that's either a race condition or a bug; it should not try to autocreate when the user already exists [20:18:47] race condition is more likely [20:21:01] Hmm. Bug for tracking this down yet? [20:21:18] I don't think we have one [20:21:34] Aaron: LBFactory::commitAndWaitForReplication: cannot commit; LinksUpdate::incrTableUpdate does not have outer scope. [20:21:57] Same LBFactory::getEmptyTransactionTicket: CategoryMembershipChangeJob::notifyUpdatesForRevision does not have outer scope. [20:29:32] ostriches: did you file a bug? [20:29:41] Not yet, I got distracted. [20:29:50] will do it [22:13:20] ostriches: is that DBPerformance? [22:13:57] Lemme look, mediawiki-errors I think [22:14:17] Yep, DBPerf channel [22:19:08] ostriches: that was fixed in https://github.com/wikimedia/mediawiki/commit/6c73b32fd5b2a0c17d0fb32935804b6457ccd992 [22:19:38] ostriches: maybe I can make a simple patch to just do the doUpdates() fix [22:19:44] that should avoid DB lag issues [22:20:09] :) [22:54:35] legoktm: your simple and logical change has run into the wall of "consensus needed" FUD :(( [22:57:08] Am I surprised that enwp is the only wiki that's complained about it so far? nope. [22:57:49] If you only knew an admin there who could talk to the natives.... ;) [22:59:39] I'm trying :S [23:13:16] tgr: I'm amending the getId patch [23:27:00] AaronSchulz: thanks for fixing it up [23:27:53] I'll figure it out [23:33:11] ostriches: \o/ [23:33:36] legoktm: have you thought of linking it from the page info? [23:34:19] hmmm, that would be pretty good [23:37:07] legoktm: my big concern about opening it up would be that it allows arbitrary content for handlers which until now expected to be the sole authority on what can be saved in that content type [23:37:54] tgr: I'm not sure what you mean by that...arbitrary content has always been possible via the API. Do you mean arbitrary locations? [23:37:55] are all content handlers that store, say, structured data in a JSON blob, prepared to deal with arbitrary user input? [23:38:38] I think so. I reviewed most of them when checking ContentHandler::canBeUsedOn() stuff and all of them validated properly iirc [23:38:50] (but that was also like a year ago)