[03:08:42] <AaronSchulz>	 TimStarling: hey, can you took a look at https://gerrit.wikimedia.org/r/306554  ?
[03:10:11] <TimStarling>	 ok
[03:10:37] <TimStarling>	 35 patchsets
[03:11:36] <AaronSchulz>	 I've grown found of the gerrit "edit" button
[03:11:55] <AaronSchulz>	 one of the things I DO like about the new GUI
[03:18:07] <TimStarling>	 "For redirects emitted after changes in POST" -- does this mean normal page saves?
[03:19:51] <AaronSchulz>	 yes
[03:38:36] <TimStarling>	 $store = $this->store;
[03:38:40] <TimStarling>	  $store::TTL_DAY
[03:38:47] <TimStarling>	 does that even work?
[03:39:06] * TimStarling tries 3v4l
[03:40:44] <TimStarling>	 apparently since 5.3
[03:41:27] <TimStarling>	 not mentioned on http://php.net/manual/en/language.oop5.paamayim-nekudotayim.php though
[03:49:33] <AaronSchulz>	 it's used all over the place in MW
[03:52:29] <AaronSchulz>	 hmm, I wonder why I didn't just give a "return as string" parameter to OutputPage::output
[03:52:50] <legoktm>	 TimStarling: " As of PHP 5.3.0, it's possible to reference the class using a variable. The variable's value can not be a keyword (e.g. self, parent and static). " ?
[03:54:59] <TimStarling>	 yeah, but it's an object, not a class name
[03:57:40] <TimStarling>	 reading the manual, you would think it would be
[03:57:51] <TimStarling>	 $class = $this->store::class
[03:57:56] <TimStarling>	 $class::TTL_DAY
[03:58:08] <TimStarling>	 or something
[03:58:44] <TimStarling>	 meh, I was never a fan of LSB
[04:02:31] <legoktm>	 ah
[04:13:54] <TimStarling>	 I have a comment!
[04:15:30] <TimStarling>	 now I can go back and nitpick on comment grammar without feeling bad
[04:22:00] * AaronSchulz goes off for groceries
[04:45:27] <TimStarling>	 done
[05:28:47] <AaronSchulz>	 TimStarling: funny, every time I tested it, I get the parameter and right debug comments...so newFromUrl() must be....ahh nevermind
[05:29:24] * AaronSchulz might have to make a new function
[05:32:19] <AaronSchulz>	 TimStarling: oh, here's another patch: https://gerrit.wikimedia.org/r/#/c/309918/2
[10:11:31] <legoktm>	 anomie: I was thinking about having edits that change the content model have a change tag so it's obvious in the revision history...but looking through ChangeTags, I don't see how to define a core change tag? Can I just add it to the list in listExtensionDefinedTags() ? Does it matter whether a change tag comes from core or an extension?
[13:14:21] <anomie>	 legoktm: Are you asking about accessing ParserOptions from an on-wiki module or from an extension-provided library? If the former, not currently but we could theoretically add it. If the latter, sure, there's even Scribunto_LuaLibraryBase::getParserOptions() to easily access it instead of ->getEngine()->getParser()->getOptions().
[13:24:31] <anomie>	 legoktm: I think we may have forgotten to put in a real mechanism for core-defined tags. Adding them to the return value from listExtensionDefinedTags() would have the right behavior, if not exactly the right semantics. At one point I believe Cenarium was trying to add core-defined tags along with a lot of other changing-around of things, although I stopped paying attention to that a while ago.
[21:31:40] <legoktm>	 anomie: from a Scribunto-provided library...I need to update one of the nowiki functions for https://gerrit.wikimedia.org/r/#/c/309528/
[21:43:31] <tgr>	 anomie: can you merge https://gerrit.wikimedia.org/r/#/c/306133/ if you have no further concerns? I'd like to get it on next train, see if it unbreaks pwb compat login
[23:52:26] <AaronSchulz>	 xmfwiki
[23:52:26] <AaronSchulz>	 -------------------------------------
[23:52:26] <AaronSchulz>	 Resetting user_token for "Anomie":  OK
[23:52:33] <AaronSchulz>	 haha