[18:18:12] addshore: https://gerrit.wikimedia.org/r/#/c/311724/ [18:38:28] hoo: https://gerrit.wikimedia.org/r/#/c/311724/2 [18:41:50] will have a look in a bit [19:24:30] anomie: I believe I owe a h/t to you for the xkcd I referenced in this comment: https://www.reddit.com/r/wikipedia/comments/53js5v/wikipedias_mobile_website_now_uses_less_data/d7uzmsa [19:25:48] (: [20:36:01] robla: the work has been largely complete for some time -- https://test.wikipedia.org/wiki/Main_Page is using Responsive Vector (trying manipulating your browser window dimensions) [20:36:26] see https://phabricator.wikimedia.org/T106463 [20:36:34] * robla looks [20:38:12] it's in use on some wikis, like https://wikimediadc.org/wiki/Home [20:40:12] neat! [20:49:27] that's... very far from being usable [20:50:19] in general, I think it's unrealistic to expect a responsive framework of acceptable quality without doing mobile-first design [20:50:58] which would mean radically changing how the desktop interface looks, which would mean torches and pitchforks [20:51:17] so we are kind of stuck with the separate mobile site [21:13:51] * anomie wonders if "which would mean radically changing how the desktop interface looks" means "make it look like oversized crap like more and more sites do these days" [22:04:57] tgr: I was just thinking of mTrxLevel and made amended at the time you commented. I also add an isOpen() check now. [22:18:56] tgr: thanks. Somewhere in unit tests there is some cloning going on. [22:19:30] which is why just doing the __destruct() part alone would fail, since two handles had the same resource [22:19:54] * AaronSchulz has been stuck in the unit test rabbit hole all day [22:20:43] I think a clone() method which creates and returns a new instance would be less fragile, but as long as it's only used in tests, meh [22:20:55] TimStarling: want to CR https://gerrit.wikimedia.org/r/#/c/311771/? Who knows, maybe you'll find some fun typos :) [22:21:20] tgr: that's why I have the warning. I don't really want cloning going on, but it should at least not blow up as badly. [22:39:31] "dataase" [22:41:24] This, the role of "master" -> Thus the role of "master" [22:41:44] is -> in [22:42:24] time to take the kids to the bus stop [22:59:18] you did ask for this, right? [23:31:05] would you prefer these sorts of comments as just changes in a new patchset? [23:51:57] TimStarling: either way is fine